Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting entitlements fails when app group value is a string #160

Merged
merged 1 commit into from Dec 26, 2017

Conversation

Projects
None yet
2 participants
@cacheflow
Copy link
Contributor

cacheflow commented Dec 26, 2017

-A false positive occurs when a string is set as the value for com.apple.security.application-groups in entitlements.
-Originally the check looked for the absence of app identifier in an array, which returned true even if the input is a string.
-This fixes that by ensuring the value is an array before searching for app identifier.

Fixes Inserting of Non-Existant App Groups
-A false positive occurs when a string is set as the value for com.apple.security.application-groups in entitlements.
-Originally the check looked for the absence of app identifier in an array, which returned true even if the input is a string.
-This fixes that by ensuring the value is an array before searching for app identifier.
@sethlu

sethlu approved these changes Dec 26, 2017

@sethlu sethlu merged commit 742d031 into electron-userland:master Dec 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sethlu

This comment has been minimized.

Copy link
Member

sethlu commented Dec 26, 2017

@cacheflow Merged. Thanks for opening this PR! 🎉

Resolves #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.