Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use Pepper Flash plugin in packaged app (MacOS X) #114

Closed
wolfflow opened this Issue Aug 9, 2015 · 14 comments

Comments

Projects
None yet
10 participants
@wolfflow
Copy link

wolfflow commented Aug 9, 2015

I'm unable to harness PPAPI Flash in app packaged by electron packager under MAC OS X
OS: MacOS X 10.10 Yosemite
Electron: 0.30.3

Sample app: https://github.com/hokein/electron-sample-apps/tree/master/pepper-flash-plugin

NOTE: Windows and Linux packaged apps work well

@subblue

This comment has been minimized.

Copy link

subblue commented Aug 24, 2015

I was having issues with Flash not working until I added 'web-preferences': {'plugins': true} to the new BrowserWindow() options. This was with version 0.31.0

@wolfflow

This comment has been minimized.

Copy link
Author

wolfflow commented Aug 26, 2015

@wolfflow

This comment has been minimized.

Copy link
Author

wolfflow commented Sep 2, 2015

@malept malept added the question label Sep 9, 2015

@asual

This comment has been minimized.

Copy link

asual commented Sep 24, 2015

I'm hitting this only when using the "--asar" option.

@FrancisVarga

This comment has been minimized.

Copy link

FrancisVarga commented Oct 14, 2015

Hi i have the same issue and i actually remove the --asar flag already still flash plugin can't be detected

@jespermjonsson

This comment has been minimized.

Copy link

jespermjonsson commented Oct 16, 2015

I had the same issue, but after upgrading electron packager from 4.2.0 to 5.1.0 the "X Helper EH.app" was named with the correct application name and "navigator.plugins" is now populated (even with --asar flag).

@FrancisVarga

This comment has been minimized.

Copy link

FrancisVarga commented Oct 19, 2015

@jespermjonsson i'm using:

"electron-packager": "^5.1.0",
@hokein

This comment has been minimized.

Copy link
Contributor

hokein commented Oct 25, 2015

Verified it works on electron-package v5.1.0 with https://github.com/hokein/electron-sample-apps/tree/master/pepper-flash-plugin sample:

electron-packager ./ flash --asar --platform=darwin --arch=x64 --version=0.34.0

But it won't work with --asar option.

@patricksebastien

This comment has been minimized.

Copy link

patricksebastien commented Feb 23, 2016

@hokein My app is working when using npm start, but not when packaging the app. Do I have to copy PepperFlashPlayer.plugin after packaging my app? I tried many folders in Contents... Did you want to say that it is working only without the --asar option?

What should the path be:
app.commandLine.appendSwitch('ppapi-flash-path', 'PepperFlashPlayer.plugin');
or
app.commandLine.appendSwitch('ppapi-flash-path', './PepperFlashPlayer.plugin');

@positlabs

This comment has been minimized.

Copy link
Contributor

positlabs commented Feb 23, 2016

@patricksebastien I've found that binaries can't be run from inside of an asar package. Try moving the plugin to asar-unpacked dir.

@patricksebastien

This comment has been minimized.

Copy link

patricksebastien commented Feb 23, 2016

@positlabs Yes did that but how to call the plugin, I tried:
app.commandLine.appendSwitch('ppapi-flash-path', __dirname + '/../app.asar.unpacked/PepperFlashPlayer.plugin');
not working...

@positlabs

This comment has been minimized.

Copy link
Contributor

positlabs commented Feb 23, 2016

This is how I determine the path to a bin in app.asar.unpacked: __dirname.replace('app.asar', 'app.asar.unpacked') + '/gifsicle'

@kevinsawicki

This comment has been minimized.

Copy link
Contributor

kevinsawicki commented Aug 17, 2016

Closing this out, the specified path to the flash plugin must in the app.asar.unpacked folder if are using the --asar option to packager. You can use the --asar.unpack options of packager to make that happen.

Refs electron/electron#1802

@malept

This comment has been minimized.

Copy link
Member

malept commented Aug 17, 2016

@kevinsawicki by which you mean --asar.unpack 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.