Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add ability to package OSX build as an App Store compliant app #163
Since the electron team made a big step forward and provided an mac appstore compliant version of electron, it would be really nice to use electron packager to bundle these apps.
I uploaded an app a couple of days before and based on what apple complained, the following things need to be changed.
I hacked a version that includes step 1 and 2. I could make a proper PR with test if wanted. The last step ist most likely the hardest issue, since it includes also adding all of the entitlements. You can find a script to sign the app with entitlements in the electron docs.
@kfranqueiro yea the first two items wouldn't be that much of a code change probably (though it would be nice some day to move all the plist stuff out of here). I was mostly talking about the entitlements/capabilities stuff which would be a lot of new code
Having the full control over what to put into the plist would solve step 1 anyway. And as electron-packager already changes the Electron Helper, it would be just straightforward to do it also for the rest.
I agree that especially the signing could be done in a different place. This is what i am doing right now.
changed the title from
Add ability to package mas app
Add ability to package OSX build as an App Store compliant app
Oct 18, 2015
I added a new mas platform on mawie81@c0af821 Tests are looking good as well (the ones that require wine failed for me because I dont have it installed currently).
Tried to handle all the plist stuff in a not so repetitive manner. Could create a PR if wanted.
Maybe step 3 could be solved by adding two new entitlements parameters to pass in the child.plist and parent.plist?