New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install fails because module 'is-property' isn't installed #40

Closed
frankhale opened this Issue Jun 12, 2015 · 21 comments

Comments

Projects
None yet
8 participants
@frankhale
Copy link

frankhale commented Jun 12, 2015

I think electron-prebuilt needs to include a dependency on module is-property because on my system it's bombing out and can't install because that module is missing. After I manually installed is-property electron-prebuilt installed correctly.

C:\Users\Frank\Desktop>npm install -g electron-prebuilt
C:\Users\Frank\AppData\Roaming\npm\electron -> C:\Users\Frank\AppData\Roaming\np
m\node_modules\electron-prebuilt\cli.js

> electron-prebuilt@0.27.3 postinstall C:\Users\Frank\AppData\Roaming\npm\node_m
odules\electron-prebuilt
> node install.js

module.js:334
    throw err;
          ^
Error: Cannot find module 'is-property'
    at Function.Module._resolveFilename (module.js:332:15)
    at Function.Module._load (module.js:282:25)
    at Module.require (module.js:361:17)
    at require (module.js:380:17)
    at Object.<anonymous> (C:\Users\Frank\AppData\Roaming\npm\node_modules\elect
ron-prebuilt\node_modules\electron-download\node_modules\nugget\node_modules\req
uest\node_modules\har-validator\node_modules\is-my-json-valid\node_modules\gener
ate-object-property\index.js:1:80)
    at Module._compile (module.js:426:26)
    at Object.Module._extensions..js (module.js:444:10)
    at Module.load (module.js:351:32)
    at Function.Module._load (module.js:306:12)
    at Module.require (module.js:361:17)
    at require (module.js:380:17)
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\\Program Files\\iojs\\node.exe" "C:\\Program Files\\iojs\\node
_modules\\npm\\bin\\npm-cli.js" "install" "-g" "electron-prebuilt"
npm ERR! node v2.2.1
npm ERR! npm  v2.11.0
npm ERR! code ELIFECYCLE

npm ERR! electron-prebuilt@0.27.3 postinstall: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the electron-prebuilt@0.27.3 postinstall script 'node install
.js'.
npm ERR! This is most likely a problem with the electron-prebuilt package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node install.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls electron-prebuilt
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Frank\Desktop\npm-debug.log
@frankhale

This comment has been minimized.

Copy link

frankhale commented Jun 12, 2015

This happened to me on two different Windows machines.

@maxogden

This comment has been minimized.

Copy link
Contributor

maxogden commented Jun 18, 2015

@frankhale thanks for the bug report. This is super weird behavior. @mafintosh have you ever seen this before?

@justinmchase

This comment has been minimized.

Copy link

justinmchase commented Jun 19, 2015

👍 This is happening to me too.

@justinmchase

This comment has been minimized.

Copy link

justinmchase commented Jun 19, 2015

As a work-around you can just install is-property globlally and then it will work:

npm install is-property -g

@gcoupelant

This comment has been minimized.

Copy link

gcoupelant commented Jun 22, 2015

+1 @justinmchase tip worked

@mafintosh

This comment has been minimized.

Copy link
Collaborator

mafintosh commented Jun 22, 2015

what version of npm are you using? this should never happen as is-property is a dependency of generate-object-property (which is throwing this error)

@frankhale

This comment has been minimized.

Copy link

frankhale commented Jun 22, 2015

Not sure exact version of npm but I was using iojs 2.2.1 at the time.

@frankhale

This comment has been minimized.

Copy link

frankhale commented Jun 22, 2015

Actually it's in the log message posted above:

npm ERR! node v2.2.1
npm ERR! npm  v2.11.0
@gcoupelant

This comment has been minimized.

Copy link

gcoupelant commented Jun 22, 2015

Same with me, io.js installed with chocolatey on Windows 10
node v2.2.1 and npm v2.11.0

@mafintosh

This comment has been minimized.

Copy link
Collaborator

mafintosh commented Jun 22, 2015

@frankhale @gcoupelant this seems to be an npm issue. is this reproducible on subsequent installs?

@frankhale

This comment has been minimized.

Copy link

frankhale commented Jun 22, 2015

I'll see if I can reproduce it using iojs 2.3.0 as soon as I have time today.

@dominhhai

This comment has been minimized.

Copy link

dominhhai commented Jun 23, 2015

Same with me in Win 7 - 64 bit, and iojs 2.2.1.

@v12

This comment has been minimized.

Copy link

v12 commented Jun 23, 2015

Experiencing same issue:

  • Platform: Win 8.1 x64
  • io.js: v2.3.0
  • npm: v2.11.1
@maxogden

This comment has been minimized.

Copy link
Contributor

maxogden commented Jun 23, 2015

I think this is a windows specific issue because we are using too many modules and windows paths have a hard limit on length. I'll look into a fix

@v12

This comment has been minimized.

Copy link

v12 commented Jun 23, 2015

@maxogden you're right, seems to be io.js bug, which was introduced in v2.2.0 (nodejs/node#1801) and fixed in v2.3.1 (nodejs/node@a4f4909).

If you use any version of io.js in-between 2.2.0 and 2.3.0 inclusive, it fails to load any module that has path length greater than 259 characters in those versions.

@frankhale

This comment has been minimized.

Copy link

frankhale commented Jun 23, 2015

Thanks @v12 for this information! I removed electron-prebuilt, removed is-property, installed iojs 2.3.1 and then reinstalled electron-prebuilt and it installed without issue.

@snowcxt

This comment has been minimized.

Copy link

snowcxt commented Sep 24, 2015

I'm using node v4.0.0. I still have this problem on my Windows.

@frankhale

This comment has been minimized.

Copy link

frankhale commented Sep 24, 2015

@snowcxt, try installing the is-property module and then install electron-prebuilt and see if that works.

@snowcxt

This comment has been minimized.

Copy link

snowcxt commented Sep 24, 2015

I tried that. Didn't work for me. BTW I only get this error when I use Request

@justinmchase

This comment has been minimized.

Copy link

justinmchase commented Sep 24, 2015

@snowcxt You tried to install it globally? Like this: #40 (comment)

@snowcxt

This comment has been minimized.

Copy link

snowcxt commented Sep 24, 2015

You mean npm install is-property -g? Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment