This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Don't use anonymous namespace in header file. #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hokein
force-pushed
the
no-anonymous-ns-in-header
branch
2 times, most recently
from
d97f21c
to
59df68d
Compare
Anonymous namespace should be forbidden in header files even for the
forward declarations:
* As declarations defined in anonymous namespace are internal linkage, each
translation unit which includes this header will get unique copy, which
wastes space.
* It is easy to violate C++ ODR rule.
Consider the following "foo.h":
```cpp
namespace { class Foo; }
class Bar {
public:
Foo* getFoo();
Foo* foo;
}
```
If the 'foo.h' is included in multiple `.cc` files, the compiler will
put `Foo` into a different anonymous namespace in each `.cc`, which
means there are different definitions of `Foo` in the program (a
violation of the ODR).
hokein
force-pushed
the
no-anonymous-ns-in-header
branch
from
59df68d
to
22341a7
Compare
deepak1556
reviewed
Apr 1, 2017
| @@ -203,7 +203,8 @@ void InspectableWebContentsViewViews::SetContentsResizingStrategy( | |||
|
|
|||
| void InspectableWebContentsViewViews::SetTitle(const base::string16& title) { | |||
| if (devtools_window_) { | |||
| GetDevToolsWindowDelegate()->SetWindowTitle(title); | |||
| static_cast<DevToolsWindowDelegate*>(devtools_window_delegate_) | |||
| ->SetWindowTitle(title); | |||
There was a problem hiding this comment.
What do you think about moving the ownership of title from DevToolsWindowDelegate to InspectableWebContentsViewViews to avoid the cast ?
hokein
force-pushed
the
no-anonymous-ns-in-header
branch
from
8c4d133
to
3a61f08
Compare
|
Thanks @hokein 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anonymous namespace should be forbidden in header files even for the forward declarations:
Consider the following header
foo.h:If the 'foo.h' is included in multiple
.ccfiles, the compiler will putFoointo a different anonymous namespace in each.cc, which means there are different definitions ofFooin the program (aviolation of the ODR).
\cc @deepak1556