Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

feat: broker must accept posted Test jobs #110

Closed
ckerr opened this issue Jul 7, 2021 · 0 comments · Fixed by #112
Closed

feat: broker must accept posted Test jobs #110

ckerr opened this issue Jul 7, 2021 · 0 comments · Fixed by #112
Assignees
Labels
module:broker ✨ enhancement New feature or request

Comments

@ckerr
Copy link
Member

ckerr commented Jul 7, 2021

Right now it only accepts bisect jobs from the probot client.

Also, data validation on those posted jobs is a mess.

@ckerr ckerr added ✨ enhancement New feature or request module:broker labels Jul 7, 2021
@ckerr ckerr self-assigned this Jul 7, 2021
ckerr added a commit that referenced this issue Jul 7, 2021
Replaces some very bad broker validation code (of mine) with some new ow
predicates. This includes a TestJob predicate so the broker now supports
both Test and Bisect tasks.

Fixes #110.
ckerr added a commit that referenced this issue Jul 10, 2021
* feat: support + validate new test tasks in broker

Replaces some very bad broker validation code (of mine) with some new ow
predicates. This includes a TestJob predicate so the broker now supports
both Test and Bisect tasks.

Fixes #110.

* test: add test calling getJob() for an unknown job

* refactor: use klona for deep copying

* refactor: have Task.constructor take a Job param
ckerr added a commit that referenced this issue Jul 13, 2021
* feat: have runner bisect w/obsolete, beta, nightly

When running `electron-fiddle bisect`, include arguments to pull in all
of the Electron releases so that the bisection range will be as small as
possible.

Fixes #66 as a side-effect.

* feat: support + validate new test tasks in broker

Replaces some very bad broker validation code (of mine) with some new ow
predicates. This includes a TestJob predicate so the broker now supports
both Test and Bisect tasks.

Fixes #110.

* test: add test calling getJob() for an unknown job

* refactor: add JobType enum

* feat: support running individual tests in Runner.

Fixes #104.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module:broker ✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant