New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the webview doc #85

Merged
merged 17 commits into from Mar 3, 2017

Conversation

Projects
None yet
1 participant
@zeke
Member

zeke commented Mar 2, 2017

This PR adds a new subclass of the Collection parser for collecting all the attributes of the <webview> tag: https://github.com/electron/electron/blob/master/docs/api/webview-tag.md#tag-attributes

It also removes some code that used to attach DOM ids to all the headings to make them searchable. That code existed to work around the fact that multiple APIs were defined in the same markdown file. Now there is One File Per API, so this special tagging stuff is no longer needed.

See also this companion PR that fixes some formatting issues in the docs: electron/electron#8816

cc @MarshallOfSound

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Mar 3, 2017

Member

Per an offline conversation with @MarshallOfSound, I'm going to update this PR to use a new Element type for webview, instead of Class.

Member

zeke commented Mar 3, 2017

Per an offline conversation with @MarshallOfSound, I'm going to update this PR to use a new Element type for webview, instead of Class.

@zeke zeke merged commit c0f6e05 into master Mar 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zeke zeke deleted the webview branch Mar 3, 2017

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Mar 3, 2017

Member
❯ np minor
 ✔ Prerequisite check
 ✔ Git
 ✔ Cleanup
 ✔ Installing dependencies
 ✔ Running tests
 ✔ Bumping version
 ✔ Publishing package
 ✔ Pushing tags

 electron-docs-linter 2.1.0 published 🎉
Member

zeke commented Mar 3, 2017

❯ np minor
 ✔ Prerequisite check
 ✔ Git
 ✔ Cleanup
 ✔ Installing dependencies
 ✔ Running tests
 ✔ Bumping version
 ✔ Publishing package
 ✔ Pushing tags

 electron-docs-linter 2.1.0 published 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment