Add support for the new `electron` package name #435
A rename of
This PR updates
I have a fix in place and the test suite is passing for me locally but CI is failing.
I changed that code to just
I will dig into the CI failures tomorrow.
Yup, see https://github.com/electron-userland/electron-packager/blob/master/CONTRIBUTING.md#filing-pull-requests (last bullet point)
I will try to review later tonight. (Though I just noticed that somehow test coverage decreased with this PR...hopefully it's because CI isn't done yet.)
Thanks for all the feedback, @malept. I pushed up some changes to the docs and DRY'd things a bit.
I feel like the
As for the CI, the tests definitely seem flaky. I keep seeing 5/6 passed builds, but the failing environment is not consistently the same. Let's see what happens on this go around.
Aug 4, 2016
4 of 5 checks passed
Can confirm this happens with both node
Error: must specify version at download (/Users/gregholguin/Desktop/testing123/node_modules/electron-download/index.js:16:27) at Array.<anonymous> (/Users/gregholguin/Desktop/testing123/node_modules/electron-packager/index.js:121:7) at each (/Users/gregholguin/Desktop/testing123/node_modules/run-series/index.js:17:24) at next (/Users/gregholguin/Desktop/testing123/node_modules/rimraf/rimraf.js:74:7) at FSReqWrap.CB [as oncomplete] (/Users/gregholguin/Desktop/testing123/node_modules/rimraf/rimraf.js:110:9)
UPDATE: Currently using