New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for `module.process.main` is failing on CI #1

Closed
zeke opened this Issue Nov 22, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@zeke
Member

zeke commented Nov 22, 2016

electron/electron#7857
https://travis-ci.org/electron/electron/jobs/176476635

/home/travis/build/electron/electron/node_modules/electron-definitelytyped/lib/master-interfaces.js:17
    if (module.process.main && module.process.renderer) {
                      ^
TypeError: Cannot read property 'main' of undefined
    at /home/travis/build/electron/electron/node_modules/electron-definitelytyped/lib/master-interfaces.js:17:23
    at Array.forEach (native)
    at module.exports.API.forEach (/home/travis/build/electron/electron/node_modules/electron-definitelytyped/lib/master-interfaces.js:13:7)
    at module.exports.API.sort.forEach.Object.keys.forEach (/home/travis/build/electron/electron/node_modules/electron-definitelytyped/index.js:21:3)
    at Object.<anonymous> (/home/travis/build/electron/electron/node_modules/electron-definitelytyped/cli.js:36:21)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
npm ERR! Linux 3.13.0-92-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v4.6.2/bin/node" "/home/travis/build/electron/electron/node_modules/.bin/npm" "run" "generate-dts"
@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Nov 22, 2016

Member

It looks like this check has been added: https://github.com/MarshallOfSound/electron-DefinitelyTyped/blob/f9334d30bb73a838e278995a6a4966a0289dd363/lib/master-interfaces.js#L17-L20

@MarshallOfSound do you want to cut a new release and bump the version in electron/electron#7857

Or I'd be happy to do so if you want to give me GitHub/npm access :)

Member

zeke commented Nov 22, 2016

It looks like this check has been added: https://github.com/MarshallOfSound/electron-DefinitelyTyped/blob/f9334d30bb73a838e278995a6a4966a0289dd363/lib/master-interfaces.js#L17-L20

@MarshallOfSound do you want to cut a new release and bump the version in electron/electron#7857

Or I'd be happy to do so if you want to give me GitHub/npm access :)

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Nov 22, 2016

Member

0.0.8 has been published with this fix and a locked linter version 👍 Also gave you github + npm access. Do you want to maybe even move this to the electron org?

Member

MarshallOfSound commented Nov 22, 2016

0.0.8 has been published with this fix and a locked linter version 👍 Also gave you github + npm access. Do you want to maybe even move this to the electron org?

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Nov 22, 2016

Member

🍰

Updated electron/electron#7857

Yeah let's move it to the electron org! Thanks for offering.

Member

zeke commented Nov 22, 2016

🍰

Updated electron/electron#7857

Yeah let's move it to the electron org! Thanks for offering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment