This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
Structures #510
Merged
Structures #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinsawicki can you peep this? |
|
bump @kevinsawicki |
| @@ -46,6 +46,8 @@ var fetchDocs = module.exports = function fetchDocs (_settings, callback) { | |||
|
|
|||
| // override tarball for testing out branches: | |||
| // tarballUrl = 'https://api.github.com/repos/electron/electron/tarball/master' | |||
| // tarballUrl = 'https://github.com/electron/electron/archive/ba49fbc8ba2fac0b72b1530f2ce46c1cd3110620.tar.gz' | |||
| // version = 'v1.4.1' | |||
There was a problem hiding this comment.
I was a little confused by this line, is it meant to be uncommented when you want to override it? It seems to get reassigned two lines below.
There was a problem hiding this comment.
Good point. Cleaned that up a bit. I just left it there because I always have a hard time finding/remembering the URL structures for fetching repo tarballs.
| <td>{{ site.data.processes[doc.title] | replace: 'Process', '' | replace: 'Processes', '' }}</td> | ||
| <td>{{ doc.excerpt }}</td> | ||
| </tr> | ||
| {% unless doc.source_url contains '/structures/' %} |
There was a problem hiding this comment.
Instead of indenting here, we could switch to using continue statements so the <tr> is more aligned with the outer <table> element:
{% assign docs = site.docs | sort: 'sort_title' %}
{% for doc in docs %}
{% if doc.category != 'API' %}{% continue %}{% endif %}
{% if doc.source_url contains '/structures/' %}{% continue %}{% endif %}
<tr>
<td><a href="{{ site.baseurl }}{{ doc.url }}">{{ doc.title }}</a></td>
<td>{{ site.data.processes[doc.title] | replace: 'Process', '' | replace: 'Processes', '' }}</td>
<td>{{ doc.excerpt }}</td>
</tr>
{% endfor %}Curious what you think.
There was a problem hiding this comment.
Like early returns. I dig it.
|
Looks good to me 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509
This updates the markdown parser to rewrite links to the new files in
/docs/api/structures.cc @MarshallOfSound