Skip to content

Commit

Permalink
build: fail a build if some hooks don't succeed
Browse files Browse the repository at this point in the history
  • Loading branch information
alexeykuzmin committed Jan 21, 2019
1 parent 3cb9aad commit 16f2203
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 4 deletions.
8 changes: 4 additions & 4 deletions DEPS
Expand Up @@ -107,7 +107,7 @@ hooks = [
'action': [
'python',
'-c',
'import os; os.chdir("src"); os.chdir("electron"); os.system("npm install")',
'import os, subprocess; os.chdir(os.path.join("src", "electron")); subprocess.check_call(["python", "src/electron/script/lib/npm.py", "install"]);',
],
},
{
Expand All @@ -117,7 +117,7 @@ hooks = [
'action': [
'python',
'-c',
'import os; os.chdir("src"); os.chdir("electron"); os.chdir("vendor"); os.chdir("boto"); os.system("python setup.py build");',
'import os, subprocess; os.chdir(os.path.join("src", "electron", "vendor", "boto")); subprocess.check_call(["python", "setup.py", "build"]);',
],
},
{
Expand All @@ -127,9 +127,9 @@ hooks = [
'action': [
'python',
'-c',
'import os; os.chdir("src"); os.chdir("electron"); os.chdir("vendor"); os.chdir("requests"); os.system("python setup.py build");',
'import os, subprocess; os.chdir(os.path.join("src", "electron", "vendor", "requests")); subprocess.check_call(["python", "setup.py", "build"]);',
],
}
},
]

recursedeps = [
Expand Down
18 changes: 18 additions & 0 deletions script/lib/npm.py
@@ -0,0 +1,18 @@
import subprocess
import sys


def npm(*npm_args):
call_args = [__get_executable_name()] + list(npm_args)
subprocess.check_call(call_args)


def __get_executable_name():
executable = 'npm'
if sys.platform == 'win32':
executable += '.cmd'
return executable


if __name__ == '__main__':
npm(*sys.argv[1:])

0 comments on commit 16f2203

Please sign in to comment.