Skip to content
Permalink
Browse files

test: ensure cleanup of net requests in tests (#20510)

ref #19389
  • Loading branch information...
nornagon authored and codebytere committed Oct 10, 2019
1 parent 8de925c commit 1dc1ef6091dfd3c087f04439ebdb9acc96cf5a89
Showing with 15 additions and 1 deletion.
  1. +15 −1 spec-main/api-net-spec.ts
@@ -1,9 +1,22 @@
import { expect } from 'chai'
import { net, session, ClientRequest } from 'electron'
import { net as originalNet, session, ClientRequest } from 'electron'
import * as http from 'http'
import * as url from 'url'
import { AddressInfo } from 'net'

const outstandingRequests: ClientRequest[] = []
const net: {request: (typeof originalNet)['request']} = {
request: (...args) => {
const r = originalNet.request(...args)
outstandingRequests.push(r)
return r
}
}
const abortOutstandingRequests = () => {
outstandingRequests.forEach(r => r.abort())
outstandingRequests.length = 0
}

const kOneKiloByte = 1024
const kOneMegaByte = kOneKiloByte * kOneKiloByte

@@ -57,6 +70,7 @@ respondOnce.toSingleURL = (fn: http.RequestListener) => {
}

describe('net module', () => {
afterEach(abortOutstandingRequests)
describe('HTTP basics', () => {
it('should be able to issue a basic GET request', (done) => {
respondOnce.toSingleURL((request, response) => {

0 comments on commit 1dc1ef6

Please sign in to comment.
You can’t perform that action at this time.