From 2fb14f53fe8c04397a49d32fb293547db27916ed Mon Sep 17 00:00:00 2001 From: Electron Bot Date: Tue, 21 Jul 2020 22:34:34 -0700 Subject: [PATCH] chore: bump chromium to 1a093e6a0cb5e72ba78990fe39824 (master) (#24575) --- BUILD.gn | 10 ++-- DEPS | 2 +- appveyor.yml | 1 + chromium_src/BUILD.gn | 7 +-- patches/chromium/.patches | 5 +- .../add_didinstallconditionalfeatures.patch | 22 ++++----- ...rustedauthclient_to_urlloaderfactory.patch | 18 ++++---- ..._secondary_label_via_simplemenumodel.patch | 18 ++++---- patches/chromium/blink_local_frame.patch | 6 +-- patches/chromium/blink_world_context.patch | 12 ++--- patches/chromium/build_gn.patch | 2 +- patches/chromium/can_create_window.patch | 36 +++++++-------- ...esources_not_chrome_for_spellchecker.patch | 4 +- .../chromium/content_browser_main_loop.patch | 2 +- patches/chromium/dcheck.patch | 4 +- patches/chromium/disable-redraw-lock.patch | 2 +- .../disable_color_correct_rendering.patch | 40 ++++++++-------- .../disable_compositor_recycling.patch | 2 +- patches/chromium/disable_hidden.patch | 6 +-- ...xpose_setuseragent_on_networkcontext.patch | 12 ++--- ..._scheduler_throttling_per_renderview.patch | 20 ++++---- ...screen_rendering_with_viz_compositor.patch | 4 +- .../fix_accessibility_label_id_mismatch.patch | 28 ----------- ...x_compare_page_size_to_ulong_not_int.patch | 20 -------- ...chdir_np_and_pthread_chdir_np_in_mas.patch | 2 +- ...g_weakptr_check_in_preconnectmanager.patch | 26 +++++++++++ ...ns_through_the_web_contents_delegate.patch | 4 +- ...ore_initializing_the_windows_proxies.patch | 2 +- patches/chromium/frame_host_manager.patch | 46 +++++++++---------- .../gin_enable_disable_v8_platform.patch | 2 +- ...gpu_notify_when_dxdiag_request_fails.patch | 4 +- patches/chromium/isolate_holder.patch | 2 +- .../mas-cgdisplayusesforcetogray.patch | 4 +- .../mas_disable_custom_window_frame.patch | 6 +-- .../mas_disable_remote_accessibility.patch | 4 +- patches/chromium/mas_no_private_api.patch | 6 +-- ...emote_certificate_verification_logic.patch | 24 +++++----- .../chromium/notification_provenance.patch | 4 +- patches/chromium/preconnect_feature.patch | 10 ++-- patches/chromium/printing.patch | 8 ++-- ...put_back_deleted_colors_for_autofill.patch | 10 ++-- ...r_changes_to_the_webcontentsobserver.patch | 14 +++--- ..._some_deps_that_do_not_work_on_arm64.patch | 12 ++--- .../render_widget_host_view_base.patch | 12 ++--- ...ove_contentrendererclient_shouldfork.patch | 6 +-- .../revert_swiftshader_roll_in_deps.patch | 40 ++++++++++++++++ .../chromium/skip_atk_toolchain_check.patch | 35 ++++++++++++++ .../ssl_security_state_tab_helper.patch | 27 +++++++---- .../support_mixed_sandbox_with_zygote.patch | 10 ++-- .../use_electron_resources_in_pdf_util.patch | 2 +- patches/chromium/web_contents.patch | 8 ++-- patches/chromium/webview_cross_drag.patch | 2 +- .../worker_context_will_destroy.patch | 8 ++-- patches/node/build_add_gn_build_files.patch | 7 +-- .../squirrel.mac/build_add_gn_config.patch | 10 ++-- patches/v8/add_realloc.patch | 4 +- patches/v8/build_gn.patch | 6 +-- .../chore_add_v8_apple_silicon_patches.patch | 4 +- patches/v8/dcheck.patch | 8 ++-- ...export_private_v8_symbols_on_windows.patch | 4 +- patches/v8/expose_mksnapshot.patch | 4 +- shell/browser/api/electron_api_menu_mac.mm | 4 +- shell/browser/api/electron_api_protocol.cc | 1 + shell/browser/api/electron_api_url_loader.cc | 1 + .../browser/api/electron_api_web_contents.cc | 4 +- shell/browser/browser_process_impl.cc | 1 + shell/browser/electron_browser_client.cc | 14 ------ shell/browser/electron_browser_main_parts.cc | 4 +- shell/browser/javascript_environment.cc | 6 +-- shell/browser/net/network_context_service.cc | 1 + shell/browser/net/web_request_api_interface.h | 1 + .../osr/osr_render_widget_host_view.cc | 4 +- .../browser/osr/osr_render_widget_host_view.h | 2 +- shell/browser/osr/osr_web_contents_view.cc | 2 +- shell/browser/plugins/plugin_utils.cc | 2 +- shell/browser/ui/tray_icon_cocoa.mm | 4 +- shell/common/api/electron_api_clipboard.cc | 25 ++++++---- .../common/gin_converters/blink_converter.cc | 2 +- shell/renderer/api/electron_api_web_frame.cc | 2 +- shell/renderer/content_settings_observer.cc | 1 + .../electron_render_frame_observer.cc | 2 +- 81 files changed, 407 insertions(+), 346 deletions(-) delete mode 100644 patches/chromium/fix_accessibility_label_id_mismatch.patch delete mode 100644 patches/chromium/fix_compare_page_size_to_ulong_not_int.patch create mode 100644 patches/chromium/fix_missing_weakptr_check_in_preconnectmanager.patch create mode 100644 patches/chromium/revert_swiftshader_roll_in_deps.patch create mode 100644 patches/chromium/skip_atk_toolchain_check.patch diff --git a/BUILD.gn b/BUILD.gn index 498419c58e348..1e270ed15e5b9 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -465,7 +465,7 @@ source_set("electron_lib") { deps += [ "//third_party/crashpad/crashpad/client" ] } - libs = [ + frameworks = [ "AVFoundation.framework", "Carbon.framework", "LocalAuthentication.framework", @@ -492,7 +492,7 @@ source_set("electron_lib") { "shell/common/crash_keys.h", ] } else { - libs += [ + frameworks += [ "Squirrel.framework", "ReactiveObjC.framework", "Mantle.framework", @@ -803,10 +803,10 @@ if (is_mac) { include_dirs = [ "." ] sources = filenames.framework_sources - libs = [] + frameworks = [] if (enable_osr) { - libs += [ "IOSurface.framework" ] + frameworks += [ "IOSurface.framework" ] } ldflags = [ @@ -915,7 +915,7 @@ if (is_mac) { output_name = electron_login_helper_name sources = filenames.login_helper_sources include_dirs = [ "." ] - libs = [ "AppKit.framework" ] + frameworks = [ "AppKit.framework" ] info_plist = "shell/app/resources/mac/loginhelper-Info.plist" extra_substitutions = [ "ELECTRON_BUNDLE_ID=$electron_mac_bundle_id.loginhelper" ] diff --git a/DEPS b/DEPS index 22f753ed7173d..c8db6efe1537f 100644 --- a/DEPS +++ b/DEPS @@ -14,7 +14,7 @@ gclient_gn_args = [ vars = { 'chromium_version': - '0ee01724797ab0f6deadb33bb3a0201cd2d21602', + '93a6ebbe22f1a093e6a0cb5e72ba78990fe39824', 'node_version': 'v12.18.2', 'nan_version': diff --git a/appveyor.yml b/appveyor.yml index 622450e836ff0..40b8ee196bc3c 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -61,6 +61,7 @@ build_script: - git config --global core.longpaths true - cd .. - mkdir src + - update_depot_tools.bat - ps: Move-Item $env:APPVEYOR_BUILD_FOLDER -Destination src\electron - ps: $env:CHROMIUM_BUILDTOOLS_PATH="$pwd\src\buildtools" - ps: $env:SCCACHE_PATH="$pwd\src\electron\external_binaries\sccache.exe" diff --git a/chromium_src/BUILD.gn b/chromium_src/BUILD.gn index 7d79f159685f2..b0d1dac617b00 100644 --- a/chromium_src/BUILD.gn +++ b/chromium_src/BUILD.gn @@ -64,6 +64,7 @@ static_library("chrome") { "//extensions/browser/app_window/size_constraints.cc", "//extensions/browser/app_window/size_constraints.h", ] + public_deps = [ "//chrome/common", "//chrome/common:version_header", @@ -73,10 +74,10 @@ static_library("chrome") { "//components/security_state/content", "//content/public/browser", ] + deps = [ "//chrome/browser:resource_prefetch_predictor_proto", "//chrome/services/speech:buildflags", - "//components/feature_engagement:buildflags", "//components/optimization_guide/proto:optimization_guide_proto", ] @@ -270,7 +271,7 @@ static_library("chrome") { source_set("plugins") { sources = [] deps = [] - libs = [] + frameworks = [] # browser side sources += [ @@ -304,7 +305,7 @@ source_set("plugins") { "//chrome/browser/renderer_host/pepper/monitor_finder_mac.h", "//chrome/browser/renderer_host/pepper/monitor_finder_mac.mm", ] - libs += [ "CoreGraphics.framework" ] + frameworks += [ "CoreGraphics.framework" ] } if (is_linux) { deps += [ "//components/services/font/public/cpp" ] diff --git a/patches/chromium/.patches b/patches/chromium/.patches index 7a2677ef09944..07f76ac2a9866 100644 --- a/patches/chromium/.patches +++ b/patches/chromium/.patches @@ -96,9 +96,10 @@ fix_swap_global_proxies_before_initializing_the_windows_proxies.patch feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch use_electron_resources_in_icon_reader_service.patch fix_patch_out_profile_refs_in_accessibility_ui.patch -fix_accessibility_label_id_mismatch.patch remove_some_deps_that_do_not_work_on_arm64.patch chore_add_allocator_patches_for_apple_silicon.patch chore_disable_failing_blink_font_dcheck_on_big_sur.patch fix_check_issecureeventinputenabled_in_constructor_before_setting.patch -fix_compare_page_size_to_ulong_not_int.patch +skip_atk_toolchain_check.patch +fix_missing_weakptr_check_in_preconnectmanager.patch +revert_swiftshader_roll_in_deps.patch diff --git a/patches/chromium/add_didinstallconditionalfeatures.patch b/patches/chromium/add_didinstallconditionalfeatures.patch index b60c61472e3cd..306919ea96287 100644 --- a/patches/chromium/add_didinstallconditionalfeatures.patch +++ b/patches/chromium/add_didinstallconditionalfeatures.patch @@ -23,10 +23,10 @@ index 3e059605c55d88d52cf2544d6aca3446efee5750..398229becb8fd00022b08cc6afed7d18 int32_t world_id) {} virtual void DidClearWindowObject() {} diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc -index 7f73a8952f90e5f0b525061be385bf38f0ecab28..f7d78b305bccfdb69c20261010824bae6758b5c3 100644 +index 05170b53a9491e2a77e8c6a0705e525001ea879b..899c4265fe65fc8dbd3d2e621b801635ae0efbb1 100644 --- a/content/renderer/render_frame_impl.cc +++ b/content/renderer/render_frame_impl.cc -@@ -4780,6 +4780,12 @@ void RenderFrameImpl::DidCreateScriptContext(v8::Local context, +@@ -4791,6 +4791,12 @@ void RenderFrameImpl::DidCreateScriptContext(v8::Local context, observer.DidCreateScriptContext(context, world_id); } @@ -40,7 +40,7 @@ index 7f73a8952f90e5f0b525061be385bf38f0ecab28..f7d78b305bccfdb69c20261010824bae int world_id) { for (auto& observer : observers_) diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h -index 2e84f944b3d0ef06d8001830f7f29f4382bccdff..2c70f9b320145e508e3c906c1b1840356031a462 100644 +index 3565ba8fe1b6f244c632410302f5bd7663555480..d7c08d6126e20d03500e4a5630af1d81252b7289 100644 --- a/content/renderer/render_frame_impl.h +++ b/content/renderer/render_frame_impl.h @@ -737,6 +737,8 @@ class CONTENT_EXPORT RenderFrameImpl @@ -53,7 +53,7 @@ index 2e84f944b3d0ef06d8001830f7f29f4382bccdff..2c70f9b320145e508e3c906c1b184035 int world_id) override; void DidChangeScrollOffset() override; diff --git a/third_party/blink/public/web/web_local_frame_client.h b/third_party/blink/public/web/web_local_frame_client.h -index c16d7836c5cb34019efd1a1ba1786bc4c4ebf7f3..08d614a10a484d65eca5c16740a1b123f80f5fe1 100644 +index 69a2f020dfc4bafab21158504072da888353b5d6..685c329ceccaf56ea42181dc9ed2592dd9bb1c4f 100644 --- a/third_party/blink/public/web/web_local_frame_client.h +++ b/third_party/blink/public/web/web_local_frame_client.h @@ -533,6 +533,9 @@ class BLINK_EXPORT WebLocalFrameClient { @@ -67,10 +67,10 @@ index c16d7836c5cb34019efd1a1ba1786bc4c4ebf7f3..08d614a10a484d65eca5c16740a1b123 virtual void WillReleaseScriptContext(v8::Local, int32_t world_id) {} diff --git a/third_party/blink/renderer/bindings/core/v8/local_window_proxy.cc b/third_party/blink/renderer/bindings/core/v8/local_window_proxy.cc -index 17ebe5efb8b0bfcf17eda69fe4373b61b213af72..b7296a900c04006812d5f01b05c46a223fb40dc2 100644 +index 4e2f84beb37dd435afcc9ee0ad8b519f0e2af78a..2341fe4301ccc95a73197c60bd9301f14b9ed2ae 100644 --- a/third_party/blink/renderer/bindings/core/v8/local_window_proxy.cc +++ b/third_party/blink/renderer/bindings/core/v8/local_window_proxy.cc -@@ -201,6 +201,7 @@ void LocalWindowProxy::Initialize() { +@@ -203,6 +203,7 @@ void LocalWindowProxy::Initialize() { } InstallConditionalFeatures(); @@ -79,7 +79,7 @@ index 17ebe5efb8b0bfcf17eda69fe4373b61b213af72..b7296a900c04006812d5f01b05c46a22 if (World().IsMainWorld()) { GetFrame()->Loader().DispatchDidClearWindowObjectInMainWorld(); diff --git a/third_party/blink/renderer/core/exported/local_frame_client_impl.cc b/third_party/blink/renderer/core/exported/local_frame_client_impl.cc -index 8dbf0452f08c68e4edbd85e2be4e0e6fdfb90547..286c716d1e754efcd0591368a98d4c99d183c89c 100644 +index 0b86910c15476dc6c3e622b69e1feca913a64ab3..9c9dc1b65aaa68026aadb2c9d688eabf8cf39cb9 100644 --- a/third_party/blink/renderer/core/exported/local_frame_client_impl.cc +++ b/third_party/blink/renderer/core/exported/local_frame_client_impl.cc @@ -391,6 +391,13 @@ void LocalFrameClientImpl::DidCreateScriptContext( @@ -97,7 +97,7 @@ index 8dbf0452f08c68e4edbd85e2be4e0e6fdfb90547..286c716d1e754efcd0591368a98d4c99 v8::Local context, int32_t world_id) { diff --git a/third_party/blink/renderer/core/exported/local_frame_client_impl.h b/third_party/blink/renderer/core/exported/local_frame_client_impl.h -index e29d690448142757e53ae778ece6c1d7a3b88cd2..03bd8dd3155f8b186f284a417fb215bc1d1c80c9 100644 +index c6f2faae9cf81ac25f6f519b4a8396809fe15628..f0e07659e523f0c65bda4179909cda99249d97b8 100644 --- a/third_party/blink/renderer/core/exported/local_frame_client_impl.h +++ b/third_party/blink/renderer/core/exported/local_frame_client_impl.h @@ -78,6 +78,8 @@ class CORE_EXPORT LocalFrameClientImpl final : public LocalFrameClient { @@ -110,7 +110,7 @@ index e29d690448142757e53ae778ece6c1d7a3b88cd2..03bd8dd3155f8b186f284a417fb215bc int32_t world_id) override; diff --git a/third_party/blink/renderer/core/frame/local_frame_client.h b/third_party/blink/renderer/core/frame/local_frame_client.h -index 582599e9f62ec3197b95deaa183449858169e8a2..febc1cce64dc3a9facbfc9a72be913fc04978950 100644 +index d6e732bb2e30a8f4083c2982ffdcffb24b055210..3b97b94b547713135218f675297f8f5b7b80bf64 100644 --- a/third_party/blink/renderer/core/frame/local_frame_client.h +++ b/third_party/blink/renderer/core/frame/local_frame_client.h @@ -286,6 +286,8 @@ class CORE_EXPORT LocalFrameClient : public FrameClient { @@ -123,10 +123,10 @@ index 582599e9f62ec3197b95deaa183449858169e8a2..febc1cce64dc3a9facbfc9a72be913fc int32_t world_id) = 0; virtual bool AllowScriptExtensions() = 0; diff --git a/third_party/blink/renderer/core/loader/empty_clients.h b/third_party/blink/renderer/core/loader/empty_clients.h -index f08d47d43de96e4541172fe620cf318e6ba3321f..5d5141bd74dd012ad2a84ddaf2b105b5582e3155 100644 +index 27b5af56ca300fe072ec1410ffe087896a9f0bf2..ac9f95c623bcdd793d1671f6ee7d5d87a7c4b52e 100644 --- a/third_party/blink/renderer/core/loader/empty_clients.h +++ b/third_party/blink/renderer/core/loader/empty_clients.h -@@ -333,6 +333,8 @@ class CORE_EXPORT EmptyLocalFrameClient : public LocalFrameClient { +@@ -331,6 +331,8 @@ class CORE_EXPORT EmptyLocalFrameClient : public LocalFrameClient { void DidCreateScriptContext(v8::Local, int32_t world_id) override {} diff --git a/patches/chromium/add_trustedauthclient_to_urlloaderfactory.patch b/patches/chromium/add_trustedauthclient_to_urlloaderfactory.patch index 986a41341a5b2..66dcde5955e3f 100644 --- a/patches/chromium/add_trustedauthclient_to_urlloaderfactory.patch +++ b/patches/chromium/add_trustedauthclient_to_urlloaderfactory.patch @@ -10,7 +10,7 @@ WebContents, and cancels the authentication if there's no WebContents available, which there isn't in the case of the 'net' module. diff --git a/services/network/public/mojom/network_context.mojom b/services/network/public/mojom/network_context.mojom -index ccac671f0e7e56c731cb9bd92bad788271419a7f..cfea0e5dbc28f1a4cdfea36372ce7f34f15c4de7 100644 +index 41f5c3db2171cbe015dcb8c6a4436b94c377fec8..621dcf406e899ed9561568a812b6eea042e8c427 100644 --- a/services/network/public/mojom/network_context.mojom +++ b/services/network/public/mojom/network_context.mojom @@ -214,6 +214,25 @@ struct CTPolicy { @@ -49,10 +49,10 @@ index ccac671f0e7e56c731cb9bd92bad788271419a7f..cfea0e5dbc28f1a4cdfea36372ce7f34 // the per-context allow patterns that is managed via NetworkContext // interface. This still respects the per-context block lists. diff --git a/services/network/url_loader.cc b/services/network/url_loader.cc -index 1fa9021a62385fd5c0dadbb8a4a046cd72039915..2b0e4841d009df2f7bb310efca74d2ff79d29b36 100644 +index a5c25e290ef79c33117e14c02c05c86ebd558527..b21b39385ba3a15546eb38a26cb14a317bb64227 100644 --- a/services/network/url_loader.cc +++ b/services/network/url_loader.cc -@@ -471,6 +471,7 @@ URLLoader::URLLoader( +@@ -472,6 +472,7 @@ URLLoader::URLLoader( base::WeakPtr keepalive_statistics_recorder, base::WeakPtr network_usage_accumulator, mojom::TrustedURLLoaderHeaderClient* url_loader_header_client, @@ -60,7 +60,7 @@ index 1fa9021a62385fd5c0dadbb8a4a046cd72039915..2b0e4841d009df2f7bb310efca74d2ff mojom::OriginPolicyManager* origin_policy_manager, std::unique_ptr trust_token_helper_factory, mojo::PendingRemote cookie_observer) -@@ -534,6 +535,11 @@ URLLoader::URLLoader( +@@ -535,6 +536,11 @@ URLLoader::URLLoader( header_client_.set_disconnect_handler( base::BindOnce(&URLLoader::OnMojoDisconnect, base::Unretained(this))); } @@ -72,7 +72,7 @@ index 1fa9021a62385fd5c0dadbb8a4a046cd72039915..2b0e4841d009df2f7bb310efca74d2ff if (want_raw_headers_) { options_ |= mojom::kURLLoadOptionSendSSLInfoWithResponse | mojom::kURLLoadOptionSendSSLInfoForCertificateError; -@@ -1061,7 +1067,7 @@ void URLLoader::OnAuthRequired(net::URLRequest* url_request, +@@ -1062,7 +1068,7 @@ void URLLoader::OnAuthRequired(net::URLRequest* url_request, // |this| may have been deleted. return; } @@ -81,7 +81,7 @@ index 1fa9021a62385fd5c0dadbb8a4a046cd72039915..2b0e4841d009df2f7bb310efca74d2ff OnAuthCredentials(base::nullopt); return; } -@@ -1077,11 +1083,20 @@ void URLLoader::OnAuthRequired(net::URLRequest* url_request, +@@ -1078,11 +1084,20 @@ void URLLoader::OnAuthRequired(net::URLRequest* url_request, if (url_request->response_headers()) head->headers = url_request->response_headers(); head->auth_challenge_info = auth_info; @@ -108,10 +108,10 @@ index 1fa9021a62385fd5c0dadbb8a4a046cd72039915..2b0e4841d009df2f7bb310efca74d2ff auth_challenge_responder_receiver_.set_disconnect_handler( base::BindOnce(&URLLoader::DeleteSelf, base::Unretained(this))); diff --git a/services/network/url_loader.h b/services/network/url_loader.h -index 1c8a9ce4ba5f41cb7a4d415337ff087894fee3df..1ea5d86177ff568a13e3d10767316ae496298d10 100644 +index 9f4d85ca7913c8de998e18560c6755cec51135d8..04748acc74ce55a335abb1865bb9bef9ae7a33c6 100644 --- a/services/network/url_loader.h +++ b/services/network/url_loader.h -@@ -115,6 +115,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) URLLoader +@@ -116,6 +116,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) URLLoader base::WeakPtr keepalive_statistics_recorder, base::WeakPtr network_usage_accumulator, mojom::TrustedURLLoaderHeaderClient* url_loader_header_client, @@ -119,7 +119,7 @@ index 1c8a9ce4ba5f41cb7a4d415337ff087894fee3df..1ea5d86177ff568a13e3d10767316ae4 mojom::OriginPolicyManager* origin_policy_manager, std::unique_ptr trust_token_helper_factory, -@@ -456,6 +457,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) URLLoader +@@ -457,6 +458,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) URLLoader base::Optional fetch_window_id_; mojo::Remote header_client_; diff --git a/patches/chromium/allow_setting_secondary_label_via_simplemenumodel.patch b/patches/chromium/allow_setting_secondary_label_via_simplemenumodel.patch index 13ee77b28663e..c6eed44fedf18 100644 --- a/patches/chromium/allow_setting_secondary_label_via_simplemenumodel.patch +++ b/patches/chromium/allow_setting_secondary_label_via_simplemenumodel.patch @@ -6,10 +6,10 @@ Subject: Allow setting secondary label via SimpleMenuModel Builds on https://chromium-review.googlesource.com/c/chromium/src/+/2208976 diff --git a/ui/base/models/simple_menu_model.cc b/ui/base/models/simple_menu_model.cc -index 1fc029cb37562dc32a961666c3af3b0c27b04e5a..e1c6fe2ea2c3c89e10ff4ae27d16baf053e8a3a0 100644 +index 0c37f6e2caead2f3004f1fbdd2abe7921ef4bea7..6f46775d96153d0c6a0795a1d6085f532daf985c 100644 --- a/ui/base/models/simple_menu_model.cc +++ b/ui/base/models/simple_menu_model.cc -@@ -49,6 +49,11 @@ base::string16 SimpleMenuModel::Delegate::GetLabelForCommandId( +@@ -53,6 +53,11 @@ base::string16 SimpleMenuModel::Delegate::GetLabelForCommandId( return base::string16(); } @@ -21,7 +21,7 @@ index 1fc029cb37562dc32a961666c3af3b0c27b04e5a..e1c6fe2ea2c3c89e10ff4ae27d16baf0 ImageModel SimpleMenuModel::Delegate::GetIconForCommandId( int command_id) const { return ImageModel(); -@@ -291,6 +296,11 @@ void SimpleMenuModel::SetLabel(int index, const base::string16& label) { +@@ -295,6 +300,11 @@ void SimpleMenuModel::SetLabel(int index, const base::string16& label) { MenuItemsChanged(); } @@ -33,7 +33,7 @@ index 1fc029cb37562dc32a961666c3af3b0c27b04e5a..e1c6fe2ea2c3c89e10ff4ae27d16baf0 void SimpleMenuModel::SetMinorText(int index, const base::string16& minor_text) { items_[ValidateItemIndex(index)].minor_text = minor_text; -@@ -368,6 +378,12 @@ base::string16 SimpleMenuModel::GetLabelAt(int index) const { +@@ -372,6 +382,12 @@ base::string16 SimpleMenuModel::GetLabelAt(int index) const { return items_[ValidateItemIndex(index)].label; } @@ -47,10 +47,10 @@ index 1fc029cb37562dc32a961666c3af3b0c27b04e5a..e1c6fe2ea2c3c89e10ff4ae27d16baf0 return items_[ValidateItemIndex(index)].minor_text; } diff --git a/ui/base/models/simple_menu_model.h b/ui/base/models/simple_menu_model.h -index 3067f9beba9e79e18d341aea052d82aad34039d0..ffd8d7c53378b490e54af430371dc8a44121f72b 100644 +index 5f1116ba19b8160a2fee008415b8841f056aad98..9c07e44c484a9a15b7d16d592311eb07d9b3734a 100644 --- a/ui/base/models/simple_menu_model.h +++ b/ui/base/models/simple_menu_model.h -@@ -44,6 +44,7 @@ class COMPONENT_EXPORT(UI_BASE) SimpleMenuModel : public MenuModel { +@@ -48,6 +48,7 @@ class COMPONENT_EXPORT(UI_BASE) SimpleMenuModel : public MenuModel { // Some command ids have labels and icons that change over time. virtual bool IsItemForCommandIdDynamic(int command_id) const; virtual base::string16 GetLabelForCommandId(int command_id) const; @@ -58,7 +58,7 @@ index 3067f9beba9e79e18d341aea052d82aad34039d0..ffd8d7c53378b490e54af430371dc8a4 // Gets the icon for the item with the specified id. virtual ImageModel GetIconForCommandId(int command_id) const; -@@ -147,6 +148,9 @@ class COMPONENT_EXPORT(UI_BASE) SimpleMenuModel : public MenuModel { +@@ -151,6 +152,9 @@ class COMPONENT_EXPORT(UI_BASE) SimpleMenuModel : public MenuModel { // Sets the label for the item at |index|. void SetLabel(int index, const base::string16& label); @@ -68,7 +68,7 @@ index 3067f9beba9e79e18d341aea052d82aad34039d0..ffd8d7c53378b490e54af430371dc8a4 // Sets the minor text for the item at |index|. void SetMinorText(int index, const base::string16& minor_text); -@@ -176,6 +180,7 @@ class COMPONENT_EXPORT(UI_BASE) SimpleMenuModel : public MenuModel { +@@ -180,6 +184,7 @@ class COMPONENT_EXPORT(UI_BASE) SimpleMenuModel : public MenuModel { ui::MenuSeparatorType GetSeparatorTypeAt(int index) const override; int GetCommandIdAt(int index) const override; base::string16 GetLabelAt(int index) const override; @@ -76,7 +76,7 @@ index 3067f9beba9e79e18d341aea052d82aad34039d0..ffd8d7c53378b490e54af430371dc8a4 base::string16 GetMinorTextAt(int index) const override; ImageModel GetMinorIconAt(int index) const override; bool IsItemDynamicAt(int index) const override; -@@ -211,6 +216,7 @@ class COMPONENT_EXPORT(UI_BASE) SimpleMenuModel : public MenuModel { +@@ -216,6 +221,7 @@ class COMPONENT_EXPORT(UI_BASE) SimpleMenuModel : public MenuModel { int command_id = 0; ItemType type = TYPE_COMMAND; base::string16 label; diff --git a/patches/chromium/blink_local_frame.patch b/patches/chromium/blink_local_frame.patch index fc3c227b77acb..dd8a6cb230ac2 100644 --- a/patches/chromium/blink_local_frame.patch +++ b/patches/chromium/blink_local_frame.patch @@ -14,10 +14,10 @@ when there is code doing that. This patch reverts the change to fix the crash in Electron. diff --git a/third_party/blink/renderer/core/frame/local_frame.cc b/third_party/blink/renderer/core/frame/local_frame.cc -index 6d91a9a494b81120c68d5539f08e6b57f37a6e02..093cc5c6c4ec4e8e9c8d97e75fef3bba1d0adbc1 100644 +index 25a7913d239dddbe623195323f0abc1c3fd8d752..b59873bdd37ebf5008a98946163c4a6f7b47884b 100644 --- a/third_party/blink/renderer/core/frame/local_frame.cc +++ b/third_party/blink/renderer/core/frame/local_frame.cc -@@ -551,10 +551,6 @@ void LocalFrame::DetachImpl(FrameDetachType type) { +@@ -550,10 +550,6 @@ void LocalFrame::DetachImpl(FrameDetachType type) { } CHECK(!view_ || !view_->IsAttached()); @@ -28,7 +28,7 @@ index 6d91a9a494b81120c68d5539f08e6b57f37a6e02..093cc5c6c4ec4e8e9c8d97e75fef3bba if (!Client()) return; -@@ -572,6 +568,10 @@ void LocalFrame::DetachImpl(FrameDetachType type) { +@@ -571,6 +567,10 @@ void LocalFrame::DetachImpl(FrameDetachType type) { // Notify ScriptController that the frame is closing, since its cleanup ends // up calling back to LocalFrameClient via WindowProxy. GetScriptController().ClearForClose(); diff --git a/patches/chromium/blink_world_context.patch b/patches/chromium/blink_world_context.patch index 1dc25ed3dc233..ea9c6be325e8c 100644 --- a/patches/chromium/blink_world_context.patch +++ b/patches/chromium/blink_world_context.patch @@ -7,10 +7,10 @@ This exposes a method for obtaining a reference to an isolated world, which is otherwise not available in the Blink API. diff --git a/third_party/blink/public/web/web_local_frame.h b/third_party/blink/public/web/web_local_frame.h -index 179221fbaf54f77373a3f1215d0d1ef287d0ef2b..daeafa747aa7bd0a9b673f8e0d64042eeb768a24 100644 +index c050c98f673cbf98964f14075d64748ec64ae4e7..7aea95528d3ac342b62b21382f1e53e8b0b00163 100644 --- a/third_party/blink/public/web/web_local_frame.h +++ b/third_party/blink/public/web/web_local_frame.h -@@ -355,6 +355,8 @@ class WebLocalFrame : public WebFrame { +@@ -348,6 +348,8 @@ class WebLocalFrame : public WebFrame { // Returns the world ID associated with |script_context|. virtual int32_t GetScriptContextWorldId( v8::Local script_context) const = 0; @@ -20,10 +20,10 @@ index 179221fbaf54f77373a3f1215d0d1ef287d0ef2b..daeafa747aa7bd0a9b673f8e0d64042e // Executes script in the context of the current page and returns the value // that the script evaluated to with callback. Script execution can be diff --git a/third_party/blink/renderer/core/frame/web_local_frame_impl.cc b/third_party/blink/renderer/core/frame/web_local_frame_impl.cc -index 3b9a026151e9ec9080e2e32365990e319cbc0556..c25aa04ddd24c73c86992e5148b39da8a3c6a8d7 100644 +index 0863431d7e9cde2cdd178d02677e0d721437dce5..79bce62ad35f086cdef758eac5f0b07cd8764209 100644 --- a/third_party/blink/renderer/core/frame/web_local_frame_impl.cc +++ b/third_party/blink/renderer/core/frame/web_local_frame_impl.cc -@@ -976,6 +976,13 @@ v8::Local WebLocalFrameImpl::GlobalProxy() const { +@@ -942,6 +942,13 @@ v8::Local WebLocalFrameImpl::GlobalProxy() const { return MainWorldScriptContext()->Global(); } @@ -38,10 +38,10 @@ index 3b9a026151e9ec9080e2e32365990e319cbc0556..c25aa04ddd24c73c86992e5148b39da8 return BindingSecurity::ShouldAllowAccessToFrame( CurrentDOMWindow(V8PerIsolateData::MainThreadIsolate()), diff --git a/third_party/blink/renderer/core/frame/web_local_frame_impl.h b/third_party/blink/renderer/core/frame/web_local_frame_impl.h -index 380964de98121d1372bacafdc68de08e16362fac..f2f759fe7797087bfb962080539a5bc78108484d 100644 +index a34fe16b62f51dbd6bae266504dbb3ff7eb0075f..d1150daf6d15f94bf83a0791a1f357dc434058a8 100644 --- a/third_party/blink/renderer/core/frame/web_local_frame_impl.h +++ b/third_party/blink/renderer/core/frame/web_local_frame_impl.h -@@ -166,6 +166,8 @@ class CORE_EXPORT WebLocalFrameImpl final +@@ -162,6 +162,8 @@ class CORE_EXPORT WebLocalFrameImpl final v8::Local MainWorldScriptContext() const override; int32_t GetScriptContextWorldId( v8::Local script_context) const override; diff --git a/patches/chromium/build_gn.patch b/patches/chromium/build_gn.patch index a53e1df449b08..36cd51072f4e0 100644 --- a/patches/chromium/build_gn.patch +++ b/patches/chromium/build_gn.patch @@ -14,7 +14,7 @@ tradeoff is that switching from MAS_BUILD to !MAS_BUILD or vice-versa will rebuild the entire tree. diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn -index 4cc6bfc45e647e656934b331793faef1ba0f4b14..b585c11f9b43bfd9f0d79dc5103fd844224e3586 100644 +index 284a7da8868dc7fc46768c9ea92cc1506d887c02..d66ed569ada79aa1ee728989cb1f9809e30a9155 100644 --- a/build/config/BUILDCONFIG.gn +++ b/build/config/BUILDCONFIG.gn @@ -123,6 +123,9 @@ if (current_os == "") { diff --git a/patches/chromium/can_create_window.patch b/patches/chromium/can_create_window.patch index 648e704c1b187..cea1a082aa8e2 100644 --- a/patches/chromium/can_create_window.patch +++ b/patches/chromium/can_create_window.patch @@ -9,10 +9,10 @@ potentially prevent a window from being created. TODO(loc): this patch is currently broken. diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc -index 4285350cd976bbc279c334a06ca5ff892a77393f..e37450e6e000c1700463971821591845bb4e7673 100644 +index 1483547eff57f9d3ee6e1874ac733f88a0c5093b..ccb2a4790d2a8b709011529ecd5fda1ba0e0ab22 100644 --- a/content/browser/frame_host/render_frame_host_impl.cc +++ b/content/browser/frame_host/render_frame_host_impl.cc -@@ -4679,6 +4679,7 @@ void RenderFrameHostImpl::CreateNewWindow( +@@ -4661,6 +4661,7 @@ void RenderFrameHostImpl::CreateNewWindow( last_committed_origin_, params->window_container_type, params->target_url, params->referrer.To(), params->frame_name, params->disposition, *params->features, @@ -21,10 +21,10 @@ index 4285350cd976bbc279c334a06ca5ff892a77393f..e37450e6e000c1700463971821591845 &no_javascript_access); diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc -index 3378de15224fbf9438c4b00bf342f3c4d63d6cb4..ffc75af10134776aa3ecad331ee9c6a228101e1a 100644 +index 3d2866b5748e74e8e99dc37352ba7534c816b29b..502893ba5219f64ed9c84f83c40b28188966d2a0 100644 --- a/content/browser/web_contents/web_contents_impl.cc +++ b/content/browser/web_contents/web_contents_impl.cc -@@ -3076,9 +3076,9 @@ RenderFrameHostDelegate* WebContentsImpl::CreateNewWindow( +@@ -3089,9 +3089,9 @@ RenderFrameHostDelegate* WebContentsImpl::CreateNewWindow( } if (delegate_) { @@ -38,10 +38,10 @@ index 3378de15224fbf9438c4b00bf342f3c4d63d6cb4..ffc75af10134776aa3ecad331ee9c6a2 for (auto& observer : observers_) { diff --git a/content/common/frame.mojom b/content/common/frame.mojom -index d9817d5667f2f28fca3bef442bccb829596c5cfc..5a5e289f64283813ab4370b72b2c0748141a8c40 100644 +index eff5643a896cfb16fce10306ec4a40dd89ccce71..e5c32de563f673aa4da61c93292a767fce3cfe57 100644 --- a/content/common/frame.mojom +++ b/content/common/frame.mojom -@@ -282,6 +282,10 @@ struct CreateNewWindowParams { +@@ -283,6 +283,10 @@ struct CreateNewWindowParams { // The window features to use for the new window. blink.mojom.WindowFeatures features; @@ -53,10 +53,10 @@ index d9817d5667f2f28fca3bef442bccb829596c5cfc..5a5e289f64283813ab4370b72b2c0748 // Operation result when the renderer asks the browser to create a new window. diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc -index 3fe77cc391f252fed4eb6df06f63bdbdbccca00e..0583f1ef5b851a6d39bac4d134d37a83e18e6f1a 100644 +index 762329d64784898db41d167cd8d4865bfff02830..2e1b2be0a96ef14e0d5d0cec0ce114ad97b4bf37 100644 --- a/content/public/browser/content_browser_client.cc +++ b/content/public/browser/content_browser_client.cc -@@ -532,6 +532,8 @@ bool ContentBrowserClient::CanCreateWindow( +@@ -531,6 +531,8 @@ bool ContentBrowserClient::CanCreateWindow( const std::string& frame_name, WindowOpenDisposition disposition, const blink::mojom::WindowFeatures& features, @@ -66,7 +66,7 @@ index 3fe77cc391f252fed4eb6df06f63bdbdbccca00e..0583f1ef5b851a6d39bac4d134d37a83 bool opener_suppressed, bool* no_javascript_access) { diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h -index a78117345fd36fc2bb2f97f9fcceb3aa91da4bf5..1ec9bc579a66369c9b78a8155a6f7cf5cd933f71 100644 +index f800969fb25cac51a7f6732e37d3d1cecf906557..f2b64eb90f80c94a9b8a7374b5733a609446346b 100644 --- a/content/public/browser/content_browser_client.h +++ b/content/public/browser/content_browser_client.h @@ -147,6 +147,7 @@ class NetworkService; @@ -109,7 +109,7 @@ index b30f242d2b61b10f68f016bc1e93419b520d3b06..bfbad0007797d9c3fff78fae121aa254 const OpenURLParams& params) { return nullptr; diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h -index 6e40ca10064fa4c4bd93df8f32dca63656716524..80f0c9562e78d558a870ad5a166dc417f49858b6 100644 +index cca58342b48bb6b139b177954eee400ccd4951d8..a43cdce2859c25d0749a9ad87e54f19f0ae7b023 100644 --- a/content/public/browser/web_contents_delegate.h +++ b/content/public/browser/web_contents_delegate.h @@ -17,6 +17,7 @@ @@ -135,7 +135,7 @@ index 6e40ca10064fa4c4bd93df8f32dca63656716524..80f0c9562e78d558a870ad5a166dc417 // typically happens when popups are created. virtual void WebContentsCreated(WebContents* source_contents, diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc -index c6a990f873066fec1ac7ce5e088ecd02d2142e71..272b613f658ef4bfa3869cbd17d342ceef665142 100644 +index 6c2ad75a5fd7d7f21aacd0430029ff9716a87e3c..d9792ba47cf8621549676564ef4c162b0714d45d 100644 --- a/content/renderer/render_view_impl.cc +++ b/content/renderer/render_view_impl.cc @@ -67,6 +67,7 @@ @@ -146,7 +146,7 @@ index c6a990f873066fec1ac7ce5e088ecd02d2142e71..272b613f658ef4bfa3869cbd17d342ce #include "content/renderer/media/audio/audio_device_factory.h" #include "content/renderer/render_frame_impl.h" #include "content/renderer/render_frame_proxy.h" -@@ -1235,6 +1236,10 @@ WebView* RenderViewImpl::CreateView( +@@ -1229,6 +1230,10 @@ WebView* RenderViewImpl::CreateView( } params->features = ConvertWebWindowFeaturesToMojoWindowFeatures(features); @@ -158,10 +158,10 @@ index c6a990f873066fec1ac7ce5e088ecd02d2142e71..272b613f658ef4bfa3869cbd17d342ce // moved on send. bool is_background_tab = diff --git a/content/shell/browser/web_test/web_test_content_browser_client.cc b/content/shell/browser/web_test/web_test_content_browser_client.cc -index 4d4a7ab2235ad0b35cc58959a6a501003043feb4..4c333b8a356e5536703dcf067cab01e6770ef70f 100644 +index 955bec3a920365a6c0d682b9ac4935cd8d242f5f..16956bed44b7e211b2b464bd136c950609129980 100644 --- a/content/shell/browser/web_test/web_test_content_browser_client.cc +++ b/content/shell/browser/web_test/web_test_content_browser_client.cc -@@ -386,6 +386,8 @@ bool WebTestContentBrowserClient::CanCreateWindow( +@@ -365,6 +365,8 @@ bool WebTestContentBrowserClient::CanCreateWindow( const std::string& frame_name, WindowOpenDisposition disposition, const blink::mojom::WindowFeatures& features, @@ -171,10 +171,10 @@ index 4d4a7ab2235ad0b35cc58959a6a501003043feb4..4c333b8a356e5536703dcf067cab01e6 bool opener_suppressed, bool* no_javascript_access) { diff --git a/content/shell/browser/web_test/web_test_content_browser_client.h b/content/shell/browser/web_test/web_test_content_browser_client.h -index ffa293ef83232521a7751a431116a5efbc6af46a..4000a08bd7ddcc401cf64d8bf3874dd0e6460954 100644 +index 150d1a8808d326d4ca9d445fa92ec08c95e02b62..5c837fcbe7ee66d6f500e4453fe56ca7b32394cf 100644 --- a/content/shell/browser/web_test/web_test_content_browser_client.h +++ b/content/shell/browser/web_test/web_test_content_browser_client.h -@@ -78,6 +78,8 @@ class WebTestContentBrowserClient : public ShellContentBrowserClient { +@@ -76,6 +76,8 @@ class WebTestContentBrowserClient : public ShellContentBrowserClient { const std::string& frame_name, WindowOpenDisposition disposition, const blink::mojom::WindowFeatures& features, @@ -206,10 +206,10 @@ index 4f735ad0d97eaac9a57dad137e479f8a7ec33a36..0a3c5821962c85609b64b3625fa6b8d6 } // namespace blink diff --git a/third_party/blink/renderer/core/frame/local_dom_window.cc b/third_party/blink/renderer/core/frame/local_dom_window.cc -index 3753f3f3a266c83f79d01eeb696cc0e3152815fe..a356dd2db092cdcbce7e53e12412562b6553040b 100644 +index d0e5c20a2a1e5807a645488cc4832e02b3f2a5ad..a8a7cef09e81a19906558a0243efa9d3a8498f3c 100644 --- a/third_party/blink/renderer/core/frame/local_dom_window.cc +++ b/third_party/blink/renderer/core/frame/local_dom_window.cc -@@ -1962,6 +1962,7 @@ DOMWindow* LocalDOMWindow::open(v8::Isolate* isolate, +@@ -1976,6 +1976,7 @@ DOMWindow* LocalDOMWindow::open(v8::Isolate* isolate, } WebWindowFeatures window_features = GetWindowFeaturesFromString(features); diff --git a/patches/chromium/chore_use_electron_resources_not_chrome_for_spellchecker.patch b/patches/chromium/chore_use_electron_resources_not_chrome_for_spellchecker.patch index 1778b0a72feeb..b2985e24f7ca1 100644 --- a/patches/chromium/chore_use_electron_resources_not_chrome_for_spellchecker.patch +++ b/patches/chromium/chore_use_electron_resources_not_chrome_for_spellchecker.patch @@ -7,10 +7,10 @@ spellchecker uses a few IDS_ resources. We need to load these from Electrons grit header instead of Chromes diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn -index 0dc4dd31216fa8f1c1bbe993796043cc261cf3be..1d8072fb11da85c27c68b8c526e0d7c4c6eef6cc 100644 +index 1a43043910b445d2195e173f26e9b0b39abc88ff..fab18a88d821edea23e5bc9db771ad4f233749b2 100644 --- a/chrome/browser/BUILD.gn +++ b/chrome/browser/BUILD.gn -@@ -5552,6 +5552,7 @@ static_library("browser") { +@@ -5528,6 +5528,7 @@ static_library("browser") { deps += [ "//components/spellcheck/browser", "//components/spellcheck/common", diff --git a/patches/chromium/content_browser_main_loop.patch b/patches/chromium/content_browser_main_loop.patch index 8c0a6a5947740..8da94af22002f 100644 --- a/patches/chromium/content_browser_main_loop.patch +++ b/patches/chromium/content_browser_main_loop.patch @@ -8,7 +8,7 @@ run before shutdown. This is required to cleanup WebContents asynchronously in atom::CommonWebContentsDelegate::ResetManageWebContents. diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc -index a4bc105bfa088591cbd4bcf6e5db53d6f385021d..95dffe6663e276c206137705e450e8d28f443295 100644 +index 50536c86ff6be648bbbfd01551a5c140ffc75b67..1a1c8102df1ea1d210146672167ae4c3e12f0f1d 100644 --- a/content/browser/browser_main_loop.cc +++ b/content/browser/browser_main_loop.cc @@ -1436,7 +1436,7 @@ void BrowserMainLoop::MainMessageLoopRun() { diff --git a/patches/chromium/dcheck.patch b/patches/chromium/dcheck.patch index 26a52013aac56..475271413396d 100644 --- a/patches/chromium/dcheck.patch +++ b/patches/chromium/dcheck.patch @@ -46,10 +46,10 @@ index 954d5401b71bb090c1c533783398298f28eeefbd..dd9051afe099cb1ef3aebb825cf05c34 // navigation. Now we know that the renderer has updated its state accordingly // and it is safe to also clear the browser side history. diff --git a/ui/base/clipboard/clipboard_win.cc b/ui/base/clipboard/clipboard_win.cc -index 421f22eaaf6dbb90c8e3a4bb78d9d017bac8db94..959666ba60c97e0c2f082867c8ebd77de45d8788 100644 +index b422119ff36713399358b27aff8b18423f79d954..5c223f360ca641a3e29f23e6d409d7f97414a985 100644 --- a/ui/base/clipboard/clipboard_win.cc +++ b/ui/base/clipboard/clipboard_win.cc -@@ -782,10 +782,10 @@ SkBitmap ClipboardWin::ReadImageInternal(ClipboardBuffer buffer) const { +@@ -831,10 +831,10 @@ SkBitmap ClipboardWin::ReadImageInternal(ClipboardBuffer buffer) const { void ClipboardWin::WriteToClipboard(ClipboardFormatType format, HANDLE handle) { UINT cf_format = format.ToFormatEtc().cfFormat; diff --git a/patches/chromium/disable-redraw-lock.patch b/patches/chromium/disable-redraw-lock.patch index 0a65183203cfb..ec58c650256f4 100644 --- a/patches/chromium/disable-redraw-lock.patch +++ b/patches/chromium/disable-redraw-lock.patch @@ -15,7 +15,7 @@ the redraw locking mechanism, which fixes these issues. The electron issue can be found at https://github.com/electron/electron/issues/1821 diff --git a/ui/views/win/hwnd_message_handler.cc b/ui/views/win/hwnd_message_handler.cc -index db4fe784c7e119111917757b2d1de4d7cc1e5f2b..f6e9f97e47b44fa47e8e6c237be371754a5204bd 100644 +index 4cfdfcc93b4da0497271fd31e01db8485b2ec7b2..e7be846616e58631ed2a89530d02930d64336b70 100644 --- a/ui/views/win/hwnd_message_handler.cc +++ b/ui/views/win/hwnd_message_handler.cc @@ -306,6 +306,10 @@ constexpr int kSynthesizedMouseMessagesTimeDifference = 500; diff --git a/patches/chromium/disable_color_correct_rendering.patch b/patches/chromium/disable_color_correct_rendering.patch index 165aa1fe63306..178a83bea749d 100644 --- a/patches/chromium/disable_color_correct_rendering.patch +++ b/patches/chromium/disable_color_correct_rendering.patch @@ -20,7 +20,7 @@ to deal with color spaces. That is being tracked at https://crbug.com/634542 and https://crbug.com/711107. diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc -index b2c0baa4659ffca5ef49723fe908d8f1e4919239..fbe00464174000e3d852f38141e2951842830627 100644 +index c389d38fbf98374a2c7677a95624eb87c1466b3f..e90709822d6d0462931efc979c00586749c01a3c 100644 --- a/cc/trees/layer_tree_host_impl.cc +++ b/cc/trees/layer_tree_host_impl.cc @@ -1857,6 +1857,10 @@ void LayerTreeHostImpl::SetIsLikelyToRequireADraw( @@ -33,7 +33,7 @@ index b2c0baa4659ffca5ef49723fe908d8f1e4919239..fbe00464174000e3d852f38141e29518 + constexpr gfx::ColorSpace srgb = gfx::ColorSpace::CreateSRGB(); - if (settings_.prefer_raster_in_srgb && + // If we are likely to software composite the resource, we use sRGB because diff --git a/cc/trees/layer_tree_settings.h b/cc/trees/layer_tree_settings.h index eaff59cabf659c0d3ffe46c394c51b6d30c05806..899be4f3d9cdb82e03d34ee940f26af89235dd31 100644 --- a/cc/trees/layer_tree_settings.h @@ -81,7 +81,7 @@ index 02a2c735ff694c4890b5fb6a148724b3650c7346..817a7e1a6a5c244d744c56baa1062946 !command_line->HasSwitch(switches::kUIDisablePartialSwap); #if defined(OS_MACOSX) diff --git a/components/viz/service/display/gl_renderer.cc b/components/viz/service/display/gl_renderer.cc -index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f064257063bc2 100644 +index a87c1992018071ecce8e4a640abebfeaf4e742eb..80ac0ab3b0edb12ca1846b8960143659775dbfa1 100644 --- a/components/viz/service/display/gl_renderer.cc +++ b/components/viz/service/display/gl_renderer.cc @@ -89,6 +89,9 @@ @@ -94,7 +94,7 @@ index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f0642 namespace viz { namespace { -@@ -589,8 +592,9 @@ void GLRenderer::DoDrawQuad(const DrawQuad* quad, +@@ -592,8 +595,9 @@ void GLRenderer::DoDrawQuad(const DrawQuad* quad, void GLRenderer::DrawDebugBorderQuad(const DebugBorderDrawQuad* quad) { SetBlendEnabled(quad->ShouldDrawWithBlending()); @@ -106,7 +106,7 @@ index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f0642 // Use the full quad_rect for debug quads to not move the edges based on // partial swaps. -@@ -1560,7 +1564,8 @@ void GLRenderer::ChooseRPDQProgram(DrawRenderPassDrawQuadParams* params, +@@ -1564,7 +1568,8 @@ void GLRenderer::ChooseRPDQProgram(DrawRenderPassDrawQuadParams* params, params->use_color_matrix, tint_gl_composited_content_, params->apply_shader_based_rounded_corner && ShouldApplyRoundedCorner(params->quad)), @@ -116,7 +116,7 @@ index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f0642 } void GLRenderer::UpdateRPDQUniforms(DrawRenderPassDrawQuadParams* params) { -@@ -2031,7 +2036,8 @@ void GLRenderer::DrawSolidColorQuad(const SolidColorDrawQuad* quad, +@@ -2035,7 +2040,8 @@ void GLRenderer::DrawSolidColorQuad(const SolidColorDrawQuad* quad, SetUseProgram(ProgramKey::SolidColor(use_aa ? USE_AA : NO_AA, tint_gl_composited_content_, ShouldApplyRoundedCorner(quad)), @@ -126,7 +126,7 @@ index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f0642 SetShaderColor(color, opacity); if (current_program_->rounded_corner_rect_location() != -1) { SetShaderRoundedCorner( -@@ -2186,7 +2192,8 @@ void GLRenderer::DrawContentQuadAA(const ContentDrawQuadBase* quad, +@@ -2190,7 +2196,8 @@ void GLRenderer::DrawContentQuadAA(const ContentDrawQuadBase* quad, : NON_PREMULTIPLIED_ALPHA, false, false, tint_gl_composited_content_, ShouldApplyRoundedCorner(quad)), @@ -136,7 +136,7 @@ index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f0642 if (current_program_->tint_color_matrix_location() != -1) { auto matrix = cc::DebugColors::TintCompositedContentColorTransformMatrix(); -@@ -2282,7 +2289,8 @@ void GLRenderer::DrawContentQuadNoAA(const ContentDrawQuadBase* quad, +@@ -2286,7 +2293,8 @@ void GLRenderer::DrawContentQuadNoAA(const ContentDrawQuadBase* quad, !quad->ShouldDrawWithBlending(), has_tex_clamp_rect, tint_gl_composited_content_, ShouldApplyRoundedCorner(quad)), @@ -146,7 +146,7 @@ index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f0642 if (current_program_->tint_color_matrix_location() != -1) { auto matrix = cc::DebugColors::TintCompositedContentColorTransformMatrix(); -@@ -2384,7 +2392,8 @@ void GLRenderer::DrawYUVVideoQuad(const YUVVideoDrawQuad* quad, +@@ -2388,7 +2396,8 @@ void GLRenderer::DrawYUVVideoQuad(const YUVVideoDrawQuad* quad, // The source color space should never be RGB. DCHECK_NE(src_color_space, src_color_space.GetAsFullRangeRGB()); @@ -156,7 +156,7 @@ index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f0642 #if defined(OS_WIN) // Force sRGB output on Windows for overlay candidate video quads to match -@@ -2548,7 +2557,8 @@ void GLRenderer::DrawStreamVideoQuad(const StreamVideoDrawQuad* quad, +@@ -2552,7 +2561,8 @@ void GLRenderer::DrawStreamVideoQuad(const StreamVideoDrawQuad* quad, SetUseProgram(ProgramKey::VideoStream(tex_coord_precision, ShouldApplyRoundedCorner(quad)), @@ -166,7 +166,7 @@ index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f0642 DCHECK_EQ(GL_TEXTURE0, GetActiveTextureUnit(gl_)); gl_->BindTexture(GL_TEXTURE_EXTERNAL_OES, lock.texture_id()); -@@ -2613,8 +2623,8 @@ void GLRenderer::FlushTextureQuadCache(BoundGeometry flush_binding) { +@@ -2617,8 +2627,8 @@ void GLRenderer::FlushTextureQuadCache(BoundGeometry flush_binding) { draw_cache_.nearest_neighbor ? GL_NEAREST : GL_LINEAR); // Bind the program to the GL state. @@ -177,7 +177,7 @@ index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f0642 if (current_program_->rounded_corner_rect_location() != -1) { SetShaderRoundedCorner( -@@ -3359,7 +3369,9 @@ void GLRenderer::PrepareGeometry(BoundGeometry binding) { +@@ -3363,7 +3373,9 @@ void GLRenderer::PrepareGeometry(BoundGeometry binding) { void GLRenderer::SetUseProgram(const ProgramKey& program_key_no_color, const gfx::ColorSpace& src_color_space, const gfx::ColorSpace& dst_color_space) { @@ -188,7 +188,7 @@ index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f0642 // If the input color space is PQ, and it did not specify a white level, // override it with the frame's white level. -@@ -3741,9 +3753,9 @@ void GLRenderer::CopyRenderPassDrawQuadToOverlayResource( +@@ -3745,9 +3757,9 @@ void GLRenderer::CopyRenderPassDrawQuadToOverlayResource( cc::MathUtil::CheckedRoundUp(iosurface_height, iosurface_multiple); } @@ -201,7 +201,7 @@ index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f0642 *new_bounds = gfx::RectF(updated_dst_rect.origin(), gfx::SizeF((*overlay_texture)->texture.size())); -@@ -3962,8 +3974,8 @@ void GLRenderer::FlushOverdrawFeedback(const gfx::Rect& output_rect) { +@@ -3966,8 +3978,8 @@ void GLRenderer::FlushOverdrawFeedback(const gfx::Rect& output_rect) { PrepareGeometry(SHARED_BINDING); @@ -212,8 +212,8 @@ index 296f9b9c33b8b32dea6eaaa76a254b0da99fcf52..7b9018cb8cc76f0e6c187059d29f0642 gfx::Transform render_matrix; render_matrix.Translate(0.5 * output_rect.width() + output_rect.x(), -@@ -4082,3 +4094,5 @@ gfx::Size GLRenderer::GetRenderPassBackingPixelSize( - } +@@ -4089,3 +4101,5 @@ GLRenderer::OverlayTexture::OverlayTexture() = default; + GLRenderer::OverlayTexture::~OverlayTexture() = default; } // namespace viz + @@ -231,10 +231,10 @@ index b8032917cce5224403304c5f41674533e3d59528..2e871204e8dc9bf13315ba9a1448ab7c sandbox::policy::switches::kGpuSandboxAllowSysVShm, sandbox::policy::switches::kGpuSandboxFailuresFatal, diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc -index 0cd572d4793ebe72ce576000ffbc302aa703b58c..2f6f7cd0bdab9136dd166a191c01f4e83f15de65 100644 +index f3b77a295f334ffa696f1085a4ca5c0c86479987..872f9d0ac32970950c9a552431c7613e87f1ad94 100644 --- a/content/browser/renderer_host/render_process_host_impl.cc +++ b/content/browser/renderer_host/render_process_host_impl.cc -@@ -227,6 +227,7 @@ +@@ -225,6 +225,7 @@ #include "ui/accessibility/accessibility_switches.h" #include "ui/base/ui_base_switches.h" #include "ui/display/display_switches.h" @@ -242,7 +242,7 @@ index 0cd572d4793ebe72ce576000ffbc302aa703b58c..2f6f7cd0bdab9136dd166a191c01f4e8 #include "ui/gl/gl_switches.h" #include "ui/native_theme/native_theme_features.h" #include "url/origin.h" -@@ -3279,6 +3280,7 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer( +@@ -3271,6 +3272,7 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer( // Propagate the following switches to the renderer command line (along // with any associated values) if present in the browser command line. static const char* const kSwitchNames[] = { @@ -295,7 +295,7 @@ index 3dc0fb19b33daf14cbf8550cbb58e3e146830f26..da34be87f36c6e50286d0ef24cade531 } diff --git a/third_party/blink/renderer/platform/widget/compositing/layer_tree_settings.cc b/third_party/blink/renderer/platform/widget/compositing/layer_tree_settings.cc -index 309cd8b300ba9eb3c85a324475aba35b9eb28068..8c53d6ebdeae529854982075bb3ecec47169d606 100644 +index d8a737f5008f3b60f4ac74592cb23f8b04c4577a..178b84bccb6ad131391dbb6c856df2e766b0d221 100644 --- a/third_party/blink/renderer/platform/widget/compositing/layer_tree_settings.cc +++ b/third_party/blink/renderer/platform/widget/compositing/layer_tree_settings.cc @@ -23,6 +23,7 @@ diff --git a/patches/chromium/disable_compositor_recycling.patch b/patches/chromium/disable_compositor_recycling.patch index f0f8c2b20b5da..5f8393da37fe2 100644 --- a/patches/chromium/disable_compositor_recycling.patch +++ b/patches/chromium/disable_compositor_recycling.patch @@ -6,7 +6,7 @@ Subject: fix: disabling compositor recycling Compositor recycling is useful for Chrome because there can be many tabs and spinning up a compositor for each one would be costly. In practice, Chrome uses the parent compositor code path of browser_compositor_view_mac.mm; the NSView of each tab is detached when it's hidden and attached when it's shown. For Electron, there is no parent compositor, so we're forced into the "own compositor" code path, which seems to be non-optimal and pretty ruthless in terms of the release of resources. Electron has no real concept of multiple tabs per window, so it should be okay to disable this ruthless recycling altogether in Electron. diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm -index af8188e695f4e0750e00424c8f5dc490e329f245..7a36d453c7d357ddfe6fe39377cc1fbd8b19fb2d 100644 +index b5e4f8fb0e914078ae40d034e1b785f77607bbea..e8a6199632a3110ae5d0238dfe3568df9224f353 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac.mm +++ b/content/browser/renderer_host/render_widget_host_view_mac.mm @@ -478,7 +478,11 @@ void RenderWidgetHostViewMac::WasOccluded() { diff --git a/patches/chromium/disable_hidden.patch b/patches/chromium/disable_hidden.patch index cb538d917f7db..3795057ee04b7 100644 --- a/patches/chromium/disable_hidden.patch +++ b/patches/chromium/disable_hidden.patch @@ -6,7 +6,7 @@ Subject: disable_hidden.patch Electron uses this to disable background throttling for hidden windows. diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc -index 0dd89a1467902c3585a4fb0ed20d83c3ec596630..1bb34b1700fe89053f78bcecd35af898938620b8 100644 +index 0579758b91619b914b552e947bcba30c249945ec..6c729512a82fc384200565bd427e0c3065ed9d28 100644 --- a/content/browser/renderer_host/render_widget_host_impl.cc +++ b/content/browser/renderer_host/render_widget_host_impl.cc @@ -723,6 +723,9 @@ void RenderWidgetHostImpl::WasHidden() { @@ -20,10 +20,10 @@ index 0dd89a1467902c3585a4fb0ed20d83c3ec596630..1bb34b1700fe89053f78bcecd35af898 blink::mojom::PointerLockResult::kWrongDocument); diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h -index a65560df4f1a71cf9b14e876a4422ac91ab802e5..77965b5131e255a63212929d3484055904a68ecf 100644 +index 168049a5efc1f7816328e66c95ecf7353853a571..deeb6970b8e8b473a1bcf63dab57b73edfc13124 100644 --- a/content/browser/renderer_host/render_widget_host_impl.h +++ b/content/browser/renderer_host/render_widget_host_impl.h -@@ -176,6 +176,9 @@ class CONTENT_EXPORT RenderWidgetHostImpl +@@ -174,6 +174,9 @@ class CONTENT_EXPORT RenderWidgetHostImpl // RenderWidgetHostImpl. static RenderWidgetHostImpl* From(RenderWidgetHost* rwh); diff --git a/patches/chromium/expose_setuseragent_on_networkcontext.patch b/patches/chromium/expose_setuseragent_on_networkcontext.patch index 2b18c42944032..9b1355353f981 100644 --- a/patches/chromium/expose_setuseragent_on_networkcontext.patch +++ b/patches/chromium/expose_setuseragent_on_networkcontext.patch @@ -33,10 +33,10 @@ index 0ccfe130f00ec3b6c75cd8ee04d5a2777e1fd00c..653829457d58bf92057cc36aa8a28970 DISALLOW_COPY_AND_ASSIGN(StaticHttpUserAgentSettings); }; diff --git a/services/network/network_context.cc b/services/network/network_context.cc -index 170ba3cf6176e8423b6009a0ac0299bf1e411158..14f8cb99631232cc225026c345e95df2b548bcff 100644 +index e4d92e5fe7c8a0adaa9852631554878b9c7aa541..4c5e55396ee2115c67d711613f65b7e116ec1023 100644 --- a/services/network/network_context.cc +++ b/services/network/network_context.cc -@@ -1035,6 +1035,13 @@ void NetworkContext::SetNetworkConditions( +@@ -1082,6 +1082,13 @@ void NetworkContext::SetNetworkConditions( std::move(network_conditions)); } @@ -51,10 +51,10 @@ index 170ba3cf6176e8423b6009a0ac0299bf1e411158..14f8cb99631232cc225026c345e95df2 // This may only be called on NetworkContexts created with the constructor // that calls MakeURLRequestContext(). diff --git a/services/network/network_context.h b/services/network/network_context.h -index 391a02c108debdd5e5572b4a666d30dc68ece76b..0d9c4cce09db485b5e750921eed703c75ffdf15a 100644 +index 4a06b262f880e6f15516e62960191dc1cdc829b9..37d4085272f39f451ca7a4b58c27b25771432c88 100644 --- a/services/network/network_context.h +++ b/services/network/network_context.h -@@ -242,6 +242,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext +@@ -243,6 +243,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext void CloseIdleConnections(CloseIdleConnectionsCallback callback) override; void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id, mojom::NetworkConditionsPtr conditions) override; @@ -63,7 +63,7 @@ index 391a02c108debdd5e5572b4a666d30dc68ece76b..0d9c4cce09db485b5e750921eed703c7 void SetEnableReferrers(bool enable_referrers) override; #if defined(OS_CHROMEOS) diff --git a/services/network/public/mojom/network_context.mojom b/services/network/public/mojom/network_context.mojom -index 73b790fab0f6c6377f8206960a478778ecf6e62c..ccac671f0e7e56c731cb9bd92bad788271419a7f 100644 +index 64b71f2bce79b52c81717e8f5ce87d7b7aa86242..41f5c3db2171cbe015dcb8c6a4436b94c377fec8 100644 --- a/services/network/public/mojom/network_context.mojom +++ b/services/network/public/mojom/network_context.mojom @@ -1050,6 +1050,9 @@ interface NetworkContext { @@ -77,7 +77,7 @@ index 73b790fab0f6c6377f8206960a478778ecf6e62c..ccac671f0e7e56c731cb9bd92bad7882 SetAcceptLanguage(string new_accept_language); diff --git a/services/network/test/test_network_context.h b/services/network/test/test_network_context.h -index ef97b4cef0aa4d67926cf42c8ae20e9b90e73531..65831a37e753a9255507a905f80f727f4214441e 100644 +index 0dfed1a77748e3a3efe3fdeb46996f7ca21bec33..f103c782922396a842bccae9dd3ca9f37f4da66e 100644 --- a/services/network/test/test_network_context.h +++ b/services/network/test/test_network_context.h @@ -105,6 +105,7 @@ class TestNetworkContext : public mojom::NetworkContext { diff --git a/patches/chromium/feat_allow_disabling_blink_scheduler_throttling_per_renderview.patch b/patches/chromium/feat_allow_disabling_blink_scheduler_throttling_per_renderview.patch index 2b9a438f77a06..9e746eca7934a 100644 --- a/patches/chromium/feat_allow_disabling_blink_scheduler_throttling_per_renderview.patch +++ b/patches/chromium/feat_allow_disabling_blink_scheduler_throttling_per_renderview.patch @@ -6,10 +6,10 @@ Subject: feat: allow disabling blink scheduler throttling per RenderView This allows us to disable throttling for hidden windows. diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc -index ac344bb71b434861b4b800e5a36622f073e500b6..53806f887ee62b4c08a1b542c0e3aa4e65a812dd 100644 +index d34b836b842cb5c82f79bf2aa9d8334077422cbf..c56d26581500de448ded221a7b872b1d7d365aac 100644 --- a/content/browser/renderer_host/render_view_host_impl.cc +++ b/content/browser/renderer_host/render_view_host_impl.cc -@@ -512,6 +512,10 @@ void RenderViewHostImpl::SetBackgroundOpaque(bool opaque) { +@@ -511,6 +511,10 @@ void RenderViewHostImpl::SetBackgroundOpaque(bool opaque) { GetWidget()->GetAssociatedFrameWidget()->SetBackgroundOpaque(opaque); } @@ -61,10 +61,10 @@ index dfd856eb481114fea9da3e26b4080c9a8473acf6..604a95a0427705eca523e91b08a136f8 // // Returns the current WebKit preferences. Note: WebPreferences is cached, so diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc -index 272b613f658ef4bfa3869cbd17d342ceef665142..461310b69c823546f99d99b087b9ea005167a883 100644 +index d9792ba47cf8621549676564ef4c162b0714d45d..d57a8432e8638036f309f317e6f857757ed54549 100644 --- a/content/renderer/render_view_impl.cc +++ b/content/renderer/render_view_impl.cc -@@ -1170,6 +1170,8 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) { +@@ -1165,6 +1165,8 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) { bool handled = true; IPC_BEGIN_MESSAGE_MAP(RenderViewImpl, message) @@ -73,7 +73,7 @@ index 272b613f658ef4bfa3869cbd17d342ceef665142..461310b69c823546f99d99b087b9ea00 IPC_MESSAGE_HANDLER(ViewMsg_UpdateTargetURL_ACK, OnUpdateTargetURLAck) IPC_MESSAGE_HANDLER(ViewMsg_UpdateWebPreferences, OnUpdateWebPreferences) IPC_MESSAGE_HANDLER(ViewMsg_MoveOrResizeStarted, OnMoveOrResizeStarted) -@@ -1666,6 +1668,12 @@ bool RenderViewImpl::GetContentStateImmediately() { +@@ -1660,6 +1662,12 @@ bool RenderViewImpl::GetContentStateImmediately() { return send_content_state_immediately_; } @@ -87,7 +87,7 @@ index 272b613f658ef4bfa3869cbd17d342ceef665142..461310b69c823546f99d99b087b9ea00 webkit_preferences_ = prefs; ApplyWebPreferences(webkit_preferences_, GetWebView()); diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h -index 79ffb7a4a0ecef7c2e0583ca06a42c7bf6146bcc..ccb6f98da708fba99579623d92f9e40607e94dda 100644 +index 8f81196e2f173fc5d055122ae510c236628cd6b5..f49baf8aad5ffc020f456cdc4c05d983066f32f3 100644 --- a/content/renderer/render_view_impl.h +++ b/content/renderer/render_view_impl.h @@ -391,6 +391,7 @@ class CONTENT_EXPORT RenderViewImpl : public blink::WebViewClient, @@ -99,10 +99,10 @@ index 79ffb7a4a0ecef7c2e0583ca06a42c7bf6146bcc..ccb6f98da708fba99579623d92f9e406 void OnUpdateTargetURLAck(); void OnUpdateWebPreferences(const WebPreferences& prefs); diff --git a/third_party/blink/public/web/web_view.h b/third_party/blink/public/web/web_view.h -index baa1cec07522a23221b146165a638d3f679f9817..50f0c46c8fcbb4ee8ebb316f859f84d02d93ceda 100644 +index b5562d3ea4cec46f2a763caab823db3160331084..e88ae7c76397f51d07ccdb680ce2344a61c9aa38 100644 --- a/third_party/blink/public/web/web_view.h +++ b/third_party/blink/public/web/web_view.h -@@ -393,6 +393,7 @@ class WebView { +@@ -388,6 +388,7 @@ class WebView { // Scheduling ----------------------------------------------------------- virtual PageScheduler* Scheduler() const = 0; @@ -111,7 +111,7 @@ index baa1cec07522a23221b146165a638d3f679f9817..50f0c46c8fcbb4ee8ebb316f859f84d0 // Visibility ----------------------------------------------------------- diff --git a/third_party/blink/renderer/core/exported/web_view_impl.cc b/third_party/blink/renderer/core/exported/web_view_impl.cc -index ee2a4ab93dc4e774709cedfe7840c15d326a627f..9be53e2e26044062dd2b0df9b20c9f039b600515 100644 +index fc961dd8c7e5285dc04c5e8e5f6f8eeecb49b50b..7ae0213d684f950a3f123ab3dff7343a675babf9 100644 --- a/third_party/blink/renderer/core/exported/web_view_impl.cc +++ b/third_party/blink/renderer/core/exported/web_view_impl.cc @@ -3369,6 +3369,13 @@ PageScheduler* WebViewImpl::Scheduler() const { @@ -139,7 +139,7 @@ index ee2a4ab93dc4e774709cedfe7840c15d326a627f..9be53e2e26044062dd2b0df9b20c9f03 mojom::blink::PageVisibilityState WebViewImpl::GetVisibilityState() { diff --git a/third_party/blink/renderer/core/exported/web_view_impl.h b/third_party/blink/renderer/core/exported/web_view_impl.h -index e2124434e0d8ba3416179534ababca9d3b7f1708..3881e7a9f6fb25cbec37ddce6f87bf25b0d4a400 100644 +index 395899d96358e2af8f7c6ca7f44ae1ec38bbe0ed..aee2b40effb2050f309e09642edf56e44859e714 100644 --- a/third_party/blink/renderer/core/exported/web_view_impl.h +++ b/third_party/blink/renderer/core/exported/web_view_impl.h @@ -329,6 +329,7 @@ class CORE_EXPORT WebViewImpl final : public WebView, diff --git a/patches/chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch b/patches/chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch index 32dbcadaa2c42..839f58285e1ae 100644 --- a/patches/chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch +++ b/patches/chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch @@ -94,10 +94,10 @@ index 1026b739d283f0fc252fa2af83a6d4cf51bc8553..fe562ab60ce98b8bb0c5080a6428deb3 private: const HWND hwnd_; diff --git a/components/viz/service/BUILD.gn b/components/viz/service/BUILD.gn -index 31edc0dfc191b82b8f1bff5fcfd95c9cec5ea2b1..d59e0c156c5e02ac37d6aa233cf4cac836152d7c 100644 +index 5f8fbe5b245946b8c6307f2026842277d7be4664..fa78160ebdb8cbc975047e933d7b086b7f226b4f 100644 --- a/components/viz/service/BUILD.gn +++ b/components/viz/service/BUILD.gn -@@ -111,6 +111,8 @@ viz_component("service") { +@@ -113,6 +113,8 @@ viz_component("service") { "display_embedder/output_surface_provider_impl.h", "display_embedder/server_shared_bitmap_manager.cc", "display_embedder/server_shared_bitmap_manager.h", diff --git a/patches/chromium/fix_accessibility_label_id_mismatch.patch b/patches/chromium/fix_accessibility_label_id_mismatch.patch deleted file mode 100644 index 8124b03d26cf0..0000000000000 --- a/patches/chromium/fix_accessibility_label_id_mismatch.patch +++ /dev/null @@ -1,28 +0,0 @@ -From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 -From: Shelley Vohr -Date: Tue, 14 Jul 2020 09:54:17 -0700 -Subject: Fix accessibility label ID mismatch - -Refs https://chromium-review.googlesource.com/c/chromium/src/+/2231678. - -When the label was updated to use underscores, the associated jQuery -call in accessibility.js was not likewise updated, so it would error -with: - -"Uncaught TypeError: Cannot read property 'value' of null" - -Upstreamed at https://chromium-review.googlesource.com/c/chromium/src/+/2296883 - -diff --git a/chrome/browser/resources/accessibility/accessibility.js b/chrome/browser/resources/accessibility/accessibility.js -index d0b0b7f9b922f9c5af180e1bfb22b886b51f90f7..bfa746233310a1150382750030f565fa81e93361 100644 ---- a/chrome/browser/resources/accessibility/accessibility.js -+++ b/chrome/browser/resources/accessibility/accessibility.js -@@ -80,7 +80,7 @@ cr.define('accessibility', function() { - // function with the result. - const requestType = element.id.split(':')[1]; - if (data.type == 'browser') { -- const delay = $('native_ui_delay').value; -+ const delay = $('native-ui-delay').value; - setTimeout(() => { - chrome.send( - 'requestNativeUITree', [{ diff --git a/patches/chromium/fix_compare_page_size_to_ulong_not_int.patch b/patches/chromium/fix_compare_page_size_to_ulong_not_int.patch deleted file mode 100644 index 12ae416481c82..0000000000000 --- a/patches/chromium/fix_compare_page_size_to_ulong_not_int.patch +++ /dev/null @@ -1,20 +0,0 @@ -From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 -From: Samuel Attard -Date: Tue, 14 Jul 2020 14:51:31 -0700 -Subject: fix: compare page size to ulong not int - -Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2298340 - -diff --git a/base/process/process_metrics_mac.cc b/base/process/process_metrics_mac.cc -index 6d05c82369f792f5f396dfc4f2c61f49b6585390..8f80975763e8a2e04dbe5864d7d4eaf7460cd119 100644 ---- a/base/process/process_metrics_mac.cc -+++ b/base/process/process_metrics_mac.cc -@@ -298,7 +298,7 @@ bool GetSystemMemoryInfo(SystemMemoryInfoKB* meminfo) { - - #if defined(ARCH_CPU_ARM64) - // PAGE_SIZE is vm_page_size on arm, which isn't constexpr. -- DCHECK_EQ(PAGE_SIZE % 1024, 0) << "Invalid page size"; -+ DCHECK_EQ(PAGE_SIZE % 1024, static_cast(0)) << "Invalid page size"; - #else - static_assert(PAGE_SIZE % 1024 == 0, "Invalid page size"); - #endif diff --git a/patches/chromium/fix_disable_usage_of_pthread_fchdir_np_and_pthread_chdir_np_in_mas.patch b/patches/chromium/fix_disable_usage_of_pthread_fchdir_np_and_pthread_chdir_np_in_mas.patch index 327ced6e13da4..5b1e75561d6cf 100644 --- a/patches/chromium/fix_disable_usage_of_pthread_fchdir_np_and_pthread_chdir_np_in_mas.patch +++ b/patches/chromium/fix_disable_usage_of_pthread_fchdir_np_and_pthread_chdir_np_in_mas.patch @@ -7,7 +7,7 @@ Subject: Disable usage of pthread_fchdir_np and pthread_chdir_np in MAS builds. diff --git a/base/process/launch_mac.cc b/base/process/launch_mac.cc -index 9e523d39181865aea8d35d998bc38a3a086943f6..57dd01b917242e0e83ade09a7356b351c666ab6d 100644 +index 2841b7735430ca3fb03fff7a737b393a8d168747..e356bfe7fdfc11b3b1df429337cf460037788dd8 100644 --- a/base/process/launch_mac.cc +++ b/base/process/launch_mac.cc @@ -26,8 +26,10 @@ extern "C" { diff --git a/patches/chromium/fix_missing_weakptr_check_in_preconnectmanager.patch b/patches/chromium/fix_missing_weakptr_check_in_preconnectmanager.patch new file mode 100644 index 0000000000000..b41f79f2da872 --- /dev/null +++ b/patches/chromium/fix_missing_weakptr_check_in_preconnectmanager.patch @@ -0,0 +1,26 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Shelley Vohr +Date: Mon, 20 Jul 2020 14:02:56 -0700 +Subject: fix: missing WeakPtr check in PreconnectManager + +https://chromium-review.googlesource.com/c/chromium/src/+/2295780 +added UKM around prefetch accuracy stats, which involved an added line +in PreconnectManager::TryToLaunchPreresolveJobs() that did not check +the WeakPtr before using it. This fixes that. + +Upstreamed at: https://chromium-review.googlesource.com/c/chromium/src/+/2309029 + +diff --git a/chrome/browser/predictors/preconnect_manager.cc b/chrome/browser/predictors/preconnect_manager.cc +index 78216f0083281b4f1e0209f766753d0dc9c796c4..bd81f631b15cc4cb8c54afd51bd8739f4256ae33 100644 +--- a/chrome/browser/predictors/preconnect_manager.cc ++++ b/chrome/browser/predictors/preconnect_manager.cc +@@ -231,7 +231,8 @@ void PreconnectManager::TryToLaunchPreresolveJobs() { + weak_factory_.GetWeakPtr(), job_id)); + if (info) { + ++info->inflight_count; +- delegate_->PreconnectInitiated(info->url, job->url); ++ if (delegate_) ++ delegate_->PreconnectInitiated(info->url, job->url); + } + ++inflight_preresolves_count_; + } else { diff --git a/patches/chromium/fix_route_mouse_event_navigations_through_the_web_contents_delegate.patch b/patches/chromium/fix_route_mouse_event_navigations_through_the_web_contents_delegate.patch index f6bd048d03574..93842a63738d0 100644 --- a/patches/chromium/fix_route_mouse_event_navigations_through_the_web_contents_delegate.patch +++ b/patches/chromium/fix_route_mouse_event_navigations_through_the_web_contents_delegate.patch @@ -13,10 +13,10 @@ This patch can be removed once app.allowRendererProcessReuse is forced to true as then Chromiums assumptions around processes become correct. diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc -index ffc75af10134776aa3ecad331ee9c6a228101e1a..e555eddccb83b91754ba95f9a2545019e6b66e1c 100644 +index 502893ba5219f64ed9c84f83c40b28188966d2a0..6a30734d3314041af985a1f9056595a23a10d6a9 100644 --- a/content/browser/web_contents/web_contents_impl.cc +++ b/content/browser/web_contents/web_contents_impl.cc -@@ -2486,11 +2486,13 @@ bool WebContentsImpl::HandleMouseEvent(const blink::WebMouseEvent& event) { +@@ -2499,11 +2499,13 @@ bool WebContentsImpl::HandleMouseEvent(const blink::WebMouseEvent& event) { WebContentsImpl* outermost = GetOutermostWebContents(); if (event.button == blink::WebPointerProperties::Button::kBack && outermost->controller_.CanGoBack()) { diff --git a/patches/chromium/fix_swap_global_proxies_before_initializing_the_windows_proxies.patch b/patches/chromium/fix_swap_global_proxies_before_initializing_the_windows_proxies.patch index 1ced85f26c478..007d0e7bc58fd 100644 --- a/patches/chromium/fix_swap_global_proxies_before_initializing_the_windows_proxies.patch +++ b/patches/chromium/fix_swap_global_proxies_before_initializing_the_windows_proxies.patch @@ -61,7 +61,7 @@ index 33d85e22813ee15ced7e8c41d1bc070c8dbbdd26..d9ff55f67ffa4208a6fa342ed24cd6e1 // TODO(dcheng): Temporarily exposed to avoid include cycles. Remove the need // for this and remove this getter. diff --git a/third_party/blink/renderer/bindings/core/v8/window_proxy_manager.cc b/third_party/blink/renderer/bindings/core/v8/window_proxy_manager.cc -index b302d33b3dfe211cacf4f3b842a5c52baa2788d1..f95018422eb8c9948f33687b0aaabcf3f003949e 100644 +index 90083d1fa2e2fed8173f6ff993c7a93da36510bf..9fa174ba67b1212a70f8951eda86d12ecb0df9a3 100644 --- a/third_party/blink/renderer/bindings/core/v8/window_proxy_manager.cc +++ b/third_party/blink/renderer/bindings/core/v8/window_proxy_manager.cc @@ -55,8 +55,11 @@ void WindowProxyManager::ReleaseGlobalProxies( diff --git a/patches/chromium/frame_host_manager.patch b/patches/chromium/frame_host_manager.patch index bab73372f801e..58782e6f31377 100644 --- a/patches/chromium/frame_host_manager.patch +++ b/patches/chromium/frame_host_manager.patch @@ -8,10 +8,10 @@ and respond with custom instance. Also allows for us to at-runtime enable or disable this patch. diff --git a/content/browser/browsing_instance.cc b/content/browser/browsing_instance.cc -index bf11dcb1ef101fc437a21c00adff19dfb18bfe91..b32d13009d7f1e413a217bbfcec53c586a67cf6b 100644 +index 54546d15ba4006481ca8844e26b86359d3eb8a79..7712c681170ddf6739b2825b4b2fb9284a23f4b1 100644 --- a/content/browser/browsing_instance.cc +++ b/content/browser/browsing_instance.cc -@@ -84,6 +84,13 @@ scoped_refptr BrowsingInstance::GetSiteInstanceForURL( +@@ -83,6 +83,13 @@ scoped_refptr BrowsingInstance::GetSiteInstanceForURL( return instance; } @@ -22,14 +22,14 @@ index bf11dcb1ef101fc437a21c00adff19dfb18bfe91..b32d13009d7f1e413a217bbfcec53c58 + return instance; +} + - void BrowsingInstance::GetSiteAndLockForURL(const GURL& url, - bool allow_default_instance, - GURL* site_url, + SiteInfo BrowsingInstance::GetSiteInfoForURL(const GURL& url, + bool allow_default_instance) { + scoped_refptr site_instance = diff --git a/content/browser/browsing_instance.h b/content/browser/browsing_instance.h -index 6b03c07316eaab83a50afc123fc9f17b1c1dfa3b..e821571731e4e1a93f873477c7410de7c4ee78f9 100644 +index 7f588450c441ed2b17db06afb38075bbfadfc633..e56178401374f3c6a9536056511fb63a20195e56 100644 --- a/content/browser/browsing_instance.h +++ b/content/browser/browsing_instance.h -@@ -139,6 +139,11 @@ class CONTENT_EXPORT BrowsingInstance final +@@ -134,6 +134,11 @@ class CONTENT_EXPORT BrowsingInstance final const GURL& url, bool allow_default_instance); @@ -42,10 +42,10 @@ index 6b03c07316eaab83a50afc123fc9f17b1c1dfa3b..e821571731e4e1a93f873477c7410de7 // another SiteInstance for the same site. void RegisterSiteInstance(SiteInstanceImpl* site_instance); diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc -index 390809306283bee79445b812a132c71263af1942..2013298a3a8f133c24912fc11254cd78d425eece 100644 +index 2cf0ea5f20c09a6bc9948b4485f3f023c5c53b59..81f95e2ad9d0200c779f277d190ad870ebf91d3f 100644 --- a/content/browser/frame_host/navigation_request.cc +++ b/content/browser/frame_host/navigation_request.cc -@@ -1446,6 +1446,21 @@ void NavigationRequest::BeginNavigation() { +@@ -1447,6 +1447,21 @@ void NavigationRequest::BeginNavigation() { // it immediately. EnterChildTraceEvent("ResponseStarted", this); @@ -67,7 +67,7 @@ index 390809306283bee79445b812a132c71263af1942..2013298a3a8f133c24912fc11254cd78 // Select an appropriate RenderFrameHost. render_frame_host_ = frame_tree_node_->render_manager()->GetFrameHostForNavigation(this); -@@ -4892,6 +4907,7 @@ void NavigationRequest::CheckStateTransition(NavigationState state) const { +@@ -4893,6 +4908,7 @@ void NavigationRequest::CheckStateTransition(NavigationState state) const { {WILL_START_REQUEST, { WILL_REDIRECT_REQUEST, WILL_PROCESS_RESPONSE, @@ -75,7 +75,7 @@ index 390809306283bee79445b812a132c71263af1942..2013298a3a8f133c24912fc11254cd78 READY_TO_COMMIT, DID_COMMIT, CANCELING, -@@ -4905,10 +4921,14 @@ void NavigationRequest::CheckStateTransition(NavigationState state) const { +@@ -4906,10 +4922,14 @@ void NavigationRequest::CheckStateTransition(NavigationState state) const { WILL_FAIL_REQUEST, }}, {WILL_PROCESS_RESPONSE, { @@ -106,10 +106,10 @@ index ccaa4324303df603bb7bc24077f58920420e0dae..8af5643e2105c8e307b7b736b72807e5 READY_TO_COMMIT, diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc -index f8066e336552afc82b3177e37bd78bee978866c6..6b2226b394fdc5de32fbd8cd934f1a1bd2a220c1 100644 +index a1f68822b0d4fb8eaac271a5bf4aaeaf0765c124..23843f36808d37a753acc92199e82e7568df92da 100644 --- a/content/browser/frame_host/render_frame_host_manager.cc +++ b/content/browser/frame_host/render_frame_host_manager.cc -@@ -2333,6 +2333,16 @@ bool RenderFrameHostManager::InitRenderView( +@@ -2335,6 +2335,16 @@ bool RenderFrameHostManager::InitRenderView( scoped_refptr RenderFrameHostManager::GetSiteInstanceForNavigationRequest( NavigationRequest* request) { @@ -126,7 +126,7 @@ index f8066e336552afc82b3177e37bd78bee978866c6..6b2226b394fdc5de32fbd8cd934f1a1b SiteInstance* current_site_instance = render_frame_host_->GetSiteInstance(); // All children of MHTML documents must be MHTML documents. They all live in -@@ -2352,10 +2362,60 @@ RenderFrameHostManager::GetSiteInstanceForNavigationRequest( +@@ -2354,10 +2364,60 @@ RenderFrameHostManager::GetSiteInstanceForNavigationRequest( // // TODO(clamy): We should also consider as a candidate SiteInstance the // speculative SiteInstance that was computed on redirects. @@ -191,7 +191,7 @@ index f8066e336552afc82b3177e37bd78bee978866c6..6b2226b394fdc5de32fbd8cd934f1a1b // Account for renderer-initiated reload as well. // Needed as a workaround for https://crbug.com/1045524, remove it when it is -@@ -2381,6 +2441,9 @@ RenderFrameHostManager::GetSiteInstanceForNavigationRequest( +@@ -2383,6 +2443,9 @@ RenderFrameHostManager::GetSiteInstanceForNavigationRequest( request->ResetStateForSiteInstanceChange(); } @@ -202,11 +202,11 @@ index f8066e336552afc82b3177e37bd78bee978866c6..6b2226b394fdc5de32fbd8cd934f1a1b } diff --git a/content/browser/site_instance_impl.cc b/content/browser/site_instance_impl.cc -index 618f09320ff73c720c75b859dc9252dde3f220da..a16f26d72971de417ace7f698bdcfed2889d4ad9 100644 +index 5a7ccbd331b4b6a898abea1d1c0081ff6ab20fea..2163cdc8808a3aec0a94df8a352594a8515f0f79 100644 --- a/content/browser/site_instance_impl.cc +++ b/content/browser/site_instance_impl.cc -@@ -491,6 +491,10 @@ bool SiteInstanceImpl::HasRelatedSiteInstance(const GURL& url) { - return browsing_instance_->HasSiteInstance(url); +@@ -497,6 +497,10 @@ bool SiteInstanceImpl::HasRelatedSiteInstance(const SiteInfo& site_info) { + return browsing_instance_->HasSiteInstance(site_info); } +scoped_refptr SiteInstanceImpl::CreateRelatedSiteInstance(const GURL& url) { @@ -217,10 +217,10 @@ index 618f09320ff73c720c75b859dc9252dde3f220da..a16f26d72971de417ace7f698bdcfed2 const GURL& url) { return browsing_instance_->GetSiteInstanceForURL( diff --git a/content/browser/site_instance_impl.h b/content/browser/site_instance_impl.h -index 571e6381f2456450a07b64c3a84d1f15f4cbbefa..cb342a6c4915c4b2cc7fe0c1b3c7219f1e420101 100644 +index e5d26881312d422ef34b8d769528a7ad4e5c8dd4..48bf203e49584b337dc5cca99339f74107f8ca97 100644 --- a/content/browser/site_instance_impl.h +++ b/content/browser/site_instance_impl.h -@@ -160,6 +160,7 @@ class CONTENT_EXPORT SiteInstanceImpl final : public SiteInstance, +@@ -183,6 +183,7 @@ class CONTENT_EXPORT SiteInstanceImpl final : public SiteInstance, BrowserContext* GetBrowserContext() override; const GURL& GetSiteURL() override; scoped_refptr GetRelatedSiteInstance(const GURL& url) override; @@ -229,10 +229,10 @@ index 571e6381f2456450a07b64c3a84d1f15f4cbbefa..cb342a6c4915c4b2cc7fe0c1b3c7219f size_t GetRelatedActiveContentsCount() override; bool RequiresDedicatedProcess() override; diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc -index 0583f1ef5b851a6d39bac4d134d37a83e18e6f1a..868e9c2bfb62cf2d39321f59d720c48d4424ac8d 100644 +index 2e1b2be0a96ef14e0d5d0cec0ce114ad97b4bf37..b8c89b77f1e0f5e78c7ca8f55eb5f4547fc40f54 100644 --- a/content/public/browser/content_browser_client.cc +++ b/content/public/browser/content_browser_client.cc -@@ -62,6 +62,21 @@ +@@ -61,6 +61,21 @@ namespace content { @@ -255,7 +255,7 @@ index 0583f1ef5b851a6d39bac4d134d37a83e18e6f1a..868e9c2bfb62cf2d39321f59d720c48d const MainFunctionParams& parameters) { return nullptr; diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h -index 1ec9bc579a66369c9b78a8155a6f7cf5cd933f71..82718ff949a5d4e0b6c5b76162163551a79bc47e 100644 +index f2b64eb90f80c94a9b8a7374b5733a609446346b..28f170b9455835f0c90af3411538b098e4fe75e9 100644 --- a/content/public/browser/content_browser_client.h +++ b/content/public/browser/content_browser_client.h @@ -247,8 +247,45 @@ class CONTENT_EXPORT ContentBrowserClient { diff --git a/patches/chromium/gin_enable_disable_v8_platform.patch b/patches/chromium/gin_enable_disable_v8_platform.patch index a08f9d609e843..290729fd24b88 100644 --- a/patches/chromium/gin_enable_disable_v8_platform.patch +++ b/patches/chromium/gin_enable_disable_v8_platform.patch @@ -7,7 +7,7 @@ We don't use gin to create the V8 platform, because we need to inject Node things. diff --git a/gin/isolate_holder.cc b/gin/isolate_holder.cc -index 570a23af3c0fb4839b063c742d1d345a27799cd0..ece381bb1ce22bc65c3d8e428354adeb4b6fe4c1 100644 +index 13f6369429c2715330bc921f34c4941653269078..58a0eb4b105c802f9dd336a778081ccb0ef084a0 100644 --- a/gin/isolate_holder.cc +++ b/gin/isolate_holder.cc @@ -103,9 +103,10 @@ IsolateHolder::~IsolateHolder() { diff --git a/patches/chromium/gpu_notify_when_dxdiag_request_fails.patch b/patches/chromium/gpu_notify_when_dxdiag_request_fails.patch index a46361be6667d..3b05930e68f71 100644 --- a/patches/chromium/gpu_notify_when_dxdiag_request_fails.patch +++ b/patches/chromium/gpu_notify_when_dxdiag_request_fails.patch @@ -40,10 +40,10 @@ index 8af48d23b020779c1714fc7ca70966e8d33f7252..5dfa29db15467f8fc55f86a2a225380c // Update the GPU feature info. This updates the blacklist and enabled status // of GPU rasterization. In the future this will be used for more features. diff --git a/content/browser/gpu/gpu_data_manager_impl_private.cc b/content/browser/gpu/gpu_data_manager_impl_private.cc -index c4c5c35fc44f388b620301ec285eb759533f575e..be57761abd556fe1fa087c0062e0bbd58224cd9b 100644 +index 462ac6dcb6e83fdc478de35eb4fb0636590e48b9..b8b627b2a04e58f82967d28c63f941a1162df226 100644 --- a/content/browser/gpu/gpu_data_manager_impl_private.cc +++ b/content/browser/gpu/gpu_data_manager_impl_private.cc -@@ -1055,6 +1055,11 @@ void GpuDataManagerImplPrivate::TerminateInfoCollectionGpuProcess() { +@@ -1060,6 +1060,11 @@ void GpuDataManagerImplPrivate::TerminateInfoCollectionGpuProcess() { host->ForceShutdown(); } diff --git a/patches/chromium/isolate_holder.patch b/patches/chromium/isolate_holder.patch index 727cc2e2c32bd..5cc35ed51ad88 100644 --- a/patches/chromium/isolate_holder.patch +++ b/patches/chromium/isolate_holder.patch @@ -8,7 +8,7 @@ needs to register on an isolate so that it can be used later down in the initialization process of an isolate. diff --git a/gin/isolate_holder.cc b/gin/isolate_holder.cc -index ece381bb1ce22bc65c3d8e428354adeb4b6fe4c1..161788e0ba5b12dff34d71ff9e84c71615d93a58 100644 +index 58a0eb4b105c802f9dd336a778081ccb0ef084a0..77e0d468f0fcb3b37f8f47134bf543db03b53a16 100644 --- a/gin/isolate_holder.cc +++ b/gin/isolate_holder.cc @@ -53,7 +53,8 @@ IsolateHolder::IsolateHolder( diff --git a/patches/chromium/mas-cgdisplayusesforcetogray.patch b/patches/chromium/mas-cgdisplayusesforcetogray.patch index 471c5125d818b..d89e85abdff2c 100644 --- a/patches/chromium/mas-cgdisplayusesforcetogray.patch +++ b/patches/chromium/mas-cgdisplayusesforcetogray.patch @@ -6,10 +6,10 @@ Subject: mas-cgdisplayusesforcetogray.patch Removes usage of the CGDisplayUsesForceToGray private API. diff --git a/ui/display/mac/screen_mac.mm b/ui/display/mac/screen_mac.mm -index def99d430032be2791e689cb77603cfeb02a034f..066a6ef5d24705387e9f88feede2d32a73dcf6aa 100644 +index 00415aac8b80fc914af6af7209cc431c156e2b95..e37ca0b7cb3c7fdc4a9f47c18d0afc1ff1764dd9 100644 --- a/ui/display/mac/screen_mac.mm +++ b/ui/display/mac/screen_mac.mm -@@ -131,7 +131,17 @@ Display BuildDisplayForScreen(NSScreen* screen) { +@@ -133,7 +133,17 @@ Display BuildDisplayForScreen(NSScreen* screen) { display.set_color_depth(Display::kDefaultBitsPerPixel); display.set_depth_per_component(Display::kDefaultBitsPerComponent); } diff --git a/patches/chromium/mas_disable_custom_window_frame.patch b/patches/chromium/mas_disable_custom_window_frame.patch index 554db884c796c..0bba99b56016b 100644 --- a/patches/chromium/mas_disable_custom_window_frame.patch +++ b/patches/chromium/mas_disable_custom_window_frame.patch @@ -7,7 +7,7 @@ Disable private window frame APIs (NSNextStepFrame and NSThemeFrame) for MAS build. diff --git a/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm b/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm -index 2cd283de6677f0c256940ab475eb6c58d8040f54..ad7f1f0c05b491977ccd5650c94248e876ad2b0e 100644 +index 69580888047c4ac6abb68873315bcafb78dda706..aa347913a75084f669bf7d89fbcc919b5222c2d5 100644 --- a/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm +++ b/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm @@ -9,6 +9,7 @@ @@ -27,7 +27,7 @@ index 2cd283de6677f0c256940ab475eb6c58d8040f54..ad7f1f0c05b491977ccd5650c94248e8 @implementation BrowserNativeWidgetWindow // Prevent detached tabs from glitching when the window is partially offscreen. -@@ -88,6 +91,7 @@ +@@ -84,6 +87,7 @@ // NSWindow (PrivateAPI) overrides. @@ -35,7 +35,7 @@ index 2cd283de6677f0c256940ab475eb6c58d8040f54..ad7f1f0c05b491977ccd5650c94248e8 + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle { // - NSThemeFrame and its subclasses will be nil if it's missing at runtime. if ([BrowserWindowFrame class]) -@@ -102,6 +106,8 @@ +@@ -98,6 +102,8 @@ return NO; } diff --git a/patches/chromium/mas_disable_remote_accessibility.patch b/patches/chromium/mas_disable_remote_accessibility.patch index a596a3c9aa9ae..9efc4526351ce 100644 --- a/patches/chromium/mas_disable_remote_accessibility.patch +++ b/patches/chromium/mas_disable_remote_accessibility.patch @@ -90,7 +90,7 @@ index c3a9fbf0f9d2b80c1de42a22ad094a286f0b559b..02493d4b62c98a3aebd3e460c459218a DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostNSViewBridgeOwner); }; diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h -index d5610b3ff1a834b16115647c3530618887f2155b..2643eda13762d5605f42ce7c98133bf627e38318 100644 +index 90f5455272c6685f6d5abeb6c636234f49618422..d13cc2c15ae553c2d20562deea62173b7d933f59 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac.h +++ b/content/browser/renderer_host/render_widget_host_view_mac.h @@ -47,7 +47,9 @@ class ScopedPasswordInputEnabler; @@ -117,7 +117,7 @@ index d5610b3ff1a834b16115647c3530618887f2155b..2643eda13762d5605f42ce7c98133bf6 // Used to force the NSApplication's focused accessibility element to be the // content::BrowserAccessibilityCocoa accessibility tree when the NSView for diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm -index bca6e5fe1cb20ffba29fee5b5ec6856392fe3579..af8188e695f4e0750e00424c8f5dc490e329f245 100644 +index ed223cdb6ea7a0f6130547b7988982bb44aa157d..b5e4f8fb0e914078ae40d034e1b785f77607bbea 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac.mm +++ b/content/browser/renderer_host/render_widget_host_view_mac.mm @@ -233,8 +233,10 @@ RenderWidgetHostViewMac::~RenderWidgetHostViewMac() { diff --git a/patches/chromium/mas_no_private_api.patch b/patches/chromium/mas_no_private_api.patch index eae9565e44cc6..3271e5b5bc595 100644 --- a/patches/chromium/mas_no_private_api.patch +++ b/patches/chromium/mas_no_private_api.patch @@ -348,10 +348,10 @@ index 474ae88c323e9a10bd8486482507f0d749214963..090c8fdc3b374ed937d3e04ccd5d9177 return nil; } diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.mm b/content/browser/accessibility/browser_accessibility_manager_mac.mm -index 04bbb885b29cd2038f11214d0bec40a2b691f5e1..abfdcfbe576dbddc42090818cc2bc13da4b453e9 100644 +index aaf53dd214037f103ea7399d0702b1e2ffff1b56..5972939a070908521e82845b084d2d3b9f9a73f8 100644 --- a/content/browser/accessibility/browser_accessibility_manager_mac.mm +++ b/content/browser/accessibility/browser_accessibility_manager_mac.mm -@@ -526,6 +526,7 @@ NSDictionary* BrowserAccessibilityManagerMac:: +@@ -527,6 +527,7 @@ NSDictionary* BrowserAccessibilityManagerMac:: [user_info setObject:native_focus_object forKey:NSAccessibilityTextChangeElement]; @@ -359,7 +359,7 @@ index 04bbb885b29cd2038f11214d0bec40a2b691f5e1..abfdcfbe576dbddc42090818cc2bc13d id selected_text = [native_focus_object selectedTextMarkerRange]; if (selected_text) { NSString* const NSAccessibilitySelectedTextMarkerRangeAttribute = -@@ -533,6 +534,7 @@ NSDictionary* BrowserAccessibilityManagerMac:: +@@ -534,6 +535,7 @@ NSDictionary* BrowserAccessibilityManagerMac:: [user_info setObject:selected_text forKey:NSAccessibilitySelectedTextMarkerRangeAttribute]; } diff --git a/patches/chromium/network_service_allow_remote_certificate_verification_logic.patch b/patches/chromium/network_service_allow_remote_certificate_verification_logic.patch index 95a40d8d26d14..63812fa699c3a 100644 --- a/patches/chromium/network_service_allow_remote_certificate_verification_logic.patch +++ b/patches/chromium/network_service_allow_remote_certificate_verification_logic.patch @@ -7,10 +7,10 @@ This adds a callback from the network service that's used to implement session.setCertificateVerifyCallback. diff --git a/services/network/network_context.cc b/services/network/network_context.cc -index 3bb208bad23cd3247f95305104a856e9d0bbc396..170ba3cf6176e8423b6009a0ac0299bf1e411158 100644 +index 21f7e1227017397fcd74152f45a7b99348675109..e4d92e5fe7c8a0adaa9852631554878b9c7aa541 100644 --- a/services/network/network_context.cc +++ b/services/network/network_context.cc -@@ -114,6 +114,11 @@ +@@ -115,6 +115,11 @@ #include "services/network/url_loader.h" #include "services/network/url_request_context_builder_mojo.h" @@ -22,7 +22,7 @@ index 3bb208bad23cd3247f95305104a856e9d0bbc396..170ba3cf6176e8423b6009a0ac0299bf #if BUILDFLAG(IS_CT_SUPPORTED) #include "components/certificate_transparency/chrome_ct_policy_enforcer.h" #include "components/certificate_transparency/chrome_require_ct_delegate.h" -@@ -324,6 +329,79 @@ std::string HashesToBase64String(const net::HashValueVector& hashes) { +@@ -371,6 +376,79 @@ bool SCTAuditingDelegate::IsSCTAuditingEnabled() { } // namespace @@ -102,7 +102,7 @@ index 3bb208bad23cd3247f95305104a856e9d0bbc396..170ba3cf6176e8423b6009a0ac0299bf constexpr uint32_t NetworkContext::kMaxOutstandingRequestsPerProcess; NetworkContext::PendingCertVerify::PendingCertVerify() = default; -@@ -518,6 +596,13 @@ void NetworkContext::SetClient( +@@ -565,6 +643,13 @@ void NetworkContext::SetClient( client_.Bind(std::move(client)); } @@ -116,7 +116,7 @@ index 3bb208bad23cd3247f95305104a856e9d0bbc396..170ba3cf6176e8423b6009a0ac0299bf void NetworkContext::CreateURLLoaderFactory( mojo::PendingReceiver receiver, mojom::URLLoaderFactoryParamsPtr params) { -@@ -1723,8 +1808,9 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext( +@@ -1815,8 +1900,9 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext( "NetworkContext should pass CertVerifierServiceRemoteParams."; std::unique_ptr cert_verifier; @@ -127,7 +127,7 @@ index 3bb208bad23cd3247f95305104a856e9d0bbc396..170ba3cf6176e8423b6009a0ac0299bf } else { if (params_->cert_verifier_params && params_->cert_verifier_params->is_remote_params()) { -@@ -1752,14 +1838,14 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext( +@@ -1844,14 +1930,14 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext( cert_net_fetcher_ = base::MakeRefCounted(); @@ -145,7 +145,7 @@ index 3bb208bad23cd3247f95305104a856e9d0bbc396..170ba3cf6176e8423b6009a0ac0299bf #if defined(OS_CHROMEOS) cert_verifier_with_trust_anchors_ = -@@ -1768,13 +1854,27 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext( +@@ -1860,13 +1946,27 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext( UpdateAdditionalCertificates( std::move(params_->initial_additional_certificates)); cert_verifier_with_trust_anchors_->InitializeOnIOThread( @@ -178,10 +178,10 @@ index 3bb208bad23cd3247f95305104a856e9d0bbc396..170ba3cf6176e8423b6009a0ac0299bf std::unique_ptr network_delegate = std::make_unique( diff --git a/services/network/network_context.h b/services/network/network_context.h -index eced38ff04f8d7f3a91079b65f5ad29348bf8813..391a02c108debdd5e5572b4a666d30dc68ece76b 100644 +index 411d99eafbd1bf8f713493630cf8e2fe2c8e062b..4a06b262f880e6f15516e62960191dc1cdc829b9 100644 --- a/services/network/network_context.h +++ b/services/network/network_context.h -@@ -86,6 +86,7 @@ class DomainReliabilityMonitor; +@@ -87,6 +87,7 @@ class DomainReliabilityMonitor; namespace network { class CertVerifierWithTrustAnchors; @@ -189,7 +189,7 @@ index eced38ff04f8d7f3a91079b65f5ad29348bf8813..391a02c108debdd5e5572b4a666d30dc class CookieManager; class ExpectCTReporter; class HostResolver; -@@ -189,6 +190,8 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext +@@ -190,6 +191,8 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext void CreateURLLoaderFactory( mojo::PendingReceiver receiver, mojom::URLLoaderFactoryParamsPtr params) override; @@ -198,7 +198,7 @@ index eced38ff04f8d7f3a91079b65f5ad29348bf8813..391a02c108debdd5e5572b4a666d30dc void ResetURLLoaderFactories() override; void GetCookieManager( mojo::PendingReceiver receiver) override; -@@ -653,6 +656,8 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext +@@ -675,6 +678,8 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext CertVerifierWithTrustAnchors* cert_verifier_with_trust_anchors_ = nullptr; #endif @@ -208,7 +208,7 @@ index eced38ff04f8d7f3a91079b65f5ad29348bf8813..391a02c108debdd5e5572b4a666d30dc // CertNetFetcher is not used by the current platform, or if the actual // net::CertVerifier is instantiated outside of the network service. diff --git a/services/network/public/mojom/network_context.mojom b/services/network/public/mojom/network_context.mojom -index 2c696bbb7863f02a93cacef0fd8780a5fa3ac040..73b790fab0f6c6377f8206960a478778ecf6e62c 100644 +index e0aab3e9ca6b7aad18d9e9c0f1df34f99fe4b7bc..64b71f2bce79b52c81717e8f5ce87d7b7aa86242 100644 --- a/services/network/public/mojom/network_context.mojom +++ b/services/network/public/mojom/network_context.mojom @@ -214,6 +214,17 @@ struct CTPolicy { diff --git a/patches/chromium/notification_provenance.patch b/patches/chromium/notification_provenance.patch index e31c47dcd75b8..4f3b7d36ca5bb 100644 --- a/patches/chromium/notification_provenance.patch +++ b/patches/chromium/notification_provenance.patch @@ -108,10 +108,10 @@ index 4bf25bf1fa69f7d3869369172d375e2e489e62a1..f80ef2cecc8b111dc54e109646573a59 mojo::PendingReceiver receiver); diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc -index 687698d6ff258a57e941805ef4d8fae4d36db612..f40f089582ff616ea54b7f44309e78515b5967f5 100644 +index 152e3ffeadeebcf54ac1b34a011dc2e87af7f094..d9f21680c7777622090dda2c10349b9fd47d83bc 100644 --- a/content/browser/renderer_host/render_process_host_impl.cc +++ b/content/browser/renderer_host/render_process_host_impl.cc -@@ -2144,7 +2144,7 @@ void RenderProcessHostImpl::CreateNotificationService( +@@ -2139,7 +2139,7 @@ void RenderProcessHostImpl::CreateNotificationService( mojo::PendingReceiver receiver) { DCHECK_CURRENTLY_ON(BrowserThread::UI); storage_partition_impl_->GetPlatformNotificationContext()->CreateService( diff --git a/patches/chromium/preconnect_feature.patch b/patches/chromium/preconnect_feature.patch index ba3c11a8accdf..393ff1774adf0 100644 --- a/patches/chromium/preconnect_feature.patch +++ b/patches/chromium/preconnect_feature.patch @@ -8,7 +8,7 @@ this patch removes that dependency so we can reuse it. Ideally we would change this class in upstream to not depend on Profile. diff --git a/chrome/browser/predictors/preconnect_manager.cc b/chrome/browser/predictors/preconnect_manager.cc -index e6524169e022c98d07ca29fa7988c22b06f0a2e1..199837a907a8b9df0ef7d2cb9b369503ab655bf6 100644 +index d7e470bbb181b2274584ffc14f2c26625b1d5794..78216f0083281b4f1e0209f766753d0dc9c796c4 100644 --- a/chrome/browser/predictors/preconnect_manager.cc +++ b/chrome/browser/predictors/preconnect_manager.cc @@ -68,7 +68,7 @@ PreresolveJob::PreresolveJob(PreresolveJob&& other) = default; @@ -20,7 +20,7 @@ index e6524169e022c98d07ca29fa7988c22b06f0a2e1..199837a907a8b9df0ef7d2cb9b369503 : delegate_(std::move(delegate)), profile_(profile), inflight_preresolves_count_(0) { -@@ -325,11 +325,13 @@ network::mojom::NetworkContext* PreconnectManager::GetNetworkContext() const { +@@ -327,11 +327,13 @@ network::mojom::NetworkContext* PreconnectManager::GetNetworkContext() const { if (network_context_) return network_context_; @@ -35,7 +35,7 @@ index e6524169e022c98d07ca29fa7988c22b06f0a2e1..199837a907a8b9df0ef7d2cb9b369503 return content::BrowserContext::GetDefaultStoragePartition(profile_) ->GetNetworkContext(); diff --git a/chrome/browser/predictors/preconnect_manager.h b/chrome/browser/predictors/preconnect_manager.h -index 7c99f4543095f600a5a7705846bc01f5656a9c8d..bbd62bccef6a3c5013c5f3ee4f24443835728d44 100644 +index 1cf8e9097afbec8905849ae0b885e9103d3aa1f1..7f51a419e47ab6a52573a7f3fdba016b4edfb07e 100644 --- a/chrome/browser/predictors/preconnect_manager.h +++ b/chrome/browser/predictors/preconnect_manager.h @@ -22,6 +22,10 @@ @@ -49,7 +49,7 @@ index 7c99f4543095f600a5a7705846bc01f5656a9c8d..bbd62bccef6a3c5013c5f3ee4f244438 namespace network { namespace mojom { class NetworkContext; -@@ -143,7 +147,7 @@ class PreconnectManager { +@@ -147,7 +151,7 @@ class PreconnectManager { static const size_t kMaxInflightPreresolves = 3; @@ -58,7 +58,7 @@ index 7c99f4543095f600a5a7705846bc01f5656a9c8d..bbd62bccef6a3c5013c5f3ee4f244438 virtual ~PreconnectManager(); // Starts preconnect and preresolve jobs keyed by |url|. -@@ -208,7 +212,7 @@ class PreconnectManager { +@@ -212,7 +216,7 @@ class PreconnectManager { network::mojom::NetworkContext* GetNetworkContext() const; base::WeakPtr delegate_; diff --git a/patches/chromium/printing.patch b/patches/chromium/printing.patch index 4e46f4d91ed6d..b83e250ed7a17 100644 --- a/patches/chromium/printing.patch +++ b/patches/chromium/printing.patch @@ -90,7 +90,7 @@ index bee0596550b52abd3fe233f779247256d4ad5123..43542c1a910830b0d610c27f269add66 } diff --git a/chrome/browser/printing/print_view_manager_base.cc b/chrome/browser/printing/print_view_manager_base.cc -index 8a743d0dd74b087059ff812019ae568a22c5fa01..551dbc7b0bfdbf4ca549278bb3dfc4e3abb5cf0f 100644 +index 37bdfd96667f1484bb1bec4057e544d263afb06d..73d96f066863b77f92f6232ce2d7b8ddd30fa6d2 100644 --- a/chrome/browser/printing/print_view_manager_base.cc +++ b/chrome/browser/printing/print_view_manager_base.cc @@ -27,10 +27,7 @@ @@ -432,10 +432,10 @@ index 9fbea6d0a2dbe55b1d600fbc217dee5aa8ae8cd5..de9bd267e408c02fd4da7d903523c0e6 // content::BrowserMessageFilter: bool OnMessageReceived(const IPC::Message& message) override; diff --git a/components/printing/common/print.mojom b/components/printing/common/print.mojom -index 033bd41f2ae9c4d072f951ba0d930adf69114176..21ad6a9c39e89f5cae83357c48a358e266e48306 100644 +index 8159a61d2707082461a419a344487bbd460a1d29..d5ef9c6a7064885deb7d27518448cc67b21f0b4a 100644 --- a/components/printing/common/print.mojom +++ b/components/printing/common/print.mojom -@@ -119,7 +119,7 @@ interface PrintPreviewUI { +@@ -121,7 +121,7 @@ interface PrintPreviewUI { interface PrintRenderFrame { // Tells the RenderFrame to switch the CSS to print media type, render every // requested page, and then switch back the CSS to display media type. @@ -445,7 +445,7 @@ index 033bd41f2ae9c4d072f951ba0d930adf69114176..21ad6a9c39e89f5cae83357c48a358e2 // Tells the RenderFrame to switch the CSS to print media type, render every // requested page using the print preview document's frame/node, and then diff --git a/components/printing/renderer/print_render_frame_helper.cc b/components/printing/renderer/print_render_frame_helper.cc -index 2a97938d20b69760b48c51a6712d646cd47339d7..fc39f8874402904021e804a5b7fc754709f25353 100644 +index 3fe2858af7b1f5c3ca45b9a421393dea31ca25a2..3d2938b8fe8552054684e9cc467ac5022d3ef83d 100644 --- a/components/printing/renderer/print_render_frame_helper.cc +++ b/components/printing/renderer/print_render_frame_helper.cc @@ -41,6 +41,7 @@ diff --git a/patches/chromium/put_back_deleted_colors_for_autofill.patch b/patches/chromium/put_back_deleted_colors_for_autofill.patch index 22c12003bb138..e7897f6f352be 100644 --- a/patches/chromium/put_back_deleted_colors_for_autofill.patch +++ b/patches/chromium/put_back_deleted_colors_for_autofill.patch @@ -42,7 +42,7 @@ index e4b9c5e52d6f8408f8ab5ab7c4f8b28466e04626..9c32aaaa0d88a692632a2e888250c6fd // TODO(thomasanderson): Render GtkSpinner directly. case ui::NativeTheme::kColorId_ThrobberSpinningColor: diff --git a/ui/native_theme/common_theme.cc b/ui/native_theme/common_theme.cc -index f8b36be425a78783a7ee8fb305d64a109f6c72fc..2227c81ef5878d687c125ae993c06700e5c131ef 100644 +index c0c37674e99b9d04c983dda8312433a37dbd5170..282bdb964cb4e3fb03d53768b3212fe2b84e3bd7 100644 --- a/ui/native_theme/common_theme.cc +++ b/ui/native_theme/common_theme.cc @@ -63,7 +63,8 @@ base::Optional GetHighContrastColor( @@ -70,7 +70,7 @@ index f8b36be425a78783a7ee8fb305d64a109f6c72fc..2227c81ef5878d687c125ae993c06700 // FocusableBorder case NativeTheme::kColorId_FocusedBorderColor: return SkColorSetA(gfx::kGoogleBlue300, 0x4D); -@@ -558,6 +567,18 @@ SkColor GetDefaultColor(NativeTheme::ColorId color_id, +@@ -560,6 +569,18 @@ SkColor GetDefaultColor(NativeTheme::ColorId color_id, case NativeTheme::kColorId_UnfocusedBorderColor: return gfx::kGoogleGrey300; @@ -89,7 +89,7 @@ index f8b36be425a78783a7ee8fb305d64a109f6c72fc..2227c81ef5878d687c125ae993c06700 // Material spinner/throbber case NativeTheme::kColorId_ThrobberSpinningColor: return gfx::kGoogleBlue600; -@@ -661,7 +682,7 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id, +@@ -663,7 +684,7 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id, } if (color_scheme == NativeTheme::ColorScheme::kDark) { @@ -99,10 +99,10 @@ index f8b36be425a78783a7ee8fb305d64a109f6c72fc..2227c81ef5878d687c125ae993c06700 return color.value(); } diff --git a/ui/native_theme/native_theme_color_id.h b/ui/native_theme/native_theme_color_id.h -index 739c28d17cae9f5150539ada37533a49c8526963..b2a0fc2fc8278936c9eda48b6056cb0ce97412b4 100644 +index dde0f977c676b6914f206ca7022290887257622b..67fe14f482dcbdf884711e3b283f9d6107a6cfe6 100644 --- a/ui/native_theme/native_theme_color_id.h +++ b/ui/native_theme/native_theme_color_id.h -@@ -145,6 +145,11 @@ +@@ -146,6 +146,11 @@ OP(kColorId_TableHeaderText), \ OP(kColorId_TableHeaderBackground), \ OP(kColorId_TableHeaderSeparator), \ diff --git a/patches/chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch b/patches/chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch index 175ea9c80f3b6..d8d1ef178b9c0 100644 --- a/patches/chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch +++ b/patches/chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch @@ -30,10 +30,10 @@ index 1feca3a3d2d13278a8c11038177caa661cbab22c..1ca75dc4b5228077f6658919b36004bc // RenderWidgetHost on the main frame, and false otherwise. virtual bool IsWidgetForMainFrame(RenderWidgetHostImpl*); diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc -index 1bb34b1700fe89053f78bcecd35af898938620b8..bf651c33e255c9f7eb7df1f96d21232e7033c37c 100644 +index 6c729512a82fc384200565bd427e0c3065ed9d28..5f447cd63fed0f0061df5f80dffb9ee60436319d 100644 --- a/content/browser/renderer_host/render_widget_host_impl.cc +++ b/content/browser/renderer_host/render_widget_host_impl.cc -@@ -1690,6 +1690,8 @@ void RenderWidgetHostImpl::SetCursor(const WebCursor& cursor) { +@@ -1695,6 +1695,8 @@ void RenderWidgetHostImpl::SetCursor(const WebCursor& cursor) { if (!view_) return; view_->UpdateCursor(cursor); @@ -43,10 +43,10 @@ index 1bb34b1700fe89053f78bcecd35af898938620b8..bf651c33e255c9f7eb7df1f96d21232e void RenderWidgetHostImpl::OnCursorVisibilityStateChanged(bool is_visible) { diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc -index 9d7b90476a680d44fdb903a15c1ebea0e23053c7..ac667785814e3966c8a65a96f2456846fd956366 100644 +index a5d5821b4de14533c286329639e3729de1e20c06..4833c199ab5a0dbc01b94726b36b3b245371df43 100644 --- a/content/browser/web_contents/web_contents_impl.cc +++ b/content/browser/web_contents/web_contents_impl.cc -@@ -3580,6 +3580,11 @@ bool WebContentsImpl::OnUpdateDragCursor() { +@@ -3603,6 +3603,11 @@ bool WebContentsImpl::OnUpdateDragCursor() { browser_plugin_embedder_->OnUpdateDragCursor(); } @@ -59,10 +59,10 @@ index 9d7b90476a680d44fdb903a15c1ebea0e23053c7..ac667785814e3966c8a65a96f2456846 RenderWidgetHostImpl* render_widget_host) { return render_widget_host == GetMainFrame()->GetRenderWidgetHost(); diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h -index bb70f5e65f3dc30846d13ff2c31eb22666ef7500..72046a84e4f307acf25752f498893391508a0b96 100644 +index 94e5e22baed0daa670c5ee0d9f076e62a446126a..ae5e186c9db92d36dc68a7f50905ac2cb3bfc55e 100644 --- a/content/browser/web_contents/web_contents_impl.h +++ b/content/browser/web_contents/web_contents_impl.h -@@ -925,6 +925,7 @@ class CONTENT_EXPORT WebContentsImpl : public WebContents, +@@ -926,6 +926,7 @@ class CONTENT_EXPORT WebContentsImpl : public WebContents, void SendScreenRects() override; TextInputManager* GetTextInputManager() override; bool OnUpdateDragCursor() override; @@ -71,7 +71,7 @@ index bb70f5e65f3dc30846d13ff2c31eb22666ef7500..72046a84e4f307acf25752f498893391 bool AddDomainInfoToRapporSample(rappor::Sample* sample) override; bool IsShowingContextMenuOnPage() const override; diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h -index 0f63f2ede488d931b95b523fc505aa307bc95088..639ec61d05ee1f739304ddcca04a982daca2f558 100644 +index a6e33a28ca421f0d022975f66f579746f9e60ba6..5c8a0d3be3714981a5119aefa1de38d38596fd63 100644 --- a/content/public/browser/web_contents_observer.h +++ b/content/public/browser/web_contents_observer.h @@ -14,6 +14,7 @@ diff --git a/patches/chromium/remove_some_deps_that_do_not_work_on_arm64.patch b/patches/chromium/remove_some_deps_that_do_not_work_on_arm64.patch index 0b6409263d2f7..0ea36aec0c1db 100644 --- a/patches/chromium/remove_some_deps_that_do_not_work_on_arm64.patch +++ b/patches/chromium/remove_some_deps_that_do_not_work_on_arm64.patch @@ -6,7 +6,7 @@ Subject: remove some deps that do not work on arm64 Once these deps have been fixed upstream we can remove this patch. diff --git a/.vpython b/.vpython -index 0a28e76064296edea609eb52e57555689c23c0a3..bea6a9b7ee4b64dcc44b6f345a83e28d1d22649c 100644 +index 27117b1372b9a002672161f9c1fe3c1a14448c7d..5d330c75ca24863c0aa0e596ab66c48f65541c34 100644 --- a/.vpython +++ b/.vpython @@ -53,10 +53,10 @@ wheel: < @@ -23,8 +23,8 @@ index 0a28e76064296edea609eb52e57555689c23c0a3..bea6a9b7ee4b64dcc44b6f345a83e28d +#> # Used by: - # third_party/catapult -@@ -67,37 +67,37 @@ wheel: < + # build/lacros/test_runner.py +@@ -74,37 +74,37 @@ wheel: < # This version must also be compatible with the "numpy" version, as "cv2" # depends on "numpy". In this case, OpenCV@2.4.13.2 has been built against # numpy@1.11.3. @@ -87,7 +87,7 @@ index 0a28e76064296edea609eb52e57555689c23c0a3..bea6a9b7ee4b64dcc44b6f345a83e28d # Used by: # third_party/catapult -@@ -132,10 +132,10 @@ wheel: < +@@ -139,10 +139,10 @@ wheel: < # Used by: # testing/buildbot/generate_buildbot_json_coveragetest.py @@ -102,7 +102,7 @@ index 0a28e76064296edea609eb52e57555689c23c0a3..bea6a9b7ee4b64dcc44b6f345a83e28d # Used by: # build/android/pylib/local/emulator/avd.py -@@ -166,27 +166,27 @@ wheel: < +@@ -173,27 +173,27 @@ wheel: < # Used by: # tools/perf/flakiness_cli @@ -151,7 +151,7 @@ index 0a28e76064296edea609eb52e57555689c23c0a3..bea6a9b7ee4b64dcc44b6f345a83e28d wheel: < name: "infra/python/wheels/pytz-py2_py3" version: "version:2018.4" -@@ -268,10 +268,10 @@ wheel < +@@ -275,10 +275,10 @@ wheel < name: "infra/python/wheels/funcsigs-py2_py3" version: "version:1.0.2" > diff --git a/patches/chromium/render_widget_host_view_base.patch b/patches/chromium/render_widget_host_view_base.patch index 203e1983bdbbf..707b34923c9f4 100644 --- a/patches/chromium/render_widget_host_view_base.patch +++ b/patches/chromium/render_widget_host_view_base.patch @@ -6,7 +6,7 @@ Subject: render_widget_host_view_base.patch ... something to do with OSR? and maybe as well? terrifying. diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc -index 85b265f70047f90ebb8a4a2ef2487adc62f0ade9..b41d39c8ced77266955e301af19dcac9945b33bf 100644 +index 4482c6df317c30249e2908ed5c4fce85be92db92..b5c5dbd3f09a63f5b98a807f17479cb1250ed5e2 100644 --- a/content/browser/renderer_host/render_widget_host_view_base.cc +++ b/content/browser/renderer_host/render_widget_host_view_base.cc @@ -624,6 +624,13 @@ bool RenderWidgetHostViewBase::ScreenRectIsUnstableFor( @@ -24,7 +24,7 @@ index 85b265f70047f90ebb8a4a2ef2487adc62f0ade9..b41d39c8ced77266955e301af19dcac9 const blink::WebMouseEvent& event, const ui::LatencyInfo& latency) { diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h -index 8188ba42eb88ea8faf3fa3d03a3018e966880bf6..2d710bb3f712b5d93ea95e93be34f91e9b730387 100644 +index 11ff9718896cd064300759d3aa139c2de4146405..9d041ae39cf6530fcc16fceff766e08693738ab0 100644 --- a/content/browser/renderer_host/render_widget_host_view_base.h +++ b/content/browser/renderer_host/render_widget_host_view_base.h @@ -25,9 +25,11 @@ @@ -37,9 +37,9 @@ index 8188ba42eb88ea8faf3fa3d03a3018e966880bf6..2d710bb3f712b5d93ea95e93be34f91e #include "content/public/browser/render_frame_metadata_provider.h" +#include "content/public/browser/render_widget_host.h" #include "content/public/browser/render_widget_host_view.h" - #include "content/public/common/screen_info.h" #include "content/public/common/widget_type.h" -@@ -67,9 +69,11 @@ class CursorManager; + #include "services/viz/public/mojom/hit_test/hit_test_region_list.mojom.h" +@@ -65,9 +67,11 @@ class CursorManager; class MouseWheelPhaseHandler; class RenderWidgetHostImpl; class RenderWidgetHostViewBaseObserver; @@ -51,7 +51,7 @@ index 8188ba42eb88ea8faf3fa3d03a3018e966880bf6..2d710bb3f712b5d93ea95e93be34f91e class WebCursor; class DelegatedFrameHost; struct DisplayFeature; -@@ -127,6 +131,9 @@ class CONTENT_EXPORT RenderWidgetHostViewBase +@@ -125,6 +129,9 @@ class CONTENT_EXPORT RenderWidgetHostViewBase bool show_reason_unoccluded, bool show_reason_bfcache_restore) final; @@ -61,7 +61,7 @@ index 8188ba42eb88ea8faf3fa3d03a3018e966880bf6..2d710bb3f712b5d93ea95e93be34f91e // This only needs to be overridden by RenderWidgetHostViewBase subclasses // that handle content embedded within other RenderWidgetHostViews. gfx::PointF TransformPointToRootCoordSpaceF( -@@ -311,6 +318,11 @@ class CONTENT_EXPORT RenderWidgetHostViewBase +@@ -309,6 +316,11 @@ class CONTENT_EXPORT RenderWidgetHostViewBase virtual void ProcessGestureEvent(const blink::WebGestureEvent& event, const ui::LatencyInfo& latency); diff --git a/patches/chromium/revert_remove_contentrendererclient_shouldfork.patch b/patches/chromium/revert_remove_contentrendererclient_shouldfork.patch index 3a1c9c60cca2d..eb955e98901b1 100644 --- a/patches/chromium/revert_remove_contentrendererclient_shouldfork.patch +++ b/patches/chromium/revert_remove_contentrendererclient_shouldfork.patch @@ -9,7 +9,7 @@ for every navigation to keep Node.js working properly. Once Native Modules in th are required to be NAPI or context aware (Electron v11), this patch can be removed. diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc -index 018bffa3424c8a7312eeec18dc1b4ed144519413..955d105f6729654878b6a905ca202fb6522d0101 100644 +index 85c7cca6f069202a9de00cedc480e94209350425..29c383071229da71af3592293a8e237baa73c1bb 100644 --- a/chrome/renderer/chrome_content_renderer_client.cc +++ b/chrome/renderer/chrome_content_renderer_client.cc @@ -1312,6 +1312,25 @@ bool ChromeContentRendererClient::AllowPopup() { @@ -92,10 +92,10 @@ index cc6101c82e659bbc5a8568c166d5a56fae0c8d64..8309bb7f3f284b0930c13a7e75a7f9de // |url|. If the function returns a valid |new_url|, the request must be // updated to use it. The |force_ignore_site_for_cookies| output parameter diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc -index f7d78b305bccfdb69c20261010824bae6758b5c3..4ece705b8085d1da1f066e7cb988ded642e3a437 100644 +index 899c4265fe65fc8dbd3d2e621b801635ae0efbb1..1935b892de9dfc7c0ca14255aadaab4c6e92aa13 100644 --- a/content/renderer/render_frame_impl.cc +++ b/content/renderer/render_frame_impl.cc -@@ -5523,6 +5523,23 @@ void RenderFrameImpl::BeginNavigation( +@@ -5534,6 +5534,23 @@ void RenderFrameImpl::BeginNavigation( // we can do a per-frame check here rather than a process-wide check. bool should_fork = HasWebUIScheme(url) || HasWebUIScheme(old_url) || (enabled_bindings_ & kWebUIBindingsPolicyMask); diff --git a/patches/chromium/revert_swiftshader_roll_in_deps.patch b/patches/chromium/revert_swiftshader_roll_in_deps.patch new file mode 100644 index 0000000000000..c60107447a32f --- /dev/null +++ b/patches/chromium/revert_swiftshader_roll_in_deps.patch @@ -0,0 +1,40 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Shelley Vohr +Date: Mon, 20 Jul 2020 19:27:57 -0700 +Subject: Revert swiftshader roll in DEPS + +https://chromium-review.googlesource.com/c/chromium/src/+/2304381 and +https://chromium-review.googlesource.com/c/chromium/src/+/2306053 +rolled swiftshader to ea6f21a052c9 and caused a breakage in arm64 jobs +on macOS: + +Undefined symbols for architecture arm64: + "llvm::sys::RWMutexImpl::lock_shared()", referenced from: + llvm::sys::SmartRWMutex::lock_shared() in PassRegistry.o + "llvm::sys::RWMutexImpl::unlock_shared()", referenced from: + llvm::sys::SmartRWMutex::unlock_shared() in PassRegistry.o + "llvm::sys::RWMutexImpl::lock()", referenced from: + llvm::sys::SmartRWMutex::lock() in PassRegistry.o + "llvm::sys::RWMutexImpl::unlock()", referenced from: + llvm::sys::SmartRWMutex::unlock() in PassRegistry.o + "llvm::sys::RWMutexImpl::RWMutexImpl()", referenced from: + llvm::object_creator::call() in PassRegistry.o + "llvm::sys::RWMutexImpl::~RWMutexImpl()", referenced from: + llvm::PassRegistry::~PassRegistry() in PassRegistry.o +ld: symbol(s) not found for architecture arm64 + +Tracking bug at: crbug.com/1107706 + +diff --git a/DEPS b/DEPS +index bb6d0251a8c42c60dafdc39632aed21104b86545..881c014addcba1a1e36d69bf8d3637a487b0fe21 100644 +--- a/DEPS ++++ b/DEPS +@@ -211,7 +211,7 @@ vars = { + # Three lines of non-changing comments so that + # the commit queue can handle CLs rolling SwiftShader + # and whatever else without interference from each other. +- 'swiftshader_revision': '97f9923235cf5a24d8ce49f93bd22429d2a68548', ++ 'swiftshader_revision': 'e8dd233c7a85f3c689caf06c226a7f8405a480d3', + # Three lines of non-changing comments so that + # the commit queue can handle CLs rolling PDFium + # and whatever else without interference from each other. diff --git a/patches/chromium/skip_atk_toolchain_check.patch b/patches/chromium/skip_atk_toolchain_check.patch new file mode 100644 index 0000000000000..df833d523303b --- /dev/null +++ b/patches/chromium/skip_atk_toolchain_check.patch @@ -0,0 +1,35 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: John Kleinschmidt +Date: Wed, 15 Jul 2020 17:52:32 -0400 +Subject: skip atk toolchain check + +this patch is needed to work around the following gn error on +Linux arm/arm64: + +ERROR at //build/config/linux/atk/BUILD.gn:13:1: Assertion failed. + +assert(current_toolchain == default_toolchain) + +^----- + +See //ui/accessibility/BUILD.gn:297:20: which caused the file to be included. + + configs += [ "//build/config/linux/atk" ] + + ^------------------------- +"//build/config/linux/atk" is only needed for accessibility unit tests +which we don't build + +diff --git a/build/config/linux/atk/BUILD.gn b/build/config/linux/atk/BUILD.gn +index aad2efa60d6c9b555e5679e9883e0f10bf8b0008..db083cd0c0ed9a846bbe827efc4783637439be7b 100644 +--- a/build/config/linux/atk/BUILD.gn ++++ b/build/config/linux/atk/BUILD.gn +@@ -10,7 +10,7 @@ import("//build/config/ui.gni") + assert(!is_chromeos) + + # These packages should _only_ be expected when building for a target. +-assert(current_toolchain == default_toolchain) ++#assert(current_toolchain == default_toolchain) + + if (use_atk) { + assert(use_glib, "use_atk=true requires that use_glib=true") diff --git a/patches/chromium/ssl_security_state_tab_helper.patch b/patches/chromium/ssl_security_state_tab_helper.patch index 7542e6e4d407b..b23b38ce431b2 100644 --- a/patches/chromium/ssl_security_state_tab_helper.patch +++ b/patches/chromium/ssl_security_state_tab_helper.patch @@ -6,10 +6,17 @@ Subject: ssl_security_state_tab_helper.patch Allows populating security tab info for devtools in Electron. diff --git a/chrome/browser/ssl/security_state_tab_helper.cc b/chrome/browser/ssl/security_state_tab_helper.cc -index 16d1ca932afddc1f2502e99384141b0814beb75c..8c91f5943228083f375d1e668acb9e5b75230232 100644 +index 16d1ca932afddc1f2502e99384141b0814beb75c..8370d59e30fac2a416879aa9798be43f72fd5d90 100644 --- a/chrome/browser/ssl/security_state_tab_helper.cc +++ b/chrome/browser/ssl/security_state_tab_helper.cc -@@ -13,22 +13,26 @@ +@@ -7,28 +7,33 @@ + #include + + #include "base/bind.h" ++#include "base/command_line.h" + #include "base/feature_list.h" + #include "base/metrics/field_trial_params.h" + #include "base/metrics/histogram_macros.h" #include "base/strings/pattern.h" #include "base/strings/string_util.h" #include "build/build_config.h" @@ -37,7 +44,7 @@ index 16d1ca932afddc1f2502e99384141b0814beb75c..8c91f5943228083f375d1e668acb9e5b #include "components/security_state/content/content_utils.h" #include "content/public/browser/browser_context.h" #include "content/public/browser/navigation_entry.h" -@@ -51,7 +55,7 @@ +@@ -51,7 +56,7 @@ #include "chrome/browser/chromeos/policy/policy_cert_service_factory.h" #endif // defined(OS_CHROMEOS) @@ -46,7 +53,7 @@ index 16d1ca932afddc1f2502e99384141b0814beb75c..8c91f5943228083f375d1e668acb9e5b #include "chrome/browser/safe_browsing/chrome_password_protection_service.h" #endif -@@ -95,9 +99,12 @@ bool IsLegacyTLS(GURL url, int connection_status) { +@@ -95,9 +100,12 @@ bool IsLegacyTLS(GURL url, int connection_status) { // default we treat TLS < 1.2 as Legacy, unless the "SSLVersionMin" policy is // set. std::string ssl_version_min_str = switches::kSSLVersionTLSv12; @@ -62,7 +69,7 @@ index 16d1ca932afddc1f2502e99384141b0814beb75c..8c91f5943228083f375d1e668acb9e5b } // Convert the pref string to an SSLVersion, if it is valid. Otherwise use the -@@ -117,8 +124,9 @@ bool IsLegacyTLS(GURL url, int connection_status) { +@@ -117,8 +125,9 @@ bool IsLegacyTLS(GURL url, int connection_status) { } // namespace @@ -73,7 +80,7 @@ index 16d1ca932afddc1f2502e99384141b0814beb75c..8c91f5943228083f375d1e668acb9e5b SecurityStateTabHelper::SecurityStateTabHelper( content::WebContents* web_contents) -@@ -164,6 +172,7 @@ SecurityStateTabHelper::GetVisibleSecurityState() { +@@ -164,6 +173,7 @@ SecurityStateTabHelper::GetVisibleSecurityState() { // information is still being initialized, thus no need to check for that. state->malicious_content_status = GetMaliciousContentStatus(); @@ -81,7 +88,7 @@ index 16d1ca932afddc1f2502e99384141b0814beb75c..8c91f5943228083f375d1e668acb9e5b ReputationWebContentsObserver* reputation_web_contents_observer = ReputationWebContentsObserver::FromWebContents(web_contents()); state->safety_tip_info = -@@ -172,7 +181,7 @@ SecurityStateTabHelper::GetVisibleSecurityState() { +@@ -172,7 +182,7 @@ SecurityStateTabHelper::GetVisibleSecurityState() { ->GetSafetyTipInfoForVisibleNavigation() : security_state::SafetyTipInfo( {security_state::SafetyTipStatus::kUnknown, GURL()}); @@ -90,7 +97,7 @@ index 16d1ca932afddc1f2502e99384141b0814beb75c..8c91f5943228083f375d1e668acb9e5b return state; } -@@ -235,8 +244,10 @@ void SecurityStateTabHelper::DidFinishNavigation( +@@ -235,8 +245,10 @@ void SecurityStateTabHelper::DidFinishNavigation( UMA_HISTOGRAM_BOOLEAN("interstitial.ssl.visited_site_after_warning", true); } @@ -101,7 +108,7 @@ index 16d1ca932afddc1f2502e99384141b0814beb75c..8c91f5943228083f375d1e668acb9e5b } void SecurityStateTabHelper::DidChangeVisibleSecurityState() { -@@ -260,6 +271,7 @@ SecurityStateTabHelper::GetMaliciousContentStatus() const { +@@ -260,6 +272,7 @@ SecurityStateTabHelper::GetMaliciousContentStatus() const { web_contents()->GetController().GetVisibleEntry(); if (!entry) return security_state::MALICIOUS_CONTENT_STATUS_NONE; @@ -109,7 +116,7 @@ index 16d1ca932afddc1f2502e99384141b0814beb75c..8c91f5943228083f375d1e668acb9e5b safe_browsing::SafeBrowsingService* sb_service = g_browser_process->safe_browsing_service(); if (!sb_service) -@@ -342,6 +354,7 @@ SecurityStateTabHelper::GetMaliciousContentStatus() const { +@@ -342,6 +355,7 @@ SecurityStateTabHelper::GetMaliciousContentStatus() const { break; } } diff --git a/patches/chromium/support_mixed_sandbox_with_zygote.patch b/patches/chromium/support_mixed_sandbox_with_zygote.patch index 927d429e253ba..3a8d51e42f26e 100644 --- a/patches/chromium/support_mixed_sandbox_with_zygote.patch +++ b/patches/chromium/support_mixed_sandbox_with_zygote.patch @@ -22,10 +22,10 @@ However, the patch would need to be reviewed by the security team, as it does touch a security-sensitive class. diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc -index f40f089582ff616ea54b7f44309e78515b5967f5..0cd572d4793ebe72ce576000ffbc302aa703b58c 100644 +index d9f21680c7777622090dda2c10349b9fd47d83bc..f3b77a295f334ffa696f1085a4ca5c0c86479987 100644 --- a/content/browser/renderer_host/render_process_host_impl.cc +++ b/content/browser/renderer_host/render_process_host_impl.cc -@@ -413,6 +413,11 @@ class RendererSandboxedProcessLauncherDelegate +@@ -411,6 +411,11 @@ class RendererSandboxedProcessLauncherDelegate { } @@ -37,7 +37,7 @@ index f40f089582ff616ea54b7f44309e78515b5967f5..0cd572d4793ebe72ce576000ffbc302a ~RendererSandboxedProcessLauncherDelegate() override {} #if defined(OS_WIN) -@@ -434,6 +439,9 @@ class RendererSandboxedProcessLauncherDelegate +@@ -432,6 +437,9 @@ class RendererSandboxedProcessLauncherDelegate #if BUILDFLAG(USE_ZYGOTE_HANDLE) ZygoteHandle GetZygote() override { @@ -47,7 +47,7 @@ index f40f089582ff616ea54b7f44309e78515b5967f5..0cd572d4793ebe72ce576000ffbc302a const base::CommandLine& browser_command_line = *base::CommandLine::ForCurrentProcess(); base::CommandLine::StringType renderer_prefix = -@@ -448,10 +456,13 @@ class RendererSandboxedProcessLauncherDelegate +@@ -446,10 +454,13 @@ class RendererSandboxedProcessLauncherDelegate return sandbox::policy::SandboxType::kRenderer; } @@ -62,7 +62,7 @@ index f40f089582ff616ea54b7f44309e78515b5967f5..0cd572d4793ebe72ce576000ffbc302a }; const char kSessionStorageHolderKey[] = "kSessionStorageHolderKey"; -@@ -1858,11 +1869,18 @@ bool RenderProcessHostImpl::Init() { +@@ -1853,11 +1864,18 @@ bool RenderProcessHostImpl::Init() { cmd_line->PrependWrapper(renderer_prefix); AppendRendererCommandLine(cmd_line.get()); diff --git a/patches/chromium/use_electron_resources_in_pdf_util.patch b/patches/chromium/use_electron_resources_in_pdf_util.patch index 7d028ee0fcf26..da0ffc8bb187c 100644 --- a/patches/chromium/use_electron_resources_in_pdf_util.patch +++ b/patches/chromium/use_electron_resources_in_pdf_util.patch @@ -8,7 +8,7 @@ and cause a DCHECK(), since the resource will be loaded as an empty string. diff --git a/chrome/browser/pdf/pdf_extension_util.cc b/chrome/browser/pdf/pdf_extension_util.cc -index 9fd9791fd923d6c5e741cb7dc064ababf9a7995a..0a5534f2f09224196971076794daa3c805c91606 100644 +index 2ad8be8384f0d736ccac504114aba63babe8e67b..28639c00d1700f1fa307090d494904701805a2d9 100644 --- a/chrome/browser/pdf/pdf_extension_util.cc +++ b/chrome/browser/pdf/pdf_extension_util.cc @@ -8,7 +8,7 @@ diff --git a/patches/chromium/web_contents.patch b/patches/chromium/web_contents.patch index 9b53753b122e8..95764b38fc0c8 100644 --- a/patches/chromium/web_contents.patch +++ b/patches/chromium/web_contents.patch @@ -9,10 +9,10 @@ is needed for OSR. Originally landed in https://github.com/electron/libchromiumcontent/pull/226. diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc -index e555eddccb83b91754ba95f9a2545019e6b66e1c..9d7b90476a680d44fdb903a15c1ebea0e23053c7 100644 +index 6a30734d3314041af985a1f9056595a23a10d6a9..a5d5821b4de14533c286329639e3729de1e20c06 100644 --- a/content/browser/web_contents/web_contents_impl.cc +++ b/content/browser/web_contents/web_contents_impl.cc -@@ -2219,6 +2219,12 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) { +@@ -2232,6 +2232,12 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) { std::string unique_name; frame_tree_.root()->SetFrameName(params.main_frame_name, unique_name); @@ -25,7 +25,7 @@ index e555eddccb83b91754ba95f9a2545019e6b66e1c..9d7b90476a680d44fdb903a15c1ebea0 WebContentsViewDelegate* delegate = GetContentClient()->browser()->GetWebContentsViewDelegate(this); -@@ -2229,6 +2235,7 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) { +@@ -2242,6 +2248,7 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) { view_.reset(CreateWebContentsView(this, delegate, &render_view_host_delegate_view_)); } @@ -34,7 +34,7 @@ index e555eddccb83b91754ba95f9a2545019e6b66e1c..9d7b90476a680d44fdb903a15c1ebea0 CHECK(view_.get()); diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h -index 411145b6e24b0017a67ec6d97b6ebd0d1c54c9f3..a2dff8b0cad2ee423f5365ff62f93ac5fccfaa93 100644 +index f8fa0e63d7262a810dfffd08a45318ed45a66b15..17bf06d360fd5d7cbb49e64fa5b99c00267af630 100644 --- a/content/public/browser/web_contents.h +++ b/content/public/browser/web_contents.h @@ -82,8 +82,11 @@ class BrowserContext; diff --git a/patches/chromium/webview_cross_drag.patch b/patches/chromium/webview_cross_drag.patch index 94843102d181e..4092c236846ab 100644 --- a/patches/chromium/webview_cross_drag.patch +++ b/patches/chromium/webview_cross_drag.patch @@ -8,7 +8,7 @@ This allows dragging and dropping between s. Originally landed in https://github.com/electron/libchromiumcontent/pull/267 diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc -index b332c568cb33544ef37c8d149ec36127571696bc..92049b3fb017013ad8afb4a7b89d71fba6fe920b 100644 +index cc6dabc489b33f54bb6ed5f389937b246f1d3612..26335e2662912ddc84ceca6f649b2206262ca29c 100644 --- a/content/browser/web_contents/web_contents_view_aura.cc +++ b/content/browser/web_contents/web_contents_view_aura.cc @@ -789,9 +789,7 @@ gfx::NativeView WebContentsViewAura::GetRenderWidgetHostViewParent() const { diff --git a/patches/chromium/worker_context_will_destroy.patch b/patches/chromium/worker_context_will_destroy.patch index 9847f089884e3..1aa86b0f2c2cb 100644 --- a/patches/chromium/worker_context_will_destroy.patch +++ b/patches/chromium/worker_context_will_destroy.patch @@ -26,10 +26,10 @@ index 5b0784c844bd9dd448c4e660d85902f930851b72..cc6101c82e659bbc5a8568c166d5a56f // An empty URL is returned if the URL is not overriden. virtual GURL OverrideFlashEmbedWithHTML(const GURL& url); diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer/renderer_blink_platform_impl.cc -index f74d5d12e449bf1c816743fb5fda29abb780b7ff..202490a1304f5b5356b010920a9d142564f82cc4 100644 +index 660a36f9251a1ef98d5ed08d65f9c512eaf0e95d..906e86480872394d33608a954440cbc92273d0ff 100644 --- a/content/renderer/renderer_blink_platform_impl.cc +++ b/content/renderer/renderer_blink_platform_impl.cc -@@ -864,6 +864,12 @@ void RendererBlinkPlatformImpl::WillStopWorkerThread() { +@@ -865,6 +865,12 @@ void RendererBlinkPlatformImpl::WillStopWorkerThread() { WorkerThreadRegistry::Instance()->WillStopCurrentWorkerThread(); } @@ -43,10 +43,10 @@ index f74d5d12e449bf1c816743fb5fda29abb780b7ff..202490a1304f5b5356b010920a9d1425 const v8::Local& worker) { GetContentClient()->renderer()->DidInitializeWorkerContextOnWorkerThread( diff --git a/content/renderer/renderer_blink_platform_impl.h b/content/renderer/renderer_blink_platform_impl.h -index 83d6f879da9db74bd1cd14761f38e1c81feb7ed2..263641805d91b1ba131eaba4fd07774f6f8ea38d 100644 +index bb40ad48a84bcc370caee10c53364a2633004ee1..db58cb0be064b7944b17dd12f1d1e6c12cecfff7 100644 --- a/content/renderer/renderer_blink_platform_impl.h +++ b/content/renderer/renderer_blink_platform_impl.h -@@ -192,6 +192,7 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl { +@@ -191,6 +191,7 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl { void DidStartWorkerThread() override; void WillStopWorkerThread() override; void WorkerContextCreated(const v8::Local& worker) override; diff --git a/patches/node/build_add_gn_build_files.patch b/patches/node/build_add_gn_build_files.patch index f032deea4768b..9d77f52e0baab 100644 --- a/patches/node/build_add_gn_build_files.patch +++ b/patches/node/build_add_gn_build_files.patch @@ -7,10 +7,10 @@ This adds GN build files for Node, so we don't have to build with GYP. diff --git a/BUILD.gn b/BUILD.gn new file mode 100644 -index 0000000000000000000000000000000000000000..b5ea846fd9fd46f34dd4260b67282186fddbc0be +index 0000000000000000000000000000000000000000..99192976f2bdfd900240aa58b8989fe2c9d8c771 --- /dev/null +++ b/BUILD.gn -@@ -0,0 +1,360 @@ +@@ -0,0 +1,361 @@ +import("//electron/build/asar.gni") +import("//v8/gni/v8.gni") + @@ -223,6 +223,7 @@ index 0000000000000000000000000000000000000000..b5ea846fd9fd46f34dd4260b67282186 + public_configs = [ ":node_lib_config" ] + include_dirs = [ "src" ] + libs = [] ++ frameworks = [] + cflags_cc = [ + "-Wno-deprecated-declarations", + "-Wno-implicit-fallthrough", @@ -251,7 +252,7 @@ index 0000000000000000000000000000000000000000..b5ea846fd9fd46f34dd4260b67282186 + libs += [ "psapi.lib" ] + } + if (is_mac) { -+ libs += [ "CoreFoundation.framework" ] ++ frameworks += [ "CoreFoundation.framework" ] + } + + if (node_enable_inspector) { diff --git a/patches/squirrel.mac/build_add_gn_config.patch b/patches/squirrel.mac/build_add_gn_config.patch index f15773444d5cf..e63b953497b1a 100644 --- a/patches/squirrel.mac/build_add_gn_config.patch +++ b/patches/squirrel.mac/build_add_gn_config.patch @@ -23,7 +23,7 @@ index 89c499e451ecb48655cfd42b01ffa1da56998c2e..98f80aad43a87ed75ca1660ad6a178db +vendor diff --git a/BUILD.gn b/BUILD.gn new file mode 100644 -index 0000000000000000000000000000000000000000..a259f5d9a70686f01b32e08c1d8337c46d3a4704 +index 0000000000000000000000000000000000000000..449c8ccd5ebf37aeb4f61754d9d5ea3c25b22d23 --- /dev/null +++ b/BUILD.gn @@ -0,0 +1,236 @@ @@ -57,7 +57,7 @@ index 0000000000000000000000000000000000000000..a259f5d9a70686f01b32e08c1d8337c4 + configs += [ "//build/config/compiler:no_chromium_code" ] + public_deps = [ ":mantle_headers" ] + deps = [] -+ libs = [ ++ frameworks = [ + "CoreData.framework", + "Foundation.framework", + ] @@ -131,7 +131,7 @@ index 0000000000000000000000000000000000000000..a259f5d9a70686f01b32e08c1d8337c4 + ":reactiveobjc_headers", + ":reactiveobjc_signalprovider_dtrace", + ] -+ libs = [ ++ frameworks = [ + "AppKit.framework", + "Foundation.framework", + ] @@ -180,7 +180,7 @@ index 0000000000000000000000000000000000000000..a259f5d9a70686f01b32e08c1d8337c4 + ":mantle_framework+link", + ":reactiveobjc_framework+link", + ] -+ libs = [ ++ frameworks = [ + "AppKit.framework", + "Foundation.framework", + "IOKit.framework", @@ -244,7 +244,7 @@ index 0000000000000000000000000000000000000000..a259f5d9a70686f01b32e08c1d8337c4 + ":mantle_framework+link", + ":reactiveobjc_framework+link", + ] -+ libs = [ ++ frameworks = [ + "AppKit.framework", + "Foundation.framework", + "IOKit.framework", diff --git a/patches/v8/add_realloc.patch b/patches/v8/add_realloc.patch index 725751e97c832..4282f8f63a805 100644 --- a/patches/v8/add_realloc.patch +++ b/patches/v8/add_realloc.patch @@ -12,7 +12,7 @@ when we override ReallocateBufferMemory, so we therefore need to implement Realloc on the v8 side. diff --git a/include/v8.h b/include/v8.h -index ce0be64bd55112382903a2565e67ecd2a1d9c0b6..1273dc87d98a22bb9d1e824f101f3a21bf50f4c6 100644 +index 4db319871f891f94b3c7c46fcd3742dc47c78f57..03f14309787f5963ba263739c9104e2b267ec202 100644 --- a/include/v8.h +++ b/include/v8.h @@ -5068,6 +5068,13 @@ class V8_EXPORT ArrayBuffer : public Object { @@ -30,7 +30,7 @@ index ce0be64bd55112382903a2565e67ecd2a1d9c0b6..1273dc87d98a22bb9d1e824f101f3a21 * Free the memory block of size |length|, pointed to by |data|. * That memory is guaranteed to be previously allocated by |Allocate|. diff --git a/src/api/api.cc b/src/api/api.cc -index 4e104ab2b661e3d69df3acd689bc9b36261a80f0..8948794fbac1095f34cdeccc00ec67eedc4458eb 100644 +index 5e2d9f7099ebbccb374b5b08f65a90187e0a5860..fff3163ab0d424a5a588879638e9b77a84e3f10a 100644 --- a/src/api/api.cc +++ b/src/api/api.cc @@ -534,6 +534,10 @@ void V8::SetSnapshotDataBlob(StartupData* snapshot_blob) { diff --git a/patches/v8/build_gn.patch b/patches/v8/build_gn.patch index e18dc7c203716..f54516d53929a 100644 --- a/patches/v8/build_gn.patch +++ b/patches/v8/build_gn.patch @@ -9,7 +9,7 @@ necessary for native modules to load. Also, some fixes relating to mksnapshot on ARM. diff --git a/BUILD.gn b/BUILD.gn -index 5c775837bb131572b23f839fd87a65b00ea8d640..f1e1283d1a7c4a072616acb21de5d6f3f75afd5b 100644 +index 41a53fbbcaf995d5c59c37464f81ed05d432cf3c..53265cb1441e695ab4ffac667cf5c3c67deaa534 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -368,7 +368,7 @@ config("internal_config") { @@ -21,7 +21,7 @@ index 5c775837bb131572b23f839fd87a65b00ea8d640..f1e1283d1a7c4a072616acb21de5d6f3 defines += [ "BUILDING_V8_SHARED" ] } } -@@ -4349,7 +4349,7 @@ if (current_toolchain == v8_generator_toolchain) { +@@ -4353,7 +4353,7 @@ if (current_toolchain == v8_generator_toolchain) { "src/interpreter/bytecodes.h", ] @@ -30,7 +30,7 @@ index 5c775837bb131572b23f839fd87a65b00ea8d640..f1e1283d1a7c4a072616acb21de5d6f3 deps = [ ":v8_libbase", -@@ -4382,6 +4382,8 @@ if (current_toolchain == v8_snapshot_toolchain) { +@@ -4386,6 +4386,8 @@ if (current_toolchain == v8_snapshot_toolchain) { configs = [ ":internal_config" ] diff --git a/patches/v8/chore_add_v8_apple_silicon_patches.patch b/patches/v8/chore_add_v8_apple_silicon_patches.patch index 0d1609076a67d..646a6584d6462 100644 --- a/patches/v8/chore_add_v8_apple_silicon_patches.patch +++ b/patches/v8/chore_add_v8_apple_silicon_patches.patch @@ -78,10 +78,10 @@ index 1737c7f8e121c967de6da8bfd17dcebd121d9dd5..58ec3108a8ea5888ba31f4b5c7c4939e PushParameter input1 = slot > 0 ? (*arguments)[slot - 1] : PushParameter(); // Emit a poke-pair if consecutive parameters have the same type. diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h -index d4a1ad0920a45e0d704e4ed8a01fdad59fcde6e1..32c25712c6490984bd59cf4125feec98050cc61d 100644 +index f2fec6c21e8cacd016ce8a7dad7ef2a7ecade7d2..3616beca39bc40fd7ef09df1bf393e2b2c109e72 100644 --- a/src/flags/flag-definitions.h +++ b/src/flags/flag-definitions.h -@@ -710,7 +710,12 @@ DEFINE_INT(wasm_num_compilation_tasks, 128, +@@ -712,7 +712,12 @@ DEFINE_INT(wasm_num_compilation_tasks, 128, "maximum number of parallel compilation tasks for wasm") DEFINE_DEBUG_BOOL(trace_wasm_native_heap, false, "trace wasm native heap events") diff --git a/patches/v8/dcheck.patch b/patches/v8/dcheck.patch index febbc23e42384..90cc497e8e169 100644 --- a/patches/v8/dcheck.patch +++ b/patches/v8/dcheck.patch @@ -6,10 +6,10 @@ Subject: dcheck.patch https://github.com/auchenberg/volkswagen diff --git a/src/api/api.cc b/src/api/api.cc -index 8948794fbac1095f34cdeccc00ec67eedc4458eb..13de6c814685482bf499fb15ac380c2d5e052b67 100644 +index fff3163ab0d424a5a588879638e9b77a84e3f10a..ca697417719a1ccc0904a7d3c005ff2c5cf55325 100644 --- a/src/api/api.cc +++ b/src/api/api.cc -@@ -8683,7 +8683,7 @@ void Isolate::SetPromiseRejectCallback(PromiseRejectCallback callback) { +@@ -8685,7 +8685,7 @@ void Isolate::SetPromiseRejectCallback(PromiseRejectCallback callback) { } void Isolate::PerformMicrotaskCheckpoint() { @@ -19,10 +19,10 @@ index 8948794fbac1095f34cdeccc00ec67eedc4458eb..13de6c814685482bf499fb15ac380c2d isolate->default_microtask_queue()->PerformCheckpoint(this); } diff --git a/src/heap/heap.cc b/src/heap/heap.cc -index de290c47977135c2f7b89c2f1945c62e42fe2899..ac2549463e7fe2c4305e1a7120b8c7742e95789f 100644 +index 55dfd1aaf6897cb63bd34dffbd9fcac085f9e240..78f5278e85e6d7fdfccbec8c252348799568819e 100644 --- a/src/heap/heap.cc +++ b/src/heap/heap.cc -@@ -5628,9 +5628,9 @@ void Heap::TearDown() { +@@ -5629,9 +5629,9 @@ void Heap::TearDown() { void Heap::AddGCPrologueCallback(v8::Isolate::GCCallbackWithData callback, GCType gc_type, void* data) { DCHECK_NOT_NULL(callback); diff --git a/patches/v8/do_not_export_private_v8_symbols_on_windows.patch b/patches/v8/do_not_export_private_v8_symbols_on_windows.patch index a619fdc9dad3f..79b87c080bd48 100644 --- a/patches/v8/do_not_export_private_v8_symbols_on_windows.patch +++ b/patches/v8/do_not_export_private_v8_symbols_on_windows.patch @@ -12,7 +12,7 @@ This patch can be safely removed if, when it is removed, `node.lib` does not contain any standard C++ library exports (e.g. `std::ostringstream`). diff --git a/BUILD.gn b/BUILD.gn -index 18ea3b3d7f81e69137ac71b5273885fb0a75ad2b..44b36b3ac0a0cca6444499acc5b6fb46ea565e67 100644 +index f85dee75955291937c84f65a0b3cd2bd798ca8f2..9f5207e84ec2da78ec44c339390b18b54109263e 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -368,6 +368,10 @@ config("internal_config") { @@ -27,7 +27,7 @@ index 18ea3b3d7f81e69137ac71b5273885fb0a75ad2b..44b36b3ac0a0cca6444499acc5b6fb46 defines += [ "BUILDING_V8_SHARED" ] } diff --git a/src/base/macros.h b/src/base/macros.h -index 5dd52b18ae3be6e48439c314e55ea5d913296968..6a02b4e6e3522024f7995bd3b2c7171826c128e7 100644 +index cea15280a485cd6902500d3a20d85fb30eb3c449..1a5dd47c5fca640d8e3100b9f26067836460c758 100644 --- a/src/base/macros.h +++ b/src/base/macros.h @@ -396,13 +396,17 @@ bool is_inbounds(float_t v) { diff --git a/patches/v8/expose_mksnapshot.patch b/patches/v8/expose_mksnapshot.patch index 5fdcb00a8eb75..2f716486d46f4 100644 --- a/patches/v8/expose_mksnapshot.patch +++ b/patches/v8/expose_mksnapshot.patch @@ -6,10 +6,10 @@ Subject: expose_mksnapshot.patch Needed in order to target mksnapshot for mksnapshot zip. diff --git a/BUILD.gn b/BUILD.gn -index f1e1283d1a7c4a072616acb21de5d6f3f75afd5b..18ea3b3d7f81e69137ac71b5273885fb0a75ad2b 100644 +index 53265cb1441e695ab4ffac667cf5c3c67deaa534..f85dee75955291937c84f65a0b3cd2bd798ca8f2 100644 --- a/BUILD.gn +++ b/BUILD.gn -@@ -4360,7 +4360,6 @@ if (current_toolchain == v8_generator_toolchain) { +@@ -4364,7 +4364,6 @@ if (current_toolchain == v8_generator_toolchain) { if (current_toolchain == v8_snapshot_toolchain) { v8_executable("mksnapshot") { diff --git a/shell/browser/api/electron_api_menu_mac.mm b/shell/browser/api/electron_api_menu_mac.mm index f96f9301a0d85..a17462c0ee8d1 100644 --- a/shell/browser/api/electron_api_menu_mac.mm +++ b/shell/browser/api/electron_api_menu_mac.mm @@ -8,8 +8,8 @@ #include #include "base/mac/scoped_sending_event.h" -#include "base/message_loop/message_loop_current.h" #include "base/strings/sys_string_conversions.h" +#include "base/task/current_thread.h" #include "base/task/post_task.h" #include "content/public/browser/browser_task_traits.h" #include "content/public/browser/browser_thread.h" @@ -106,7 +106,7 @@ [popup_controllers_[window_id] setCloseCallback:std::move(close_callback)]; // Make sure events can be pumped while the menu is up. - base::MessageLoopCurrent::ScopedNestableTaskAllower allow; + base::CurrentThread::ScopedNestableTaskAllower allow; // One of the events that could be pumped is |window.close()|. // User-initiated event-tracking loops protect against this by diff --git a/shell/browser/api/electron_api_protocol.cc b/shell/browser/api/electron_api_protocol.cc index 0db55f4c6be92..18bb2e90358b5 100644 --- a/shell/browser/api/electron_api_protocol.cc +++ b/shell/browser/api/electron_api_protocol.cc @@ -8,6 +8,7 @@ #include #include +#include "base/command_line.h" #include "base/stl_util.h" #include "content/public/browser/child_process_security_policy.h" #include "gin/object_template_builder.h" diff --git a/shell/browser/api/electron_api_url_loader.cc b/shell/browser/api/electron_api_url_loader.cc index f399c78cf7187..543c802fe0b33 100644 --- a/shell/browser/api/electron_api_url_loader.cc +++ b/shell/browser/api/electron_api_url_loader.cc @@ -12,6 +12,7 @@ #include #include "base/containers/id_map.h" +#include "base/no_destructor.h" #include "gin/handle.h" #include "gin/object_template_builder.h" #include "gin/wrappable.h" diff --git a/shell/browser/api/electron_api_web_contents.cc b/shell/browser/api/electron_api_web_contents.cc index 082e67f67d0af..b7825337aa896 100644 --- a/shell/browser/api/electron_api_web_contents.cc +++ b/shell/browser/api/electron_api_web_contents.cc @@ -12,10 +12,10 @@ #include #include -#include "base/message_loop/message_loop_current.h" #include "base/no_destructor.h" #include "base/optional.h" #include "base/strings/utf_string_conversions.h" +#include "base/task/current_thread.h" #include "base/threading/thread_restrictions.h" #include "base/threading/thread_task_runner_handle.h" #include "base/values.h" @@ -2398,7 +2398,7 @@ void WebContents::StartDrag(const gin_helper::Dictionary& item, // Start dragging. if (!files.empty()) { - base::MessageLoopCurrent::ScopedNestableTaskAllower allow; + base::CurrentThread::ScopedNestableTaskAllower allow; DragFileItems(files, icon->image(), web_contents()->GetNativeView()); } else { gin_helper::ErrorThrower(args->isolate()) diff --git a/shell/browser/browser_process_impl.cc b/shell/browser/browser_process_impl.cc index 80d42743a197c..5d936c23f3db5 100644 --- a/shell/browser/browser_process_impl.cc +++ b/shell/browser/browser_process_impl.cc @@ -8,6 +8,7 @@ #include +#include "base/command_line.h" #include "chrome/common/chrome_switches.h" #include "components/federated_learning/floc_blocklist_service.h" // nogncheck #include "components/prefs/in_memory_pref_store.h" diff --git a/shell/browser/electron_browser_client.cc b/shell/browser/electron_browser_client.cc index b392d5a690c43..6af3076eff426 100644 --- a/shell/browser/electron_browser_client.cc +++ b/shell/browser/electron_browser_client.cc @@ -929,13 +929,6 @@ void ElectronBrowserClient::SiteInstanceGotProcess( extensions::ProcessMap::Get(browser_context) ->Insert(extension->id(), site_instance->GetProcess()->GetID(), site_instance->GetId()); - - base::PostTask( - FROM_HERE, {BrowserThread::IO}, - base::BindOnce(&extensions::InfoMap::RegisterExtensionProcess, - browser_context->extension_system()->info_map(), - extension->id(), site_instance->GetProcess()->GetID(), - site_instance->GetId())); } #endif // BUILDFLAG(ENABLE_ELECTRON_EXTENSIONS) } @@ -1014,13 +1007,6 @@ void ElectronBrowserClient::SiteInstanceDeleting( extensions::ProcessMap::Get(browser_context) ->Remove(extension->id(), site_instance->GetProcess()->GetID(), site_instance->GetId()); - - base::PostTask( - FROM_HERE, {BrowserThread::IO}, - base::BindOnce(&extensions::InfoMap::UnregisterExtensionProcess, - browser_context->extension_system()->info_map(), - extension->id(), site_instance->GetProcess()->GetID(), - site_instance->GetId())); } #endif } diff --git a/shell/browser/electron_browser_main_parts.cc b/shell/browser/electron_browser_main_parts.cc index c1ddc4a622723..7d2edca575668 100644 --- a/shell/browser/electron_browser_main_parts.cc +++ b/shell/browser/electron_browser_main_parts.cc @@ -65,7 +65,6 @@ #include "base/nix/xdg_util.h" #include "base/threading/thread_task_runner_handle.h" #include "ui/base/x/x11_util.h" -#include "ui/base/x/x11_util_internal.h" #include "ui/events/devices/x11/touch_factory_x11.h" #include "ui/gfx/color_utils.h" #include "ui/gfx/x/x11_types.h" @@ -402,7 +401,8 @@ void ElectronBrowserMainParts::PostDestroyThreads() { void ElectronBrowserMainParts::ToolkitInitialized() { #if defined(USE_X11) // In Aura/X11, Gtk-based LinuxUI implementation is used. - gtk_ui_delegate_ = std::make_unique(gfx::GetXDisplay()); + gtk_ui_delegate_ = + std::make_unique(x11::Connection::Get()); ui::GtkUiDelegate::SetInstance(gtk_ui_delegate_.get()); views::LinuxUI* linux_ui = BuildGtkUi(gtk_ui_delegate_.get()); views::LinuxUI::SetInstance(linux_ui); diff --git a/shell/browser/javascript_environment.cc b/shell/browser/javascript_environment.cc index ab6f8dc79ca3c..f67ce3705283a 100644 --- a/shell/browser/javascript_environment.cc +++ b/shell/browser/javascript_environment.cc @@ -9,7 +9,7 @@ #include #include "base/command_line.h" -#include "base/message_loop/message_loop_current.h" +#include "base/task/current_thread.h" #include "base/task/thread_pool/initialization_util.h" #include "base/threading/thread_task_runner_handle.h" #include "content/public/common/content_switches.h" @@ -91,7 +91,7 @@ v8::Isolate* JavascriptEnvironment::GetIsolate() { void JavascriptEnvironment::OnMessageLoopCreated() { DCHECK(!microtasks_runner_); microtasks_runner_ = std::make_unique(isolate()); - base::MessageLoopCurrent::Get()->AddTaskObserver(microtasks_runner_.get()); + base::CurrentThread::Get()->AddTaskObserver(microtasks_runner_.get()); } void JavascriptEnvironment::OnMessageLoopDestroying() { @@ -101,7 +101,7 @@ void JavascriptEnvironment::OnMessageLoopDestroying() { v8::HandleScope scope(isolate_); gin_helper::CleanedUpAtExit::DoCleanup(); } - base::MessageLoopCurrent::Get()->RemoveTaskObserver(microtasks_runner_.get()); + base::CurrentThread::Get()->RemoveTaskObserver(microtasks_runner_.get()); platform_->DrainTasks(isolate_); platform_->UnregisterIsolate(isolate_); } diff --git a/shell/browser/net/network_context_service.cc b/shell/browser/net/network_context_service.cc index 51a28dbd5715b..bf9177217f00a 100644 --- a/shell/browser/net/network_context_service.cc +++ b/shell/browser/net/network_context_service.cc @@ -6,6 +6,7 @@ #include "chrome/common/chrome_constants.h" #include "content/public/browser/network_service_instance.h" +#include "net/net_buildflags.h" #include "services/network/network_service.h" #include "shell/browser/browser_process_impl.h" #include "shell/browser/electron_browser_client.h" diff --git a/shell/browser/net/web_request_api_interface.h b/shell/browser/net/web_request_api_interface.h index 649145f6f66aa..5eeaad0800cfa 100644 --- a/shell/browser/net/web_request_api_interface.h +++ b/shell/browser/net/web_request_api_interface.h @@ -9,6 +9,7 @@ #include #include "extensions/browser/api/web_request/web_request_info.h" +#include "net/base/completion_once_callback.h" #include "services/network/public/cpp/resource_request.h" namespace electron { diff --git a/shell/browser/osr/osr_render_widget_host_view.cc b/shell/browser/osr/osr_render_widget_host_view.cc index 692966ac12db9..44bfa640ba5ae 100644 --- a/shell/browser/osr/osr_render_widget_host_view.cc +++ b/shell/browser/osr/osr_render_widget_host_view.cc @@ -487,13 +487,13 @@ void OffScreenRenderWidgetHostView::CopyFromSurface( } void OffScreenRenderWidgetHostView::GetScreenInfo( - content::ScreenInfo* screen_info) { + blink::ScreenInfo* screen_info) { screen_info->depth = 24; screen_info->depth_per_component = 8; screen_info->orientation_angle = 0; screen_info->device_scale_factor = current_device_scale_factor_; screen_info->orientation_type = - content::SCREEN_ORIENTATION_VALUES_LANDSCAPE_PRIMARY; + blink::mojom::ScreenOrientation::kLandscapePrimary; screen_info->rect = gfx::Rect(size_); screen_info->available_rect = gfx::Rect(size_); } diff --git a/shell/browser/osr/osr_render_widget_host_view.h b/shell/browser/osr/osr_render_widget_host_view.h index 0e1a6776be515..47f3438922f6e 100644 --- a/shell/browser/osr/osr_render_widget_host_view.h +++ b/shell/browser/osr/osr_render_widget_host_view.h @@ -124,7 +124,7 @@ class OffScreenRenderWidgetHostView : public content::RenderWidgetHostViewBase, const gfx::Rect& src_rect, const gfx::Size& output_size, base::OnceCallback callback) override; - void GetScreenInfo(content::ScreenInfo* results) override; + void GetScreenInfo(blink::ScreenInfo* results) override; void TransformPointToRootSurface(gfx::PointF* point) override; gfx::Rect GetBoundsInRootWindow(void) override; viz::SurfaceId GetCurrentSurfaceId() const override; diff --git a/shell/browser/osr/osr_web_contents_view.cc b/shell/browser/osr/osr_web_contents_view.cc index 79e736dfee965..b6d7a39525f1f 100644 --- a/shell/browser/osr/osr_web_contents_view.cc +++ b/shell/browser/osr/osr_web_contents_view.cc @@ -6,7 +6,7 @@ #include "content/browser/web_contents/web_contents_impl.h" // nogncheck #include "content/public/browser/render_view_host.h" -#include "third_party/blink/public/platform/web_screen_info.h" +#include "third_party/blink/public/common/widget/screen_info.h" #include "ui/display/screen.h" namespace electron { diff --git a/shell/browser/plugins/plugin_utils.cc b/shell/browser/plugins/plugin_utils.cc index e305661cc520a..206812717e79f 100644 --- a/shell/browser/plugins/plugin_utils.cc +++ b/shell/browser/plugins/plugin_utils.cc @@ -37,7 +37,7 @@ PluginUtils::GetMimeTypeToExtensionIdMap( base::flat_map mime_type_to_extension_id_map; #if BUILDFLAG(ENABLE_EXTENSIONS) std::vector allowed_extension_ids = - MimeTypesHandler::GetMIMETypeWhitelist(); + MimeTypesHandler::GetMIMETypeAllowlist(); // Go through the white-listed extensions and try to use them to intercept // the URL request. for (const std::string& extension_id : allowed_extension_ids) { diff --git a/shell/browser/ui/tray_icon_cocoa.mm b/shell/browser/ui/tray_icon_cocoa.mm index c4ce738156229..2290459cf6f7c 100644 --- a/shell/browser/ui/tray_icon_cocoa.mm +++ b/shell/browser/ui/tray_icon_cocoa.mm @@ -7,9 +7,9 @@ #include #include -#include "base/message_loop/message_loop_current.h" #include "base/message_loop/message_pump_mac.h" #include "base/strings/sys_string_conversions.h" +#include "base/task/current_thread.h" #include "base/task/post_task.h" #include "content/public/browser/browser_task_traits.h" #include "content/public/browser/browser_thread.h" @@ -177,7 +177,7 @@ - (void)mouseUp:(NSEvent*)event { - (void)popUpContextMenu:(electron::ElectronMenuModel*)menu_model { // Make sure events can be pumped while the menu is up. - base::MessageLoopCurrent::ScopedNestableTaskAllower allow; + base::CurrentThread::ScopedNestableTaskAllower allow; // Show a custom menu. if (menu_model) { diff --git a/shell/common/api/electron_api_clipboard.cc b/shell/common/api/electron_api_clipboard.cc index 28afc2dbb56ea..57241881dddef 100644 --- a/shell/common/api/electron_api_clipboard.cc +++ b/shell/common/api/electron_api_clipboard.cc @@ -30,7 +30,8 @@ std::vector Clipboard::AvailableFormats( gin_helper::Arguments* args) { std::vector format_types; ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread(); - clipboard->ReadAvailableTypes(GetClipboardBuffer(args), &format_types); + clipboard->ReadAvailableTypes(GetClipboardBuffer(args), + /* data_dst = */ nullptr, &format_types); return format_types; } @@ -39,7 +40,8 @@ bool Clipboard::Has(const std::string& format_string, ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread(); ui::ClipboardFormatType format( ui::ClipboardFormatType::GetType(format_string)); - return clipboard->IsFormatAvailable(format, GetClipboardBuffer(args)); + return clipboard->IsFormatAvailable(format, GetClipboardBuffer(args), + /* data_dst = */ nullptr); } std::string Clipboard::Read(const std::string& format_string) { @@ -48,7 +50,7 @@ std::string Clipboard::Read(const std::string& format_string) { ui::ClipboardFormatType::GetType(format_string)); std::string data; - clipboard->ReadData(format, &data); + clipboard->ReadData(format, /* data_dst = */ nullptr, &data); return data; } @@ -105,14 +107,15 @@ base::string16 Clipboard::ReadText(gin_helper::Arguments* args) { ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread(); auto type = GetClipboardBuffer(args); if (clipboard->IsFormatAvailable(ui::ClipboardFormatType::GetPlainTextType(), - type)) { - clipboard->ReadText(type, &data); + type, /* data_dst = */ nullptr)) { + clipboard->ReadText(type, /* data_dst = */ nullptr, &data); } else { #if defined(OS_WIN) if (clipboard->IsFormatAvailable( - ui::ClipboardFormatType::GetPlainTextAType(), type)) { + ui::ClipboardFormatType::GetPlainTextAType(), type, + /* data_dst = */ nullptr)) { std::string result; - clipboard->ReadAsciiText(type, &result); + clipboard->ReadAsciiText(type, /* data_dst = */ nullptr, &result); data = base::ASCIIToUTF16(result); } #endif @@ -129,7 +132,7 @@ void Clipboard::WriteText(const base::string16& text, base::string16 Clipboard::ReadRTF(gin_helper::Arguments* args) { std::string data; ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread(); - clipboard->ReadRTF(GetClipboardBuffer(args), &data); + clipboard->ReadRTF(GetClipboardBuffer(args), /* data_dst = */ nullptr, &data); return base::UTF8ToUTF16(data); } @@ -145,7 +148,8 @@ base::string16 Clipboard::ReadHTML(gin_helper::Arguments* args) { uint32_t start; uint32_t end; ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread(); - clipboard->ReadHTML(GetClipboardBuffer(args), &html, &url, &start, &end); + clipboard->ReadHTML(GetClipboardBuffer(args), /* data_dst = */ nullptr, &html, + &url, &start, &end); data = html.substr(start, end - start); return data; } @@ -162,7 +166,7 @@ v8::Local Clipboard::ReadBookmark(gin_helper::Arguments* args) { gin_helper::Dictionary dict = gin_helper::Dictionary::CreateEmpty(args->isolate()); ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread(); - clipboard->ReadBookmark(&title, &url); + clipboard->ReadBookmark(/* data_dst = */ nullptr, &title, &url); dict.Set("title", title); dict.Set("url", url); return dict.GetHandle(); @@ -180,6 +184,7 @@ gfx::Image Clipboard::ReadImage(gin_helper::Arguments* args) { base::Optional image; clipboard->ReadImage( GetClipboardBuffer(args), + /* data_dst = */ nullptr, base::Bind( [](base::Optional* image, const SkBitmap& result) { image->emplace(gfx::Image::CreateFrom1xBitmap(result)); diff --git a/shell/common/gin_converters/blink_converter.cc b/shell/common/gin_converters/blink_converter.cc index be696f44d5142..f576f0a3dbef2 100644 --- a/shell/common/gin_converters/blink_converter.cc +++ b/shell/common/gin_converters/blink_converter.cc @@ -374,7 +374,7 @@ v8::Local EditFlagsToV8(v8::Isolate* isolate, int editFlags) { if (editFlags & blink::ContextMenuDataEditFlags::kCanPaste) { std::vector types; ui::Clipboard::GetForCurrentThread()->ReadAvailableTypes( - ui::ClipboardBuffer::kCopyPaste, &types); + ui::ClipboardBuffer::kCopyPaste, /* data_dst = */ nullptr, &types); pasteFlag = !types.empty(); } dict.Set("canPaste", pasteFlag); diff --git a/shell/renderer/api/electron_api_web_frame.cc b/shell/renderer/api/electron_api_web_frame.cc index 0a298e7d4d5c4..ed2b6f8cc63bd 100644 --- a/shell/renderer/api/electron_api_web_frame.cc +++ b/shell/renderer/api/electron_api_web_frame.cc @@ -594,7 +594,7 @@ void SetIsolatedWorldInfo(v8::Local window, blink::WebString::FromUTF8(origin_url)); info.content_security_policy = blink::WebString::FromUTF8(security_policy); info.human_readable_name = blink::WebString::FromUTF8(name); - render_frame->GetWebFrame()->SetIsolatedWorldInfo(world_id, info); + blink::SetIsolatedWorldInfo(world_id, info); } blink::WebCacheResourceTypeStats GetResourceUsage(v8::Isolate* isolate) { diff --git a/shell/renderer/content_settings_observer.cc b/shell/renderer/content_settings_observer.cc index 6966fdc3b5e14..0b310e72bb113 100644 --- a/shell/renderer/content_settings_observer.cc +++ b/shell/renderer/content_settings_observer.cc @@ -4,6 +4,7 @@ #include "shell/renderer/content_settings_observer.h" +#include "base/command_line.h" #include "content/public/renderer/render_frame.h" #include "shell/common/options_switches.h" #include "third_party/blink/public/platform/url_conversion.h" diff --git a/shell/renderer/electron_render_frame_observer.cc b/shell/renderer/electron_render_frame_observer.cc index 46905889bd807..98c8aa6f55803 100644 --- a/shell/renderer/electron_render_frame_observer.cc +++ b/shell/renderer/electron_render_frame_observer.cc @@ -137,7 +137,7 @@ void ElectronRenderFrameObserver::CreateIsolatedWorldContext() { blink::WebString::FromUTF8("Electron Isolated Context"); // Setup document's origin policy in isolated world info.security_origin = frame->GetDocument().GetSecurityOrigin(); - frame->SetIsolatedWorldInfo(WorldIDs::ISOLATED_WORLD_ID, info); + blink::SetIsolatedWorldInfo(WorldIDs::ISOLATED_WORLD_ID, info); // Create initial script context in isolated world blink::WebScriptSource source("void 0");