Skip to content
Permalink
Browse files

build: ensure that we bundle the correct version of @types/node (#19102)

  • Loading branch information...
MarshallOfSound committed Jul 3, 2019
1 parent 5a1b661 commit 4b674c1daf2c291c2459925ed417dfdbd930ddb8
Showing with 11 additions and 1 deletion.
  1. +1 −1 npm/package.json
  2. +10 −0 spec-main/types-spec.ts
@@ -9,7 +9,7 @@
},
"dependencies": {
"@electron/get": "^1.0.1",
"@types/node": "^10.12.18",
"@types/node": "^12.0.12",
"extract-zip": "^1.0.3"
},
"engines": {
@@ -0,0 +1,10 @@
import { expect } from 'chai'

describe('bundled @types/node', () => {
it('should match the major version of bundled node', () => {
expect(require('../npm/package.json').dependencies).to.have.property('@types/node')
const range = require('../npm/package.json').dependencies['@types/node']
expect(range).to.match(/^\^.+/, 'should allow any type dep in a major range')
expect(range.slice(1).split('.')[0]).to.equal(process.versions.node.split('.')[0])
})
})

0 comments on commit 4b674c1

Please sign in to comment.
You can’t perform that action at this time.