From 5393b95bb637911bbe183ef02f6e02f4ee1f4415 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Thu, 9 Feb 2023 11:27:17 +0100 Subject: [PATCH] fix: crash when beforeunload prevented --- shell/browser/api/electron_api_browser_window.cc | 2 +- shell/browser/api/electron_api_web_contents.cc | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/shell/browser/api/electron_api_browser_window.cc b/shell/browser/api/electron_api_browser_window.cc index 867b77786f519..f1fd37e0c740d 100644 --- a/shell/browser/api/electron_api_browser_window.cc +++ b/shell/browser/api/electron_api_browser_window.cc @@ -112,7 +112,6 @@ BrowserWindow::~BrowserWindow() { api_web_contents_->RemoveObserver(this); // Destroy the WebContents. OnCloseContents(); - api_web_contents_->Destroy(); } } @@ -140,6 +139,7 @@ void BrowserWindow::WebContentsDestroyed() { void BrowserWindow::OnCloseContents() { BaseWindow::ResetBrowserViews(); + api_web_contents_->Destroy(); } void BrowserWindow::OnRendererResponsive(content::RenderProcessHost*) { diff --git a/shell/browser/api/electron_api_web_contents.cc b/shell/browser/api/electron_api_web_contents.cc index da897f06f62f2..0e632a6a80a05 100644 --- a/shell/browser/api/electron_api_web_contents.cc +++ b/shell/browser/api/electron_api_web_contents.cc @@ -1221,8 +1221,6 @@ void WebContents::CloseContents(content::WebContents* source) { for (ExtendedWebContentsObserver& observer : observers_) observer.OnCloseContents(); - - Destroy(); } void WebContents::ActivateContents(content::WebContents* source) {