From 55e9421ed015bf35218b34bd94de5d980ec80189 Mon Sep 17 00:00:00 2001 From: clavin Date: Mon, 29 Jan 2024 14:44:10 -0700 Subject: [PATCH] address review comment for 5196547 See: https://chromium-review.googlesource.com/c/chromium/src/+/5196547 Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786 --- shell/browser/electron_browser_main_parts.cc | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/shell/browser/electron_browser_main_parts.cc b/shell/browser/electron_browser_main_parts.cc index 9bf80cbb26a0d..f96355ac24886 100644 --- a/shell/browser/electron_browser_main_parts.cc +++ b/shell/browser/electron_browser_main_parts.cc @@ -494,13 +494,6 @@ int ElectronBrowserMainParts::PreMainMessageLoopRun() { void ElectronBrowserMainParts::WillRunMainMessageLoop( std::unique_ptr& run_loop) { -#if BUILDFLAG(IS_LINUX) - auto shutdown_cb = base::BindOnce(run_loop->QuitWhenIdleClosure()); - ui::OzonePlatform::GetInstance()->PostCreateMainMessageLoop( - std::move(shutdown_cb), - content::GetUIThreadTaskRunner({content::BrowserTaskType::kUserInput})); -#endif - exit_code_ = content::RESULT_CODE_NORMAL_EXIT; Browser::Get()->SetMainMessageLoopQuitClosure( run_loop->QuitWhenIdleClosure()); @@ -511,6 +504,11 @@ void ElectronBrowserMainParts::PostCreateMainMessageLoop() { std::string app_name = electron::Browser::Get()->GetName(); #endif #if BUILDFLAG(IS_LINUX) + auto shutdown_cb = base::BindOnce([] { LOG(FATAL) << "Failed to shutdown." }); + ui::OzonePlatform::GetInstance()->PostCreateMainMessageLoop( + std::move(shutdown_cb), + content::GetUIThreadTaskRunner({content::BrowserTaskType::kUserInput})); + if (!bluez::BluezDBusManager::IsInitialized()) bluez::DBusBluezManagerWrapperLinux::Initialize();