fix: Disable new fade animation for BrowserViews (#14913)

electron · Oct 2, 2018 · 8d36215 · 8d36215
1 parent 385b088
commit 8d36215
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/atom/browser/native_window_mac.mm b/atom/browser/native_window_mac.mm
@@ -1019,13 +1019,17 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) {
 }
 
 void NativeWindowMac::SetBrowserView(NativeBrowserView* view) {
+  [CATransaction begin];
+  [CATransaction setDisableActions:YES];
+
   if (browser_view()) {
     [browser_view()->GetInspectableWebContentsView()->GetNativeView()
             removeFromSuperview];
     set_browser_view(nullptr);
   }
 
   if (!view) {
+    [CATransaction commit];
     return;
   }
 
@@ -1035,6 +1039,8 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) {
                          positioned:NSWindowAbove
                          relativeTo:nil];
   native_view.hidden = NO;
+
+  [CATransaction commit];
 }
 
 void NativeWindowMac::SetParentWindow(NativeWindow* parent) {