Skip to content
Permalink
Branch: master
Commits on Jul 16, 2019
  1. docs: mention fiddle in bug report template (#19248)

    erickzhao authored and codebytere committed Jul 16, 2019
    * chore: mention fiddle in bug report template
    
    * add words
Commits on Jul 12, 2019
  1. chore: revert key -> main change in window delegate listener (#19213)

    erickzhao authored and zcbenz committed Jul 12, 2019
    * chore: revert key -> main
    
    * chore: comment out test that will fail
    
    * more context on commented out test
    
    * remove commented test
Commits on Jul 1, 2019
  1. fix: Correct modal focus behavior on macOS (#18995)

    erickzhao authored and codebytere committed Jul 1, 2019
    Fixes #18502
    
    This PR changes the focus and blur events that we emit in Electron to listen to changes in key window rather than main window. It swaps out windowDidBecomeMain and windowDidResignMain for windowDidBecomeKey and windowDidResignKey, respectively.
  2. fix: fire close event upon closing modal BrowserWindow in macOS (#19014)

    erickzhao authored and zcbenz committed Jul 1, 2019
    * fix: emit close event from modal on macOS
    
    * fix: Move fn call to correct spot
    
    * refactor: call notify fn directly
Commits on Jun 28, 2019
  1. fix: correct triggeredByAccelerator Event property behavior (#18865)

    erickzhao authored and codebytere committed Jun 28, 2019
    Fixes #18808
    
    Previously, the triggeredByAccelerator flag would be entirely coupled with whether or not the modifier keys were being used or not.
    
    This PR swaps out the ui::EventFlagsFromModifiers([event modifierFlags])) call in the macOS code to ui::EventFlagsFromNSEventWithModifiers(event, [event modifierFlags])). The latter outputs flags that take into account mouse click events on top of modifier flags (see Chromium documentation).
    
    The business logic to detect triggeredByAccelerator is then changed to exclude any mouse click flags.
You can’t perform that action at this time.