New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser-process notifications are missing/duplicating images #10610

Closed
felixrieseberg opened this Issue Sep 25, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@felixrieseberg
Member

felixrieseberg commented Sep 25, 2017

The browser-process notifications are either missing or reusing images from the last notification. The reason is simple: In atom_api_notification, we set the icon_url to GURL(), but in the notification presenter, we assume an okay and unique path.

  • Electron version: 1.7+
  • Operating system: Windows

Expected behavior

Notifications should contain the passed icon

Actual behavior

Notifications contain either no or the last passed icon

How to reproduce

Use browser-process notifications and attach an image on Windows 10 as icon. Now, send another notification with a different image. Observe how the first icon is shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment