New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web bluetooth takes 1 minute before returning a device #11399

Closed
timmyhadwen opened this Issue Dec 11, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@timmyhadwen
Contributor

timmyhadwen commented Dec 11, 2017

  • Electron version: 1.7.9
  • Operating system: macOS Sierra

Expected behavior

We should have some type of bluetooth dialog (like in chrome).

Actual behavior

A 1 minute timeout before a device (even with specified name) is selected and connected to.

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Dec 11, 2017

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

welcome bot commented Dec 11, 2017

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Dec 11, 2017

Member

We should have some type of bluetooth dialog (like in chrome).

Electron is not a browser, default "browser style" dialogs such as permission requests and in this case bluetooth device select are left to the developers of specific apps to implement.

A 1 minute timeout before a device

Can you provide sample code that replicates this issue?

Member

MarshallOfSound commented Dec 11, 2017

We should have some type of bluetooth dialog (like in chrome).

Electron is not a browser, default "browser style" dialogs such as permission requests and in this case bluetooth device select are left to the developers of specific apps to implement.

A 1 minute timeout before a device

Can you provide sample code that replicates this issue?

@MarshallOfSound MarshallOfSound changed the title from Web bluetooth dialog doesn't show and takes 1 minute before selecting a device to Web bluetooth takes 1 minute before returning a device Dec 11, 2017

@timmyhadwen

This comment has been minimized.

Show comment
Hide comment
@timmyhadwen

timmyhadwen Dec 11, 2017

Contributor

@MarshallOfSound Thanks for the reply!

Electron is not a browser, default "browser style" dialogs such as permission requests and in this case bluetooth device select are left to the developers of specific apps to implement.

Makes sense, but obviously the delay isn't wanted either.

Can you provide sample code that replicates this issue?

This repo should replicate the issue
https://github.com/aalhaimi/electron-web-bluetooth

Contributor

timmyhadwen commented Dec 11, 2017

@MarshallOfSound Thanks for the reply!

Electron is not a browser, default "browser style" dialogs such as permission requests and in this case bluetooth device select are left to the developers of specific apps to implement.

Makes sense, but obviously the delay isn't wanted either.

Can you provide sample code that replicates this issue?

This repo should replicate the issue
https://github.com/aalhaimi/electron-web-bluetooth

@acstacey

This comment has been minimized.

Show comment
Hide comment
@acstacey

acstacey Dec 11, 2017

The issue appears to be that the scan timeout is 1 minute and the BluetoothChooser::AddOrUpdateDevice method doesn't emit an event so a device can't be chosen until the scan is complete.

acstacey commented Dec 11, 2017

The issue appears to be that the scan timeout is 1 minute and the BluetoothChooser::AddOrUpdateDevice method doesn't emit an event so a device can't be chosen until the scan is complete.

@zcbenz zcbenz closed this in #11492 Feb 5, 2018

zcbenz added a commit that referenced this issue Feb 5, 2018

Merge pull request #11492 from timmyhadwen/master
Fixed Bluetooth chooser bug. Closes #11399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment