Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog does not close on ESCAPE if defaultId is set (Mac) #14160

Closed
0x6431346e opened this Issue Aug 17, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@0x6431346e
Copy link

0x6431346e commented Aug 17, 2018

  • Electron Version: ^2.0.6
  • Operating System (Platform and Version): mac 10.12
  • Last known working Electron version: -

Expected Behavior
Pressing the escape key should close the dialog.

Actual behavior
On macOS nothing happens when you press escape as long as your dialog has defaultId set.
On Linux and Windows everything works as expected.

To Reproduce

$ git clone https://github.com/0x6431346e/electron-dialog-bug
$ npm i
$ npm start

(The code is in the renderer file)

@welcome

This comment has been minimized.

Copy link

welcome bot commented Aug 17, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

keerthi16 added a commit to keerthi16/electron that referenced this issue Aug 19, 2018

trop-bot pushed a commit to trop-bot/electron that referenced this issue Aug 19, 2018

trop-bot pushed a commit to trop-bot/electron that referenced this issue Aug 19, 2018

MarshallOfSound added a commit that referenced this issue Aug 19, 2018

MarshallOfSound added a commit that referenced this issue Aug 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.