Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frameless windows break mouse cursor on High DPI monitors with scaling #14787

Closed
sbatten opened this issue Sep 24, 2018 · 7 comments
Closed

Frameless windows break mouse cursor on High DPI monitors with scaling #14787

sbatten opened this issue Sep 24, 2018 · 7 comments

Comments

@sbatten
Copy link

@sbatten sbatten commented Sep 24, 2018

  • Operating System (Platform and Version): Ubuntu 18.04 amd64

Tested Electron version 2.0.9 and 3.0.0

Expected Behavior
Elements set with cursor text should show the text cursor when using frameless windows on High DPI monitors with scaling higher than 100%.

Actual behavior
When using higher than 100% scaling on a high dpi monitor and frameless electron windows, elements with a text cursor revert to the default cursor half-way down the element.

To Reproduce
In VSCode you can enable the custom title bar by setting window.titleBarStyle to custom. This will use a frameless window. On a high DPI monitor with your display settings set to 200%, you can see that mousing around the editor reveals this bug. You can also repro this using Electron Fiddle and a single div in the page with cursor set to text. Make sure the div is fairly large (say 500px).

Initially reported in VSCode: microsoft/vscode#58383 (comment)

@welcome
Copy link

@welcome welcome bot commented Sep 24, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@joaomoreno
Copy link
Contributor

@joaomoreno joaomoreno commented Dec 3, 2018

Filed before: #13911

There's a fiddle in there which you can just load up in Electron Fiddle: https://gist.github.com/joaomoreno/2bb9879aee864f22704882b5fac825c3

@sofianguy
Copy link
Member

@sofianguy sofianguy commented Aug 8, 2019

Thank you for taking the time to report this issue and helping to make Electron better.

The version of Electron you reported this on has been superseded by newer releases.

If you're still experiencing this issue in Electron v4.2.x or later, please add a comment specifying the version you're testing with and any other new information that a maintainer trying to reproduce the issue should know.

I'm setting the blocked/need-info label for the above reasons. This issue will be closed 7 days from now if there is no response.

Thanks in advance! Your help is appreciated.

@joaomoreno
Copy link
Contributor

@joaomoreno joaomoreno commented Aug 9, 2019

@sofianguy This sounds very similar to #5723, where people are reporting that it still occurs on 6.0.0: #5723 (comment)

@sofianguy sofianguy added this to Unsorted Issues in 6.1.x Aug 9, 2019
@joaomoreno
Copy link
Contributor

@joaomoreno joaomoreno commented Sep 25, 2019

This appears to be fixed on today's VS Code Insiders, which is based on Electron 6.0.9! 🎆

Can you confirm @sbatten?

@sofianguy Did any work happen here?

@sbatten
Copy link
Author

@sbatten sbatten commented Sep 25, 2019

confirmed that this does not repro in the latest insiders of VS Code using 6.0.9 as @joaomoreno suggests

@sofianguy
Copy link
Member

@sofianguy sofianguy commented Sep 26, 2019

closing because this issue is reported as fixed

@sofianguy sofianguy closed this Sep 26, 2019
@sofianguy sofianguy removed this from Unsorted Issues in 6.1.x Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3.0.x / 3.1.x
Unsorted Issues
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants