Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ES6ify the documentation JS examples #14842

Open
ckerr opened this issue Sep 27, 2018 · 5 comments

Comments

Projects
None yet
6 participants
@ckerr
Copy link
Member

commented Sep 27, 2018

Case in point: the Desktop Capturer code snippet uses a for (... i++) loop and could use for ... of and uses a Promise and could use async/await

CC @codebytere @sofianguy

@V1shvesh

This comment has been minimized.

Copy link

commented Oct 1, 2018

Hey @ckerr!
May I work upon this issue?

@aashish-ak

This comment has been minimized.

Copy link

commented Oct 8, 2018

@codebytere May i work on this issue??

@ckerr

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2018

Hey @V1shvesh, sorry for not responding sooner -- I didn't see your ping until just now.

Yes, anyone including you and @aashish-ak are welcome to work on this. If you are both going to work on it, you may want to coordinate on it so that your work doesn't overlap.

Thank you both for taking a look at this!

@ckerr ckerr referenced this issue Oct 8, 2018

Closed

Changed for(... i++) to for .. of #15009

0 of 5 tasks complete
@ntocampos

This comment has been minimized.

Copy link
Contributor

commented Oct 27, 2018

Hey @ckerr, I would like to help on this one!
I took a look in the docs and saw multiple API Reference sections where the example code can be "es6ified". I'm not sure if I should make a pull-request to each section, or group some of them together in the same PR. What do you recommend?

@MGenteluci

This comment has been minimized.

Copy link

commented Nov 27, 2018

Can i grab this issue?
edit: looks like this issue is already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.