Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: "Releasers" link broken #15621

Closed
jacobq opened this issue Nov 7, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@jacobq
Copy link
Contributor

commented Nov 7, 2018

In docs/development/pull-requests.md there is a link that looks like it should point to a page listing members of the "Releasers" team, but clicking the link results in a 404 error.
https://github.com/orgs/electron/teams/releasers/members

@doms

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

@jacobq 👋

The link is not broken per se, it's moreso how GitHub orgs & teams work! In its current implementation, if you are not apart of the organization (e.g. Electron), then you will not be able to see the teams that are within the organization.

So while the link may appear to be broken to outsiders, the link works normally for people who are apart of the organization.

I see how this can be confusing. 🤔 Maybe docs/development/pull-requests.md could be re-worded to say something like "only members of the Release team within Electron can restart a CI run" (that way the link is not needed and people not within the org won't be mislead to believe that it's broken)

@jacobq

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2018

@doms OK, but then the larger problem is this one: "How do I know who I should reach out to in order to request a restart of a failed CI build?"

e.g. #15596 (comment)

@doms

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

@jacobq

After a quick look at your code (and the CODEOWNERS file), I believe you can request a review from @electron/reviewers and one of the members of the team will get to you when they get the chance!

@jacobq

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2018

@doms Thanks for the reply. So would it make sense if that document were modified to also include a line like, "To request that a failed CI job be restarted, mention @electron/reviewers in the PR comments and explain why you believe the job should not have failed."?

Edit: Actually, I just tried that, and GitHub doesn't seem to recognize that string as a mention-able group/user.

@doms

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

@jacobq

mention @electron/reviewers in the PR comments and explain why you believe the job should not have failed."

Makes sense to me! I recommend maybe either editing your original issue stating that it could be re-worded, or creating a new one and linking back to this one (might seem counter-intuitive... 🤔 )

Actually, I just tried that, and GitHub doesn't seem to recognize that string as a mention-able group/user.

Ahh I myself might have accidentally mislead you, my apologies! It seems that you can't tag teams either unless you are in the org (I was briefly in the org, and that is no longer the case, so my previous reply must have spanned off that memory).

I believe the next best course of action would just be to tag the corresponding members who reviewed your PR before and just let them know you are ready for a re-review (and so that they can trigger a re-build). Sorry again for accidentally misleading you!

@jacobq

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2018

I'm going to close this since I don't think any further action is needed. If someone else gets confused then hopefully they can find this issue and have some time for a PR or something.

@jacobq jacobq closed this Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.