Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS]NSWindowZoomButton is disabled in frameless window since 3.0.0 #16091

Closed
Gizeta opened this issue Dec 16, 2018 · 2 comments

Comments

@Gizeta
Copy link

@Gizeta Gizeta commented Dec 16, 2018

  • Output of node_modules/.bin/electron --version: 3.0.11 (since 3.0.0-beta.1)
  • Operating System (Platform and Version): macOS Mojave 10.14.2
  • Output of node_modules/.bin/electron --version on last known working Electron version (if applicable): 2.0.14

Actual behavior
I create a frameless window and use Accessibility Inspector in Xcode to display the information properties of window's ZoomButton. I see that ZoomButton is disabled since 3.0.0-beta.1. That breaks some window manager, such as Magnet which may use Accessibility API. If I downgrade to 2.0.14, Magnet works well because ZoomButton is enabled.

To Reproduce
just create a frameless window

Screenshots
2.x
3.x

with Magnet's menu
2018-12-16 2 38 43

Additional Information
ZoomButton will be enabled if I make the window full screen and restore it. And Magnet will works correctly.

@welcome

This comment has been minimized.

Copy link

@welcome welcome bot commented Dec 16, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@Gizeta Gizeta changed the title [macOS]NSWindowZoomButton is disabled in frameless window in 3.x but enabled in 2.x [macOS]NSWindowZoomButton is disabled in frameless window since 3.0.0 Dec 17, 2018
@sofianguy sofianguy added this to Needs Review in 3.0.x / 3.1.x Dec 18, 2018
@codebytere

This comment has been minimized.

Copy link
Member

@codebytere codebytere commented Jun 7, 2019

This can't currently be worked around, as macOS itself disallows NSViews with NSWindowStyleMaskFullSizeContentView from entering full screen. Should something change, we'll return to this and address it.

@codebytere codebytere closed this Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3.0.x / 3.1.x
Unsorted Issues
3 participants
You can’t perform that action at this time.