Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for bf-cfb cipher #16816

Closed
Mic75 opened this issue Feb 7, 2019 · 4 comments
Closed

Adding support for bf-cfb cipher #16816

Mic75 opened this issue Feb 7, 2019 · 4 comments

Comments

@Mic75
Copy link

Mic75 commented Feb 7, 2019

Hello Electron Team,

As per #16195 (comment), it has been suggested to ask fro missing cipher algo when needed and open an issue.

We're using the bf-cfb cipher in our product, with no alternative to change this method since it's used in other part of our system.

This cipher not being exposed prevent us to upgrade to version 4+.
Could you please expose it?

@welcome
Copy link

welcome bot commented Feb 7, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@nornagon
Copy link
Member

nornagon commented Feb 7, 2019

This cipher was recently added to boringssl and described as "the worst of 90's
crypto". We can expose it, but I'd highly recommend you move your app to a more modern cipher suite.

@Mic75
Copy link
Author

Mic75 commented Feb 7, 2019

Thanks for the answer @nornagon.
We will consider changing the cipher method used in our system according to this feedback!

This would require some work on our side, since several component are concerned.
In the meantime, could you please expose this cipher so we can move on with version 4?

@nornagon
Copy link
Member

nornagon commented Mar 9, 2022

Closed by #32356

@nornagon nornagon closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants