Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safeDialogs option doesn't work #17543

Closed
PalmerAL opened this issue Mar 26, 2019 · 1 comment

Comments

@PalmerAL
Copy link
Contributor

commented Mar 26, 2019

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version: 5.0.0-beta.6
  • Operating System: macOS 10.13.6
  • Last Known Working Electron version:: unknown

To Reproduce

git clone https://github.com/PalmerAL/electron-quick-start.git
cd electron-quick-start
git checkout safe-dialogs
electron .

When running the example app, the "prevent this app from creating additional dialogs" option will appear after the second popup, but checking it doesn't actually do anything. Instead, dialogs will continue to appear forever until you force-quit the app.

@MarshallOfSound MarshallOfSound self-assigned this Mar 26, 2019

@sofianguy sofianguy added this to Unsorted Issues in 5.0.x Mar 27, 2019

@sofianguy sofianguy moved this from Unsorted Issues to Blocks Stable in 5.0.x Mar 28, 2019

@sofianguy sofianguy assigned ckerr and unassigned MarshallOfSound Apr 3, 2019

@ckerr ckerr removed this from Blocks Stable in 5.0.x Apr 3, 2019

@jkleinsc

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

This was fixed via #17579 and works correctly in 5.0.0-beta.7 and 5.0.0-beta.8

@jkleinsc jkleinsc closed this Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.