Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

details.responseHeaders should be optional #18298

Closed
pushkin- opened this issue May 14, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@pushkin-
Copy link

commented May 14, 2019

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version: 4.0.4
  • Operating System: Windows 10

Expected Behavior

According to here, (search for "onCompleted"), the responseHeaders set into the details object are optional, but electron.d.ts shows they're not:

  interface OnCompletedDetails {
    id: number;
    url: string;
    method: string;
    webContentsId?: number;
    resourceType: string;
    referrer: string;
    timestamp: number;
    responseHeaders: ResponseHeaders;
    fromCache: boolean;
    statusCode: number;
    statusLine: string;
  }

I was getting a crash where I assumed that they're set , but details.responseHeaders was undefined (when doing a window.open("", "a");)

MarshallOfSound added a commit that referenced this issue May 14, 2019

MarshallOfSound added a commit that referenced this issue May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.