Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.showSaveDialog() - callback that hands you fileName is inconsistent between 6.0.2 and 6.0.8 #20201

Closed
Nashorn opened this issue Sep 11, 2019 · 2 comments
Labels
blocked/need-info ❌ Cannot proceed without more information

Comments

@Nashorn
Copy link

Nashorn commented Sep 11, 2019

.showSaveDialog() - in 6.0.2 fires our callback with the chosen file path as an object that had to be accessed:

dialog.showSaveDialog({ filters: [] }, function (obj) {
alert(obj.filePath)
})

But, when i upgraded to 6.0.8, it breaks because an object is not handed back, only the string path:

dialog.showSaveDialog({ filters: [] }, function (filePathStr) {
alert(filePathStr)
})

@codebytere
Copy link
Member

codebytere commented Sep 16, 2019

I just ran this fiddle and saw identical behavior in both.

We also require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests. We will be able to more closely look at your issue once you do so.

@codebytere codebytere added the blocked/need-info ❌ Cannot proceed without more information label Sep 16, 2019
@sofianguy
Copy link
Contributor

Thank you for your issue!

We haven't gotten a response to our questions in our comment above. With only the information that is currently in the issue, we don't have enough information to take action. I'm going to close this but don't hesitate to reach out if you have or find the answers we need, we'll be happy to reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/need-info ❌ Cannot proceed without more information
Projects
None yet
Development

No branches or pull requests

3 participants