Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renderer crash when selection contains ContentEditable and regular text #26939

Closed
3 tasks done
lishid opened this issue Dec 11, 2020 · 1 comment
Closed
3 tasks done

Renderer crash when selection contains ContentEditable and regular text #26939

lishid opened this issue Dec 11, 2020 · 1 comment
Labels
blocked/upstream ❌

Comments

@lishid
Copy link
Contributor

@lishid lishid commented Dec 11, 2020

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 11.0.3
  • Operating System:
    • Windows 10 1909
  • Last Known Working Electron version:
    • Not sure

When HTML contains a contenteditable followed by regular text, selecting (backwards) from the regular text to the contenteditable, then pressing right click, will crash the renderer.

To Reproduce

Open page with the following code

<!DOCTYPE html><html><head><meta charset="UTF-8"><title>Hello World!</title></head>
<body><div contenteditable="true">Content Editable</div><p>Regular Text</p></body></html>

Select from "Regular Text" to "Content Editable", then right click on the selection with the cursor on "Regular Text".

Screenshots

test

Additional Information

Seems to be a chromium bug. I've filed a separate report at https://bugs.chromium.org/p/chromium/issues/detail?id=1157684

Filing an issue here to keep track. Probably not actionable and just going to wait for the upstream fix. Feel free to close if unnecessary.
@nornagon nornagon closed this Dec 15, 2020
@nornagon
Copy link
Member

@nornagon nornagon commented Dec 15, 2020

Thanks for the report but the chromium bug should be sufficient to track this! We'll receive the fix when chromium ships it and we roll automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked/upstream ❌
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@nornagon @lishid