Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm.createContext crash on 0.32.x #2755

Closed
tomashanacek opened this issue Sep 10, 2015 · 1 comment · Fixed by #2817
Closed

vm.createContext crash on 0.32.x #2755

tomashanacek opened this issue Sep 10, 2015 · 1 comment · Fixed by #2817

Comments

@tomashanacek
Copy link
Contributor

Electron Version: 0.32.1
System: OS X 10.9.5

electron

@deepak1556
Copy link
Member

@zcbenz related upstream bug nodejs/node#2091 (comment) and fix nodejs/node@56db28b

snippet to cause crash

require('vm').runInNewContext('')

stacktrace

#0  0x00007ffff773a0f8 in v8::internal::Internals::GetNodeState(v8::internal::Object**) () from /home/robo/github/shell/out/D/libnode.so
#1  0x00007ffff777da1e in v8::PersistentBase<v8::Context>::IsWeak() const () from /home/robo/github/shell/out/D/libnode.so
#2  0x00007ffff777d97c in v8::Local<v8::Context> node::PersistentToLocal<v8::Context>(v8::Isolate*, v8::Persistent<v8::Context, v8::NonCopyablePersistentTraits<v8::Context> > const&) ()
   from /home/robo/github/shell/out/D/libnode.so
#3  0x00007ffff777c4c9 in node::ContextifyContext::context() const () from /home/robo/github/shell/out/D/libnode.so
#4  0x00007ffff777cb68 in node::ContextifyContext::GlobalPropertyGetterCallback(v8::Local<v8::Name>, v8::PropertyCallbackInfo<v8::Value> const&) ()
   from /home/robo/github/shell/out/D/libnode.so
#5  0x00007ffff70baf97 in v8::internal::PropertyCallbackArguments::Call(void (*)(v8::Local<v8::Name>, v8::PropertyCallbackInfo<v8::Value> const&), v8::Local<v8::Name>) ()
   from /home/robo/github/shell/out/D/libv8.so
#6  0x00007ffff7360881 in v8::internal::JSObject::GetPropertyWithInterceptor(v8::internal::LookupIterator*, bool*) () from /home/robo/github/shell/out/D/libv8.so
#7  0x00007ffff7360527 in v8::internal::Object::GetProperty(v8::internal::LookupIterator*, v8::internal::LanguageMode) () from /home/robo/github/shell/out/D/libv8.so
#8  0x00007ffff73175f3 in v8::internal::LoadIC::Load(v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Name>) () from /home/robo/github/shell/out/D/libv8.so
#9  0x00007ffff731dbba in v8::internal::LoadIC_Miss(int, v8::internal::Object**, v8::internal::Isolate*) () from /home/robo/github/shell/out/D/libv8.so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants