Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Renderer Promise API stops working after page reload when allowRendererProcessReuse is true #28154

Closed
3 tasks done
VeryCrazyDog opened this issue Mar 12, 2021 · 4 comments · Fixed by #28175
Closed
3 tasks done

Comments

@VeryCrazyDog
Copy link

@VeryCrazyDog VeryCrazyDog commented Mar 12, 2021

Preflight Checklist

Electron Version

12.0.0

What operating system are you using?

Windows

Operating System Version

10

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

From the reproduce steps, expecting to see local files printed in the console:

...
preload.js:11 Reading file .gitignore
preload.js:11 Reading file index.html
preload.js:11 Reading file LICENSE.md
preload.js:11 Reading file main.js
preload.js:11 Reading file package-lock.json
...

Actual Behavior

List is printed the first time the app loads. Hit Ctrl+R and observe only one line printed, or none at all.

Testcase Gist URL

https://gist.github.com/e0d8e593f6f2d737a795d8e20ab5a37d

Additional Information

It might be related to issue #22119

@codebytere
Copy link
Member

@codebytere codebytere commented Mar 13, 2021

@VeryCrazyDog looks like this was re-introduced when i fixed another issue: #27582. I'll pop up a fix in a second.

@lishid
Copy link
Contributor

@lishid lishid commented Mar 19, 2021

In the closed bug report, there was an additional issue that was not fixed in v11: (#22119 (comment))

After many many sessions of debugging I found a repro (I'm on Windows 10):

  • Perform a long-running async node call (in my case, the call was fs.writeFile)
  • Reload the page before the call finishes.
  • Observe that any subsequent node calls never triggers the callback.
  • Reload again fixes the issue.

Not sure if this helps, but hopefully it can be resolved together 🙏

@aabuhijleh
Copy link

@aabuhijleh aabuhijleh commented Apr 7, 2021

@lishid which v11 version are you using? This bug is supposed to be re-introduced in 11.4.0

Moreover, this PR is still open #28336

The fix has not been ported to the 11.x.y series yet

@lishid
Copy link
Contributor

@lishid lishid commented Apr 7, 2021

I have only tested up until 11.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants