Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging during app startup? (ref: App is not a valid atom-shell application) #312

Closed
frankhale opened this issue May 14, 2014 · 6 comments
Closed

Comments

@frankhale
Copy link
Contributor

@frankhale frankhale commented May 14, 2014

Description of what I'm doing:

I'm porting the hello world app on the Quick Start page to Clojurescript

https://github.com/atom/atom-shell/blob/master/docs/tutorial/quick-start.md

Here is my port of main.js to Clojurescript:

https://gist.github.com/frankhale/8fe873601fb4212cdc87

I have the requisite files in my project and it works fine using the provided main.js. When I use my Clojurescript compiled main.js atom-shell tells me my app is not valid. The project structure is exactly as it should be and all I'm replacing is the Javascript version of main.js with a Clojurescript compiled main.js from my translation of the Javascript.

Question for atom-shell developers:

Is there a way to debug what is going on when atom-shell tries to start my application? I'm running atom.exe and dragging my app folder into the window. I've opened the dev tools but no errors are reported. All I get is a message saying that my app is not valid.

Question for somebody that may be able to help debug the Clojurescript:

If anyone knows Clojurescript would you mind taking a look at my Gist to see if I've made any crazy mistakes? I've been trying to get this working for several hours. The code looks straightforward enough and doesn't look like it should be a problem porting.

Here is a repo of my project for those that may want to have a look:

https://github.com/frankhale/hello-atom-shell

@zcbenz
Copy link
Member

@zcbenz zcbenz commented May 15, 2014

This is a duplicate of #294 and the fix would be included in the next release, usually you should follow application distribution to put your app inside atom-shell and then execute it, executing via command line or drag-drop is only an easy way for simple apps.

Loading

@zcbenz zcbenz closed this May 15, 2014
@frankhale
Copy link
Contributor Author

@frankhale frankhale commented May 15, 2014

Thank you! I've just taken the time to follow the application distribution guidelines and now I see weird errors that point into problems with the atom-shell and the Clojurescript runtime Javascript code. I'll wait for next release and try again.

Loading

@frankhale
Copy link
Contributor Author

@frankhale frankhale commented May 19, 2014

Just tried again using the standard app distribution process with 0.12.5 and get errors pointing to the Clojurescript runtime. While Clojurescript could be a problem I've written a bunch of code using it inside Node-Webkit and haven't had any issues like the screenshot suggests. The basic thing I'm trying to do is simply write the hello-app in Clojurescript. Nothing complex and everything seems quite straight forward. All the pertinent info is in the original post above.

atom-shell-error-clojurescript

Loading

@frankhale
Copy link
Contributor Author

@frankhale frankhale commented May 19, 2014

Not sure why I can't reopen this issue. My issue is not really the same as #294.

Loading

@frankhale
Copy link
Contributor Author

@frankhale frankhale commented May 20, 2014

I guess what I'll try next is to just leave the little bit of boiler code that bootstraps Atom and opens a new browser window in Javascript and then just include my Clojurescript compiled JS on my HTML page. I'll give that a try, hopefully no issues there.

Loading

@frankhale
Copy link
Contributor Author

@frankhale frankhale commented May 26, 2014

This is now working. Looks to be an issue in Clojurescript not Atom-Shell.

Anyone that is interested in the hello,world Atom app written in Clojurescript can see the code here:

https://github.com/frankhale/hello-atom-shell

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants