Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD support to electron #3797

Open
teran-mckinney opened this issue Dec 12, 2015 · 126 comments
Open

Add FreeBSD support to electron #3797

teran-mckinney opened this issue Dec 12, 2015 · 126 comments

Comments

@teran-mckinney
Copy link
Contributor

@teran-mckinney teran-mckinney commented Dec 12, 2015

Bountysource

Related: #2452

@zcbenz
Copy link
Member

@zcbenz zcbenz commented Dec 14, 2015

As mentioned in #2452, currently we don't have any plan to add support for FreeBSD, but if anyone is interested in sending a pull request, we will be very happy to accept it.

@zcbenz zcbenz closed this Dec 14, 2015
@teran-mckinney
Copy link
Contributor Author

@teran-mckinney teran-mckinney commented Dec 14, 2015

Hi @zcbenz,

Could you please keep this open? I opened the request and added a bounty to encourage someone to send in a PR adding in FreeBSD support.

Thank you,
Teran

@zcbenz
Copy link
Member

@zcbenz zcbenz commented Dec 15, 2015

Okay.

@yonas
Copy link

@yonas yonas commented Jun 4, 2016

I'm getting close to compiling electron on FreeBSD 10.3.

I have two errors standing in my way:

https://gist.github.com/yonas/06d08aa591e4a452b16c1e9a9ac5e0f3

but I'm not sure how to fix them. Any C/C++ gurus here? :)

@ghost
Copy link

@ghost ghost commented Aug 24, 2016

I see that $200 USD has been added to the bounty? Is this going to happen? I think it will rock if it does.

@yonas
Copy link

@yonas yonas commented Aug 25, 2016

Sorry, I'll try to spend more time on this. If anyone knows C/C++ very well, there are Linux specific parts that need to be re-implemented for FreeBSD.

Yes, Electron is becoming more popular and being used in more apps than just the Atom editor. I'd love to have the Black Screen terminal running on my FreeBSD machine.

@prash-wghats
Copy link

@prash-wghats prash-wghats commented Oct 12, 2016

Was able to build electron and VSCode in freebsd11RC1. the build instruction is posted in
https://gist.github.com/prash-wghats/89be1ee069d2acf23c289e9c606616e1

@yonas
Copy link

@yonas yonas commented Oct 12, 2016

@prash-wghats Great work!!! I'm curious, why did you compile with VSCode? Is there anything that GCC or CLANG is missing?

@ilundhild
Copy link

@ilundhild ilundhild commented Oct 12, 2016

This is awesome. Can't wait to try it out, and would love to see those changes moved forward.

@enlight
Copy link
Contributor

@enlight enlight commented Oct 12, 2016

@yonas @prash-wghats didn't build using VSCode, he built Electron & VSCode.

@prash-wghats
Copy link

@prash-wghats prash-wghats commented Oct 13, 2016

@yonas Thanks. Built electron using clang, then used it to run VSCode.

@grahamperrin
Copy link

@grahamperrin grahamperrin commented Jan 16, 2017

Upped the bounty.

(Incidentally: the reference, above, from an apparently Windows-related issue was the result of steering away from a multi-platform issue for the same product.)

@patrickalima98
Copy link

@patrickalima98 patrickalima98 commented Jun 7, 2017

Hello electron team, my compliments!!!! First I would like to congratulate you on the project and also leave here my desire as well as many others to see the electron running in the FresBSD, your application is very impressive and it would be great if you could add support to FreeBSD I very much enjoyed the platform and it would enable the BSDS systems to leverage enabling the creation of incredible apps.

@yuya-oc yuya-oc mentioned this issue Jun 10, 2017
1 of 1 task complete
@nomadlogic
Copy link

@nomadlogic nomadlogic commented Jun 24, 2017

Any chances of the patches referenced by prash-wghats commented on Oct 12, 2016 will be incorporated upstream? Are their blockers preventing this from happening, or anything the FreeBSD community can do to usher this along?

@prash-wghats
Copy link

@prash-wghats prash-wghats commented Jul 7, 2017

https://github.com/prash-wghats/VSCode-For-FreeBSD/releases.
This binaries were built with freebsd 11.

@pizzamig
Copy link

@pizzamig pizzamig commented Oct 2, 2018

https://github.com/yzgyyang/freebsd-ports-electron is a port, compatible and usable with poudriere, to build a FreeBSD package and is largely based on the great work of @prash-wghats . Without his insight, nothing would be possible.
Unfortunately, the port, as it is, cannot land to the Port Collection, it has too many tricks and things not allowed (especially the libcc and the node packages).
Currently, I'm working on an acceptable port for libcc. If you have ever build chromium from sources, you'll now why it's "time consuming".

@nornagon
Copy link
Member

@nornagon nornagon commented Oct 3, 2018

libcc is deprecated and not used in the current build of electron, so probably not a great idea to work on a port for it :)

@thenexxuz
Copy link

@thenexxuz thenexxuz commented Oct 3, 2018

Having it work in ports is good and all and I agree that it is a good start but there are apps that are closed source (GitKraken for example) I would not expect to have to directly support BSD but if it is an official platform for electron then they could cross compile a BSD build. But that cannot happen until there is an official build. That's just my opinion.

@dariusc93
Copy link

@dariusc93 dariusc93 commented Oct 3, 2018

I think the main hurdle currently to bring the port upstream is the chromium library. Could be wrong though, but other than that, if the patches for electron itself is brought upstream, then it should be good to go from there but there is also more to it since there is likely libraries out there that isnt built to run on BSD or isnt configured for the platform. It would still need to be work for devs to make sure any native modules can run on BSD as well. If there isnt any dependencies that make use of native modules, then it should be fine.

@kreinholz
Copy link

@kreinholz kreinholz commented Apr 19, 2019

+1 for this! Would love to get Atom and/or VS Code running on FreeBSD. CodeLite and Eclipse are all well and good, but I'd really like to be able to develop with Atom or VS Code without having to hop into a virtual machine running Linux.

@thenexxuz
Copy link

@thenexxuz thenexxuz commented Apr 22, 2019

How high does the bounty need to get before someone decides to do this? $1000 USD?

@tagattie
Copy link

@tagattie tagattie commented Apr 27, 2019

Hi, I have made an experimental port of electron 4.1.x and 5.0.0 for FreeBSD. This is largely based on the works by @prash-wghats and FreeBSD chromium team. If you are interested, take a look at https://github.com/tagattie/FreeBSD-Electron.

I'm running VS Code on FreeBSD with it for a while.

@nornagon
Copy link
Member

@nornagon nornagon commented Apr 30, 2019

@tagattie looks like that includes quite substantial changes to Chromium. Are you working with the Chromium team at all to upstream those changes? If not I'm afraid they will quickly go out of date :(

@tehpeh
Copy link

@tehpeh tehpeh commented May 1, 2019

@nornagon the Readme states the patches come from the FreeBSD Chromium team.

@pizzamig
Copy link

@pizzamig pizzamig commented May 14, 2019

@nornagon The FreeBSD Chromium team maintains a large set of patches, because Google doesn't accept those changes, because FreeBSD (and any other BSDs) is not a platform they're interested in.

@apfeifer
Copy link

@apfeifer apfeifer commented May 29, 2019

Published a few hours ago.
https://www.freshports.org/devel/electron4/

@dariusc93

This comment has been hidden.

@kreinholz

This comment has been hidden.

@electron electron deleted a comment from homerstrong Jun 22, 2019
@zoujiaqing
Copy link

@zoujiaqing zoujiaqing commented Aug 7, 2019

Thanks, can upgrade it to 6.0.x?

@lapo-luchini
Copy link

@lapo-luchini lapo-luchini commented Aug 7, 2019

There's a work-in-progress branch for 5.x but nothing on 6.x so far as far as I can see.

@ararslan
Copy link

@ararslan ararslan commented Aug 7, 2019

If this is now a registered port, someone should collect the BountySource bounty.

@thenexxuz
Copy link

@thenexxuz thenexxuz commented Aug 8, 2019

The point of this, if I understand correctly, to have Electron be able to generate a BSD build from any other platform. For example, on a Mac you can generate a Windows EXE or a Linux Binary. This is to allow them to generate the BSD Binary, not having to run BSD and then compile from there.

@crazyBaboon
Copy link

@crazyBaboon crazyBaboon commented Oct 16, 2019

+1 I would love to have atom available on FreeBSD. The bounty to fix this is 850$ now!

@grahamperrin
Copy link

@grahamperrin grahamperrin commented Nov 10, 2019

Might future resolution of this issue allow me to (for example) install FF Password Exporter https://github.com/kspearrin/ff-password-exporter on FreeBSD-CURRENT?

From https://pastebin.com/Z3mmYLh9 I imagine not. Line 19:

Error: GET https://github.com/electron/electron/releases/download/v3.0.6/electron-v3.0.6-freebsd-x64.zip returned 404

Background: MrAlex94/Waterfox#1258 (comment)

@chavez243ca
Copy link

@chavez243ca chavez243ca commented Jan 14, 2021

Want to see this happen so they can bring Brim to FreeBSD! Will try to contrib to the bounty.

@pizzamig
Copy link

@pizzamig pizzamig commented Jan 14, 2021

electron has been available on FreeBSD for a while.
The maintainer had some issues the packages have been removed when python 2.7 (a dependency) have been removed.
Now he is back and he's working on restoring them (electron7, electron8 and electron9)

@thenexxuz
Copy link

@thenexxuz thenexxuz commented Jan 15, 2021

electron has been available on FreeBSD for a while.

While you are able to RUN electron apps in FreeBSD you cannot BUILD an app and target BSD like you can with the other OSs. I write an app on a Mac and make a build target Linux or Windows, the same is not true for BSD. In order for a BSD build for an app to be made it needs to be built IN BSD. THAT is the support needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.