Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Internationalization bubble #47

Closed
mcolyer opened this issue Aug 6, 2013 · 14 comments
Closed

Hide Internationalization bubble #47

mcolyer opened this issue Aug 6, 2013 · 14 comments

Comments

@mcolyer
Copy link
Contributor

mcolyer commented Aug 6, 2013

If you press and hold the 'i' key you see this:

Screenshot of international character bubble

We should probably just suppress this as we don't really want it to appear.

@zcbenz
Copy link
Member

zcbenz commented Aug 6, 2013

This is a feature of Mac's input sources support, users using non-latin languages (for example Chinese) need it to input characters in their languages.

The real bug is: the bubble should be shown where the cursor is, like this:

screen shot 2013-08-06 at 2 29 54 pm

and this (inputing Chinese character):

screen shot 2013-08-06 at 2 30 33 pm

however in Atom, the bubble of input source always shows in the left top corner.

So I think our problem is not to hide the i18n bubble, but to show it in the right place, I'll see how to achieve it.

@mcolyer
Copy link
Contributor Author

mcolyer commented Aug 6, 2013

We'll I'd still like a way to disable it entirely although I agree that having the bubble follow the cursor would be good to have.

The reason I ran into it is that I'm creating vim bindings and I noticed that this pops up occasionally in command mode, where it's totally typically to hold and press characters and not intend to insert them.

@probablycorey
Copy link

We could try moving the editor's hidden text input field so it is always by
the main cursor. That might be a solution.

On Mon, Aug 5, 2013 at 11:38 PM, Cheng Zhao notifications@github.comwrote:

This is a feature of Mac's input sources support, users using non-latin
languages (for example Chinese) need it to input characters in their
languages.

The real bug is: the bubble should be shown where the cursor is, like this:

[image: screen shot 2013-08-06 at 2 29 54 pm]https://f.cloud.github.com/assets/639601/915205/a4dca04e-fe61-11e2-92aa-0a1e70cbd321.png

and this (inputing Chinese character):

[image: screen shot 2013-08-06 at 2 30 33 pm]https://f.cloud.github.com/assets/639601/915214/c821d5d8-fe61-11e2-82fb-82073b4925cd.png

however in Atom, the bubble of input source always shows in the left top
corner.

So I think our problem is not to hide the i18n bubble, but to show it in
the right place, I'll see how to achieve it.


Reply to this email directly or view it on GitHubhttps://github.com//issues/47#issuecomment-22161115
.

@nathansobo
Copy link

We tried that once. There was some problem with it that I sadly can't remember. Maybe we should try again.

@izuzak
Copy link
Contributor

izuzak commented Aug 7, 2013

I'm Croatian and use the i18n bubble all the time for our non-latin letters -- please don't kill it. 🙏

@kevinsawicki
Copy link
Contributor

I think we can close this issue right?

The bubble now appears by the cursor and as @izuzak mentioned, it is useful and we should keep it.

@mcolyer
Copy link
Contributor Author

mcolyer commented Nov 5, 2013

This is still annoying when I'm in vim mode and I press and hold l for movements.

@nathansobo
Copy link

Isn't it possible to disable this behavior at the OS X system level?

@mcolyer
Copy link
Contributor Author

mcolyer commented Nov 5, 2013

It'd be great if we could have that as an atom option, so that we don't have to tell users to go to their system preferences when they install vim-mode.

@zcbenz
Copy link
Member

zcbenz commented Nov 6, 2013

I think we can just disable IME when in vim mode, when IME is disabled in the <input> (for example <input> of password type), the bubble would not show.

@mcolyer
Copy link
Contributor Author

mcolyer commented Nov 6, 2013

I'm down for using that type="password" as a workaround. I'm for closing this now.

@mcolyer
Copy link
Contributor Author

mcolyer commented Mar 14, 2014

Reported by a user atom/vim-mode#175

@zcbenz
Copy link
Member

zcbenz commented Mar 15, 2014

@mcolyer This issue has been moved to atom/atom#1092, I think it could simply be implemented with @hiddenInput.attr('type', 'password').

@mcolyer
Copy link
Contributor Author

mcolyer commented Mar 17, 2014

Cool, I'll mention it over there.

kevinsawicki pushed a commit that referenced this issue May 9, 2017
kevinsawicki pushed a commit that referenced this issue May 9, 2017
* vendor/libchromiumcontent 656be94...ded3c0a (1):
  > Merge pull request #47 from brightray/chrome35
kevinsawicki pushed a commit that referenced this issue May 9, 2017
kevinsawicki pushed a commit that referenced this issue May 9, 2017
* vendor/libchromiumcontent 656be94...ded3c0a (1):
  > Merge pull request #47 from brightray/chrome35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants