Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to embed apps? #4930

Closed
cprussin opened this issue Mar 28, 2016 · 10 comments

Comments

Projects
None yet
5 participants
@cprussin
Copy link

commented Mar 28, 2016

  • Electron version: Any
  • Operating system: Linux

Does Electron support any way of embedding other electron apps (something like chrome's https://developer.chrome.com/apps/tags/appview)?

@MarshallOfSound

This comment has been minimized.

@JoshTheDerf

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2016

What degree of embedding are you referring to?

@cprussin

This comment has been minimized.

Copy link
Author

commented Mar 29, 2016

@MarshallOfSound I don't think webview is what I'm looking for, afaik you can only use it to embed websites and (again afaik) Electron apps don't expose an index.html that you can use with the webview's src.

@Tribex I'd like to be able to use a tag, similar to chrome's app-view, and have that tag contain a separate Electron app. My use case is that I'm working on an Electron-based web browser, and I'd like to be able to embed apps like Slack or Atom into tabs in my web browser.

I'm not familiar enough with these technologies to know if I can already do this, or whether it's too complex to build into Electron. I wouldn't need a functional menu bar or anything; just having the main app embedded into a DOM tag would be absolutely wonderful.

@anaisbetts

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2016

This isn't possible, sorry.

@cprussin

This comment has been minimized.

Copy link
Author

commented Mar 29, 2016

:-/ unfortunate. It seems like it would be a reasonable feature to implement; is this intentionally not supported or would you guys accept a PR adding it if I created one?

@anaisbetts

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2016

I can't imagine any non-trivial app that would work with this use-case

@cprussin

This comment has been minimized.

Copy link
Author

commented Mar 29, 2016

Can you be more descriptive? I can't imagine what wouldn't work well about something like Atom being embedded in a DOM tag...

Like, what are the specific problems that would make apps not work well?

@cprussin

This comment has been minimized.

Copy link
Author

commented Mar 29, 2016

Also, regarding my question... is this something that would be accepted if I submitted a PR for it?

@anaisbetts

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2016

Like, what are the specific problems that would make apps not work well?

The entire concept doesn't make much sense - the opening file in an Electron app is a node.js script that creates BrowserWindow objects - that opening script does all kinds of process-wide app startup stuff - like, Atom is much more than just a HTML file loaded in a window

@zcbenz

This comment has been minimized.

Copy link
Member

commented Mar 31, 2016

I'm closing this since we don't have any plan for it.

@zcbenz zcbenz closed this Mar 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.