Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Invalid package error when there is asar path in the command passed to child_process.exec #5571
I'm hitting this strange issue when using the
I've created a small snippet that reproduces the issue here. I tried creating a Gist, but it doesn't allow me to upload asar archives.
Basically, the elevation fails only then the command is executed from an electron process with
changed the title from
Invalid package when executing a command from an electron process with ELECTRON_RUN_AS_NODE
"Invalid package" when executing a command from an electron process with ELECTRON_RUN_AS_NODE
May 17, 2016
From the error information the whole command
Before this is fixed you have to modify the module to use
Hi @zcbenz ,
Thanks for your input. Using
By looking at Electron's
What do you think could be a real solution to this issue? Happy to work on it myself if you want. I can think of the following options right now:
The solution number 3 sounds like the most elegant one IMHO.
pushed a commit
May 18, 2016
referenced this issue
May 18, 2016
@zcbenz I'm working on the patch by following the third mentioned approach, but identifying the parts of the command is not something we could accurately do, since splitting by white spaces doesn't consider cases like paths containing spaces.
What do you think?
I'm wondering if a better solution would be to accept a custom