New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`resizable: false` also disables fullscreen #6664

Closed
andreyavram opened this Issue Jul 31, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@andreyavram

andreyavram commented Jul 31, 2016

  • Electron version: 1.3.1
  • Operating system: OS X 10.11.6

Hi,
I noticed an unintuitive behaviour, if I use resizable: false on browser window init, the fullscreen(green) button gets disabled and resize of window is also disabled.
But if I set the resizable:true on init, and immediately on ready-to-show I use mainWindow.setResizable(false) the green button stays activated, which is my expected behaviour. (I want to have a fullscreenable, but not resizable window).

Also, using this combination , I can only get a resize event, not a fullscreen on.

Maybe fulscreenable:true should have precedence over resizable:false? - (I used that with no effect)

Keep up the good work!

@andreyavram

This comment has been minimized.

andreyavram commented Jul 31, 2016

Also, if the app gets fullscreened, this has no effect:
require("electron").remote.getCurrentWindow().setContentSize(1080,1920) , calling getContentSize() returns the previous size.
Same thing with setSize, or setBounds.
Resizable is true.
Window.screen(rendered) correctly detects the height and width of the fullscreened app.

@zcbenz zcbenz changed the title from OS X fullscreen button to `resizable: false` also disables fullscreen Aug 1, 2016

@zcbenz zcbenz closed this in #6736 Aug 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment