New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 AU new emoji doesn't show properly #7334

Closed
iNViTiON opened this Issue Sep 24, 2016 · 14 comments

Comments

Projects
None yet
4 participants
@iNViTiON

iNViTiON commented Sep 24, 2016

  • Electron version: 1.4.1
  • Operating system: Windows 10 AU

Some new emoji can't display and show up as a square. i.e. http://emojipedia.org/first-place-medal/ <- this one can display in Edge, Opera and even in notepad.

@enlight

This comment has been minimized.

Contributor

enlight commented Sep 24, 2016

Do they show up in Chrome?

@iNViTiON

This comment has been minimized.

iNViTiON commented Sep 25, 2016

@enlight Yes. It's show up properly both in address bar and in page content.
image

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 26, 2016

@iNViTiON Are you using Chrome stable channel?

@iNViTiON

This comment has been minimized.

iNViTiON commented Sep 26, 2016

@zcbenz Yes. Version 53.0.2785.116 m

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Sep 28, 2016

I'm having trouble reproducing this, I see that example emoji in both Electron and Chrome on Windows 10 1607.

screen shot 2016-09-28 at 4 04 30 pm

@iNViTiON what specific Windows 10 version are you on? And can you include a screenshot of what you are seeing?

@iNViTiON

This comment has been minimized.

iNViTiON commented Sep 29, 2016

@kevinsawicki It look like the one appear on visual studio code. It also like this on my app too.
image

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Sep 29, 2016

@iNViTiON I don't think Visual Studio Code is using Electron 1.4 yet, can you try running npm install -g electron@1.4.1 and then run electron http://emojipedia.org/first-place-medal and see if they show up there?

@iNViTiON

This comment has been minimized.

iNViTiON commented Sep 29, 2016

@kevinsawicki I change package.json start script from "electron ." to "electron http://emojipedia.org/first-place-medal" to make sure that it the same version as I got with my app and it display correctly. But when I change back to "electron ." to run my app and it still show as square.
Here was it show on my app.
image
And it also can't type in Electron even it can display correctly in site content?
image

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Sep 29, 2016

@iNViTiON can you provide a minimal app that demonstrates this issue for you to help us reproduce this?

@iNViTiON

This comment has been minimized.

iNViTiON commented Sep 29, 2016

@kevinsawicki OK. I fork the quick start to demonstrate this here. -> https://github.com/iNViTiON/electron-quick-start

It should look like this.

image

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Sep 29, 2016

Thanks for the example, was able to reproduce, it is deciding to use Arial for those emojis instead of Segoe UI Emoji for some reason.

If you explicitly set the font-family in CSS to Segoe UI Emoji for those elements, they do render correctly in Electron.

@iNViTiON

This comment has been minimized.

iNViTiON commented Sep 30, 2016

@kevinsawicki Thank for quick fix.

@kevinsawicki kevinsawicki self-assigned this Oct 4, 2016

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Oct 4, 2016

Found the related Chromium issue that added support for this, https://bugs.chromium.org/p/chromium/issues/detail?id=620419

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Oct 4, 2016

An upstream Chromium fix for this has been opened at https://codereview.chromium.org/2387373003/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment