New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux - GTK] Titlebar/Menu GTKRC not matching when using the Browser option 'dark-theme' #765

Closed
nikolowry opened this Issue Oct 31, 2014 · 14 comments

Comments

Projects
None yet
@nikolowry

nikolowry commented Oct 31, 2014

Titlebar/Menu GTKRC not matching:
Theme Mismatch
Theme Mismatc


Are there any attempts being made to package a dark GTKRC theme with Atom Shell? I started using Linux after GTK2's heyday and I understand that legacy theming can be a nightmare.

As an end user, I've only been able to make dark GTK themes match up by following these set of instructions http://goo.gl/V1H5Zx.

@nikolowry nikolowry changed the title from [Linux - GTK] Toolbar/Menu GTKRC not matching when using the Browser option 'dark-theme' to [Linux - GTK] Titlebar/Menu GTKRC not matching when using the Browser option 'dark-theme' Nov 3, 2014

@mehcode

This comment has been minimized.

Show comment
Hide comment
@mehcode

mehcode Dec 16, 2014

@nikolowry I must ask for your icon set and gnome shell theme.

mehcode commented Dec 16, 2014

@nikolowry I must ask for your icon set and gnome shell theme.

@nikolowry

This comment has been minimized.

Show comment
Hide comment
@nikolowry

nikolowry Dec 16, 2014

Just wanted to add a little to this ticket. I haven't looked to deep into Atom Shell's source code, but it should be noted that Chromium has publicly stated it will not be upgrading to GTK3; so the GTK used in the shell relates to gtk2/gtkrc.

The styles in the shell I assume come from Chromium, and are documented here: https://code.google.com/p/chromium/wiki/LinuxGtkThemeIntegration.

I know there was interest in getting some of the newer Cocoa frames integrated into the shell, in regards to the OSX integration. Maybe it might be worth while to rewrite Chromium's c++ for pop-up frames? Port to gtk3 and newer cocoa (or it could just be a bunch of extra work)?


@mehcode Don't want to derail this issue ticket, but I'm using a modified Adwaita theme which I plan to release call "Matte-GTK". It requires 3.14 and uses the 3.16 wip gnome-shell. You can grab where I am at with it now here: https://gist.github.com/nikolowry/9ffc10559cf2620c8d2e

The theme is Numix Circle with a custom Avocode icon I made. If you need that, it's here: https://drive.google.com/file/d/0B32HO0fHRql9czV5WFBncVNLSUk/view?usp=sharing.

If you have anymore questions find me on Google+ https://plus.google.com/+NikoLowry/posts.

nikolowry commented Dec 16, 2014

Just wanted to add a little to this ticket. I haven't looked to deep into Atom Shell's source code, but it should be noted that Chromium has publicly stated it will not be upgrading to GTK3; so the GTK used in the shell relates to gtk2/gtkrc.

The styles in the shell I assume come from Chromium, and are documented here: https://code.google.com/p/chromium/wiki/LinuxGtkThemeIntegration.

I know there was interest in getting some of the newer Cocoa frames integrated into the shell, in regards to the OSX integration. Maybe it might be worth while to rewrite Chromium's c++ for pop-up frames? Port to gtk3 and newer cocoa (or it could just be a bunch of extra work)?


@mehcode Don't want to derail this issue ticket, but I'm using a modified Adwaita theme which I plan to release call "Matte-GTK". It requires 3.14 and uses the 3.16 wip gnome-shell. You can grab where I am at with it now here: https://gist.github.com/nikolowry/9ffc10559cf2620c8d2e

The theme is Numix Circle with a custom Avocode icon I made. If you need that, it's here: https://drive.google.com/file/d/0B32HO0fHRql9czV5WFBncVNLSUk/view?usp=sharing.

If you have anymore questions find me on Google+ https://plus.google.com/+NikoLowry/posts.

@varemenos

This comment has been minimized.

Show comment
Hide comment
@varemenos

varemenos commented Sep 10, 2015

👍

@bhack

This comment has been minimized.

Show comment
Hide comment
@bhack

bhack commented Oct 10, 2015

👍

1 similar comment
@kurisubrooks

This comment has been minimized.

Show comment
Hide comment
@kurisubrooks

kurisubrooks commented Mar 7, 2016

👍

@nikolowry

This comment has been minimized.

Show comment
Hide comment
@nikolowry

nikolowry May 24, 2016

Building libchromiumcontent/brightray/electron with gtk3 fixes this bug:

screenshot from 2016-05-24 02-51-28
screenshot from 2016-05-24 02-51-49

https://goo.gl/ydHspu

nikolowry commented May 24, 2016

Building libchromiumcontent/brightray/electron with gtk3 fixes this bug:

screenshot from 2016-05-24 02-51-28
screenshot from 2016-05-24 02-51-49

https://goo.gl/ydHspu

@kurisubrooks

This comment has been minimized.

Show comment
Hide comment
@kurisubrooks

kurisubrooks May 24, 2016

I've been aware of this "fix" for a while, but it's not included/bundled into Electron by default, hence the problem 😞

kurisubrooks commented May 24, 2016

I've been aware of this "fix" for a while, but it's not included/bundled into Electron by default, hence the problem 😞

@nikolowry

This comment has been minimized.

Show comment
Hide comment
@nikolowry

nikolowry May 24, 2016

@kurisubrooks I vaguely documented what you need to do in #2927. I'm trying to decide if the best way forward is to propose a pull request (since it spans 3 repos) or just uploading a gist of a bash/node script instead.

nikolowry commented May 24, 2016

@kurisubrooks I vaguely documented what you need to do in #2927. I'm trying to decide if the best way forward is to propose a pull request (since it spans 3 repos) or just uploading a gist of a bash/node script instead.

@nikolowry

This comment has been minimized.

Show comment
Hide comment
@kurisubrooks

This comment has been minimized.

Show comment
Hide comment
@kurisubrooks

kurisubrooks Jun 1, 2016

kurisubrooks commented Jun 1, 2016

@skewty

This comment has been minimized.

Show comment
Hide comment
@skewty

skewty Sep 27, 2016

has any progress been made on this?

skewty commented Sep 27, 2016

has any progress been made on this?

@jhasse

This comment has been minimized.

Show comment
Hide comment
@jhasse

jhasse Aug 1, 2017

has any progress been made on this?

Check #2927 for progress, it will fix this issue too.

jhasse commented Aug 1, 2017

has any progress been made on this?

Check #2927 for progress, it will fix this issue too.

@bilelmoussaoui

This comment has been minimized.

Show comment
Hide comment
@bilelmoussaoui

bilelmoussaoui Jan 17, 2018

This was already fixed! Now we should wait for the apps to update to the latest electron version 👍

bilelmoussaoui commented Jan 17, 2018

This was already fixed! Now we should wait for the apps to update to the latest electron version 👍

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Sep 23, 2018

Member

Closing as fixed!

Member

codebytere commented Sep 23, 2018

Closing as fixed!

@codebytere codebytere closed this Sep 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment