Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on get user prefs #7840

Closed
anaisbetts opened this issue Nov 1, 2016 · 1 comment
Closed

Crash on get user prefs #7840

anaisbetts opened this issue Nov 1, 2016 · 1 comment

Comments

@anaisbetts
Copy link
Contributor

@anaisbetts anaisbetts commented Nov 1, 2016

  • Electron version: 1.3.something
  • Operating system: OS X 10.10.5

Saw this in a user report, looks like GetUserDefault can return bogus values

0 com.github.electron.framework 0x00000001009b7304 base::Value::GetType() const + 4
1 com.github.electron.framework 0x00000001009b6c15 atom::V8ValueConverter::ToV8ValueImpl(v8::Isolate*, base::Value const*) const + 37
2 com.github.electron.framework 0x00000001009b6bbd atom::V8ValueConverter::ToV8Value(base::Value const*, v8::Local<v8::Context>) const + 77
3 com.github.electron.framework 0x00000001009b86cb mate::Converter<base::ListValue, void>::ToV8(v8::Isolate*, base::ListValue const&) + 59
4 com.github.electron.framework 0x00000001009c5ee9 v8::Local<v8::Value> mate::ConvertToV8<base::ListValue>(v8::Isolate*, base::ListValue const&) + 9
5 com.github.electron.framework 0x0000000100909e8a atom::api::SystemPreferences::GetUserDefault(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 1130
@kevinsawicki
Copy link
Contributor

@kevinsawicki kevinsawicki commented Nov 21, 2016

Fixed by #7993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.