New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating BrowerWindows with a parent always makes them show #8836

Closed
kirkouimet opened this Issue Mar 4, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@kirkouimet
Contributor

kirkouimet commented Mar 4, 2017

  • Electron version: 1.6.1
  • Operating system: macOS Sierra

When you do this from a renderer process:

new electron.remote.BrowserWindow(
    parent: parentBrowserWindow,
    show: false,
);

The browser window always shows even though the show option is false. If you do not provide a parent, the browser window respects the show option.

@kirkouimet kirkouimet changed the title from Creating BrowerWindow's with a parent always makes them show to Creating BrowerWindows with a parent always makes them show Mar 4, 2017

@xaviergonz

This comment has been minimized.

Contributor

xaviergonz commented Apr 28, 2017

Just adding to this, it happened to me when modal was false under osx. Did not test windows

@ionphractal

This comment has been minimized.

ionphractal commented May 1, 2017

'ready-to-show' is also not triggered.
It works properly for me under Windows and Linux.

@xaviergonz

This comment has been minimized.

Contributor

xaviergonz commented May 1, 2017

@kevinsawicki just created a pull request to fix this issue
#9343

I used this repo to test it works ok:
https://github.com/xaviergonz/electron-quick-start

@xaviergonz

This comment has been minimized.

Contributor

xaviergonz commented May 1, 2017

PS: It also fixes a bug where if a child window is hidden and then re-shown it looses its child window status.

@zcbenz zcbenz closed this in #9343 Sep 14, 2017

zcbenz added a commit that referenced this issue Sep 14, 2017

Merge pull request #9343 from xaviergonz/fix-osx-child-window-show
Make OSX child windows honor the show option to fix #8836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment