New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flicker with high DPI resolutions #9413

Open
bpasero opened this Issue May 9, 2017 · 9 comments

Comments

Projects
None yet
@bpasero
Copy link
Contributor

bpasero commented May 9, 2017

  • Electron version: >= 1.6.x
  • Operating system: macOS

Electron applications on macOS have a chance to exhibit very bad flickering depending on the environment:

  • OS is low on memory
  • lots of pixels are being drawn and updated (e.g. VS Code and scrolling the editor)
  • high DPI resolutions (e.g. external 4k or 5k monitor)

This is tracking Chromes bug https://bugs.chromium.org/p/chromium/issues/detail?id=719938 (which got merged into: https://bugs.chromium.org/p/chromium/issues/detail?id=631485). It reproduces in Chrome Stable 58. It does not reproduce in Electron 1.4.x.

Some animations how this looks like for VS Code:

flicker1
flicker2

@bpasero

This comment has been minimized.

Copy link
Contributor Author

bpasero commented Jul 18, 2017

It looks like a patch landed in Chrome for this: https://chromium.googlesource.com/chromium/src.git/+/0375ae80fe1d94e9d0fc175ce4312d1b3a6bc168

Could this (simple looking) patch be backported on a 1.7.x release? @cifratila fyi

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Aug 31, 2017

If this is fixed can this be closed @jkleinsc

@bpasero

This comment has been minimized.

Copy link
Contributor Author

bpasero commented Aug 31, 2017

Thanks a lot for backporting this fix I am getting confirmation from some insiders testers that the flickering is indeed fixed 👍

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Aug 31, 2017

Closing as this was fixed via #10390

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

alexeykuzmin commented Apr 28, 2018

https://chromium.googlesource.com/chromium/src.git/+/0375ae80fe1d94e9d0fc175ce4312d1b3a6bc168

Landed only in 61.0.3161.0, Chromium 59 (Electron 1.8.x) is still affected. Reopen.

@happypoulp

This comment has been minimized.

Copy link

happypoulp commented Jun 11, 2018

I am also reproducing this flickering issue in Electron 2.0.2. Since Electron 2.0.2 embeds Chromium 61 I also tried in "official" Chrome 61 and the issue is also present. I do not reproduce it in Chrome 62 and above.

Maybe it could help to apply #12945 on Electron 2.0.2. If I understood correctly, this patch is currently just applied on Electron 1.8.x?

@pshirshov

This comment has been minimized.

Copy link

pshirshov commented Jun 20, 2018

Still happens. VsCode and other electron apps are flickering on Mojave.

@xaviervilla

This comment has been minimized.

Copy link

xaviervilla commented Sep 16, 2018

I've consistently had this identical issue. List of apps effected for me:
Chrome, Opera, Chromium, VSCode, Atom, Signal. (Probably others I can't remember). It's really annoying and I have had this problem since I switched to linux in Janurary, and it happens on every version of linux I've tried. I have an i5 Surface Book w/ 8GB ram, (non-performance base/no dedicated GPU). My surface book uses 3,000x2,000 resolution.

My OS of choice right now is Ubuntu 16.04. I've tried different drivers, different kernels, etc. There are things that I can do to minimize this issue like going in and changing the chromium flags to --disable-gpu, or disabling hardware acceleration, but it doesn't completely stop the flickering, just reduces it, then I notice my fans kick on because of over stressing, and my battery drains much faster so I'd rather deal with the constant flickering every second.

I don't know what logs would be necessary to help with debugging but I'm happy to provide whatever.

@schnittchen

This comment has been minimized.

Copy link

schnittchen commented Oct 21, 2018

I experience the same with Rambox v0.6.1-1 (and older), which seems to use Electron 2.0.8 (https://github.com/ramboxapp/community-edition/blob/0.6.1/package.json#L176), on Linux.

The severity of the problem depends on the website displayed in Rambox. Trello is almost not usable. When moving the mouse, there is flickering, but there are also severe mispaints such that user interface elements are not visible.

I have a 3840x2160 screen resolution, scaled at 2x.

The problem goes away when I either

  • choose half the resolution, scaled at 1x
  • launch Rambox with "Disable Hardware Accelleration"

I am using the Intel HD 530 (Skylake GT2) onboard card with Xorg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment