New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a query string parsing problem happend to PDF Viewer #10008

Merged
merged 4 commits into from Jul 18, 2017

Conversation

Projects
None yet
3 participants
@qazbnm456
Contributor

qazbnm456 commented Jul 14, 2017

This PR should resolve #10007.

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Jul 14, 2017

Contributor

Would it be possible to add a new spec for this as well?

Contributor

kevinsawicki commented Jul 14, 2017

Would it be possible to add a new spec for this as well?

@deepak1556

Requires a few minor fixes, LGTM otherwise. Thanks @qazbnm456 !

Show outdated Hide outdated atom/browser/atom_resource_dispatcher_host_delegate.cc
@@ -52,9 +53,16 @@ AtomWebUIControllerFactory::CreateWebUIControllerForURL(content::WebUI* web_ui,
base::StringPairs toplevel_params;
base::SplitStringIntoKeyValuePairs(url.query(), '=', '&', &toplevel_params);
std::string stream_id, src;
const net::UnescapeRule::Type unescape_rules =

This comment has been minimized.

@deepak1556

deepak1556 Jul 14, 2017

Member

SPOOFING_AND_CONTROL_CHARS should be avoided. Also NORMAL rule need not be specified, any rule specified includes the normal rule by default.

@deepak1556

deepak1556 Jul 14, 2017

Member

SPOOFING_AND_CONTROL_CHARS should be avoided. Also NORMAL rule need not be specified, any rule specified includes the normal rule by default.

qazbnm456 added some commits Jul 15, 2017

@qazbnm456

This comment has been minimized.

Show comment
Hide comment
@qazbnm456

qazbnm456 Jul 15, 2017

Contributor

@kevinsawicki I'll see if I can figure out a way to add a new spec for this!
@deepak1556 Changes added. Thanks for your suggestions.

Contributor

qazbnm456 commented Jul 15, 2017

@kevinsawicki I'll see if I can figure out a way to add a new spec for this!
@deepak1556 Changes added. Thanks for your suggestions.

@qazbnm456

This comment has been minimized.

Show comment
Hide comment
@qazbnm456

qazbnm456 Jul 15, 2017

Contributor

@kevinsawicki A new spec has been added, and all checks have been passed as well. 😃

Contributor

qazbnm456 commented Jul 15, 2017

@kevinsawicki A new spec has been added, and all checks have been passed as well. 😃

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Jul 18, 2017

Contributor

A new spec has been added, and all checks have been passed as well. 😃

👍 Thanks for fixing this 🚢

Contributor

kevinsawicki commented Jul 18, 2017

A new spec has been added, and all checks have been passed as well. 😃

👍 Thanks for fixing this 🚢

@kevinsawicki kevinsawicki merged commit 1d9f69e into electron:master Jul 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@qazbnm456 qazbnm456 deleted the qazbnm456:fix-pdf-viewer branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment