New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the external binaries version #10071

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
4 participants
@joshaber
Contributor

joshaber commented Jul 20, 2017

Update to 1.2.1.

This is to update to Squirrel.Mac 0.3.1 which 馃檹 I believe 馃檹 fixes long-standing issues around update permissions and non-admin users.

@joshaber

This comment has been minimized.

Contributor

joshaber commented Jul 20, 2017

Is that Travis failure expected or did I break something?

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jul 20, 2017

Is that Travis failure expected or did I break something?

Don't worry about the Travis/AppVeyor builds, the jenkins ones are the legit ones.

@joshaber

This comment has been minimized.

Contributor

joshaber commented Jul 21, 2017

馃啋 Is this good to go?

@kevinsawicki kevinsawicki merged commit fac32e5 into master Jul 21, 2017

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #7356678 succeeded in 83s
Details
electron-linux-ia32 Build #7356679 succeeded in 79s
Details
electron-linux-x64 Build #7356680 succeeded in 201s
Details
electron-mas-x64 Build #4622 succeeded in 11 min
Details
electron-osx-x64 Build #4624 succeeded in 10 min
Details
electron-win-ia32 Build #3612 succeeded in 12 min
Details
electron-win-x64 Build #3602 succeeded in 10 min
Details

@kevinsawicki kevinsawicki deleted the update-external-binaries branch Jul 21, 2017

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jul 21, 2017

Is this good to go?

Yup yup, thanks for this @joshaber :shipit: 馃巻

@joshaber joshaber referenced this pull request Jul 28, 2017

Closed

Unable to update #2323

@jpike88

This comment has been minimized.

jpike88 commented Aug 1, 2017

@joshaber whens the next release of electron? This is a pretty important bug fix...

@joshaber

This comment has been minimized.

Contributor

joshaber commented Aug 1, 2017

I'm not sure as I'm not part of the core team. Maybe @zeke would know?

@zeke

This comment has been minimized.

Member

zeke commented Aug 1, 2017

We are planning to do a new 1.7 release this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment