New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leak the Node environment when context is released #10099

Merged
merged 1 commit into from Jul 31, 2017

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Jul 24, 2017

This reverts the change of #8811.

So when the Node environment is destroyed, there are still libuv async tasks running that may reuse that Node environment, even though Node should have cleared all libuv handles. It might caused by Node missing some corner cases, but even if Node has covered all cases on its side, it is still possible that some native modules just assume Node environments can live forever.

Close #9538, close #9303.

@zcbenz zcbenz merged commit 5b7cf19 into master Jul 31, 2017

5 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
electron-linux-arm Build #7387553 failed in 24s
Details
electron-linux-ia32 Build #7387554 failed in 18s
Details
electron-linux-x64 Build #7387555 failed in 17s
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-mas-x64 Build #4648 succeeded in 24 min
Details
electron-osx-x64 Build #4649 succeeded in 11 min
Details
electron-win-ia32 Build #3641 succeeded in 39 min
Details
electron-win-x64 Build #3630 succeeded in 26 min
Details

@zcbenz zcbenz deleted the leak-node-environment branch Jul 31, 2017

@zeke zeke referenced this pull request Jul 31, 2017

Merged

Backport fixes to 1.6 #10166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment