New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code and domain as properties to autoUpdater errors #10125

Merged
merged 6 commits into from Jul 27, 2017

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Jul 26, 2017

Fixes #7868

Prepends NSError code and domain to localizedErrorDescription such that the value seen on error is code:domain:localizedError Description.

Edited File: electron/atom/browser/auto_updater_mac.mm

@zeke zeke requested a review from MarshallOfSound Jul 26, 2017

@MarshallOfSound

Extra checked in file should go and I left an open suggestion RE making this a non-breaking change.

Show outdated Hide outdated atom/browser/ui/file_dialog_kde.cc
Show outdated Hide outdated atom/browser/auto_updater_mac.mm

Shelley Vohr added some commits Jul 27, 2017

Shelley Vohr and others added some commits Jul 27, 2017

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound
Member

MarshallOfSound commented Jul 27, 2017

🚢

@codebytere codebytere merged commit 768e838 into master Jul 27, 2017

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-mas-x64 Build #4674 succeeded in 13 min
Details
electron-osx-x64 Build #4676 succeeded in 11 min
Details
electron-win-ia32 Build #3665 succeeded in 13 min
Details
electron-win-x64 Build #3654 succeeded in 26 min
Details

@codebytere codebytere deleted the autoupdater_prefix_error_string branch Jul 27, 2017

@MarshallOfSound MarshallOfSound changed the title from prefix autoupdater error with statuscode and domain to Add code and domain as properties to autoUpdater errors Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment