New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scrubber touch bar item defaults #10133

Merged
merged 1 commit into from Jul 27, 2017

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Copy link
Member

MarshallOfSound commented Jul 27, 2017

Fixes #10132

false || true === true....

Basically continuous would always be a truthy value...

@MarshallOfSound MarshallOfSound requested a review from zeke Jul 27, 2017

@zeke

This comment has been minimized.

Copy link
Member

zeke commented Jul 27, 2017

* `continuous` Boolean - Defaults to `true`.

👍

@zeke zeke merged commit 6dfc7dc into master Jul 27, 2017

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-mas-x64 Build #4676 succeeded in 13 min
Details
electron-osx-x64 Build #4678 succeeded in 12 min
Details
electron-win-ia32 Build #3667 succeeded in 13 min
Details
electron-win-x64 Build #3656 succeeded in 26 min
Details

@zeke zeke deleted the fix-scrubber-continuous branch Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment