New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sandbox crash when opening a background tab #10264

Merged
merged 1 commit into from Aug 17, 2017

Conversation

Projects
None yet
2 participants
@tarruda
Contributor

tarruda commented Aug 14, 2017

When a link is clicked with the middle mouse button, chrome opens a window with
"background-tab" disposition. This is not currently handled in sandbox mode,
causing an api::WebContents to leak leading to eventual crash(since it has no
wrapper).

Also fix the event handler for "-add-new-contents" by having it call
event.preventDefault() when the window creation should be cancelled.

@tarruda tarruda requested review from zeke and zcbenz Aug 14, 2017

Fix sandbox crash when opening a background tab
When a link is clicked with the middle mouse button, chrome opens a window with
"background-tab" disposition. This is not currently handled in sandbox mode,
causing an api::WebContents to leak leading to eventual crash(since it has no
wrapper).

Also fix the event handler for "-add-new-contents" by having it call
`event.preventDefault()` when the window creation should be cancelled.
@zcbenz

zcbenz approved these changes Aug 17, 2017

@zcbenz zcbenz merged commit f6792c0 into master Aug 17, 2017

4 of 6 checks passed

electron-osx-x64 Build #4853 failed in 5 min 59 sec
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #4857 succeeded in 15 min
Details
electron-win-ia32 Build #3871 succeeded in 15 min
Details
electron-win-x64 Build #3854 succeeded in 26 min
Details

@zcbenz zcbenz deleted the fix-sandbox-crash-on-background-tab branch Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment