New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some optional args docs #10273

Merged
merged 2 commits into from Aug 18, 2017

Conversation

Projects
None yet
2 participants
@rhysd
Contributor

rhysd commented Aug 15, 2017

While moving from DefinitelyTyped's electron/index.d.ts to official electron.d.ts, I found some args should be optional. Fixed them in this PR.

@@ -405,7 +405,7 @@ Injects CSS into the guest page.
### `<webview>.executeJavaScript(code, userGesture, callback)`

This comment has been minimized.

@zcbenz

zcbenz Aug 17, 2017

Contributor

Can you also fix the function signature?

<webview>.executeJavaScript(code[, userGesture, callback])

This comment has been minimized.

@rhysd

rhysd Aug 17, 2017

Contributor

ok, I'll do

@rhysd

This comment has been minimized.

Contributor

rhysd commented Aug 17, 2017

I fixed the signature.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 18, 2017

Thanks!

@zcbenz zcbenz merged commit ac6a44f into electron:master Aug 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment